CssSelectorExistsRule::doValidation() - Code Metrics - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

CssSelectorExistsRule::doValidation() A
last analyzed 2019-05-12 19:55 UTC

↳ Parent: CssSelectorExistsRule

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	36
rs	9.0328
c	0
b	0
f	0
cc	5
nc	7
nop	1

<?php

namespace whm\Smoke\Rules\Html;

use Psr\Http\Message\ResponseInterface;
use Symfony\Component\CssSelector\CssSelectorConverter;
use whm\Smoke\Rules\StandardRule;
use whm\Smoke\Rules\ValidationFailedException;

/**
 * This rule checks if xpath is found in a html document.
 */
class CssSelectorExistsRule extends StandardRule
{
    protected $contentTypes = ['text/html'];

    private $cssSelectors;

    public function init(array $cssSelectors)
    {
        $this->cssSelectors = $cssSelectors;
    }

    public function doValidation(ResponseInterface $response)
    {
        $content = (string)$response->getBody();

        $domDocument = new \DOMDocument();
        @$domDocument->loadHTML($content);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $domXPath = new \DOMXPath($domDocument);

        $error = false;
        $snotFoundSelectors = array();

        $converter = new CssSelectorConverter();

        foreach ($this->cssSelectors as $selector) {

            try {
                $selectorAsXPath = $converter->toXPath($selector['pattern']);
            } catch (\Exception $e) {
                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
            }

            $count = $domXPath->query($selectorAsXPath)->length;

            if ($count === 0) {
                $error = true;
                $snotFoundSelectors[] = $selector['pattern'];
            }
        }

        if ($error === true) {
            $allNotFoundSelectors = implode('", "', $snotFoundSelectors);

            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
        }
    }
}


1			<?php
2
3			namespace whm\Smoke\Rules\Html;
4
5			use Psr\Http\Message\ResponseInterface;
6			use Symfony\Component\CssSelector\CssSelectorConverter;
7			use whm\Smoke\Rules\StandardRule;
8			use whm\Smoke\Rules\ValidationFailedException;
9
10			/**
11			* This rule checks if xpath is found in a html document.
12			*/
13			class CssSelectorExistsRule extends StandardRule
14			{
15			protected $contentTypes = ['text/html'];
16
17			private $cssSelectors;
18
19			public function init(array $cssSelectors)
20			{
21			$this->cssSelectors = $cssSelectors;
22			}
23
24			public function doValidation(ResponseInterface $response)
25			{
26			$content = (string)$response->getBody();
27
28			$domDocument = new \DOMDocument();
29			@$domDocument->loadHTML($content);
			0 ignored issues – show Security Best Practice introduced 2017-12-13 13:46 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
30
31			$domXPath = new \DOMXPath($domDocument);
32
33			$error = false;
34			$snotFoundSelectors = array();
35
36			$converter = new CssSelectorConverter();
37
38			foreach ($this->cssSelectors as $selector) {
39
40			try {
41			$selectorAsXPath = $converter->toXPath($selector['pattern']);
42			} catch (\Exception $e) {
43			throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
44			}
45
46			$count = $domXPath->query($selectorAsXPath)->length;
47
48			if ($count === 0) {
49			$error = true;
50			$snotFoundSelectors[] = $selector['pattern'];
51			}
52			}
53
54			if ($error === true) {
55			$allNotFoundSelectors = implode('", "', $snotFoundSelectors);
56
57			throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
58			}
59			}
60			}
61

phmLabs / Smoke

CssSelectorExistsRule::doValidation() A last analyzed 2019-05-12 19:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CssSelectorExistsRule::doValidation() A
last analyzed 2019-05-12 19:55 UTC