phingofficial / phing

src/Phing/PropertyHelper.php

Spacing +1 added lines, -1 removed lines

@@ -214,7 +214,7 @@
         while (false !== strpos($sb, '${')) {
             $sb = preg_replace_callback(
                 '/\$\{([^\$}]+)\}/',
-                function ($matches) use ($keys) {
+                function($matches) use ($keys) {
                     $propertyName = $matches[1];
 
                     $replacement = null;

src/Phing/Listener/DefaultLogger.php

Spacing +1 added lines, -1 removed lines

@@ -342,7 +342,7 @@
     public static function formatTime(float $seconds): string
     {
         /** @var float|int $number */
-        $getPlural = function ($number): string {
+        $getPlural = function($number): string {
             return 1 == $number ? '' : 's';
         };
         $chunks = [];

tests/Phing/Task/Optional/PHPStan/PHPStanAnalyseCommandBuilderTest.php

Indentation -16 removed lines

@@ -57,19 +57,3 @@
 
         $this->builder->build($task);
         $expectedCommand = <<< 'CMD'
-            Executing 'phpstan' with arguments:
-            'analyse'
-            '--configuration=anyConfiguration'
-            '--level=anyLevel'
-            '--no-progress'
-            '--debug'
-            '--autoload-file=anyAutoloadFile'
-            '--error-format=anyErrorFormat'
-            '--memory-limit=anyMemoryLimit'
-            'path1 path2'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Switch Indentation -16 removed lines

@@ -57,19 +57,3 @@
 
         $this->builder->build($task);
         $expectedCommand = <<< 'CMD'
-            Executing 'phpstan' with arguments:
-            'analyse'
-            '--configuration=anyConfiguration'
-            '--level=anyLevel'
-            '--no-progress'
-            '--debug'
-            '--autoload-file=anyAutoloadFile'
-            '--error-format=anyErrorFormat'
-            '--memory-limit=anyMemoryLimit'
-            'path1 path2'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Spacing -16 removed lines

@@ -57,19 +57,3 @@
 
         $this->builder->build($task);
         $expectedCommand = <<< 'CMD'
-            Executing 'phpstan' with arguments:
-            'analyse'
-            '--configuration=anyConfiguration'
-            '--level=anyLevel'
-            '--no-progress'
-            '--debug'
-            '--autoload-file=anyAutoloadFile'
-            '--error-format=anyErrorFormat'
-            '--memory-limit=anyMemoryLimit'
-            'path1 path2'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Braces -16 removed lines

@@ -57,19 +57,3 @@
 
         $this->builder->build($task);
         $expectedCommand = <<< 'CMD'
-            Executing 'phpstan' with arguments:
-            'analyse'
-            '--configuration=anyConfiguration'
-            '--level=anyLevel'
-            '--no-progress'
-            '--debug'
-            '--autoload-file=anyAutoloadFile'
-            '--error-format=anyErrorFormat'
-            '--memory-limit=anyMemoryLimit'
-            'path1 path2'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Upper-Lower-Casing -16 removed lines

@@ -57,19 +57,3 @@
 
         $this->builder->build($task);
         $expectedCommand = <<< 'CMD'
-            Executing 'phpstan' with arguments:
-            'analyse'
-            '--configuration=anyConfiguration'
-            '--level=anyLevel'
-            '--no-progress'
-            '--debug'
-            '--autoload-file=anyAutoloadFile'
-            '--error-format=anyErrorFormat'
-            '--memory-limit=anyMemoryLimit'
-            'path1 path2'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

tests/Phing/Task/Optional/PHPStan/PHPStanCommandBuilderTest.php

Indentation -50 removed lines

@@ -49,53 +49,3 @@
         $this->builder->build($task);
 
         $cmd = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($cmd, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-
-    public function testItFailsWhenExecutableNotSet(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('');
-
-        $this->expectException(BuildException::class);
-
-        $this->builder->build($task);
-    }
-
-    public function testItHandlesCommonOptions(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('anyExecutable');
-        $task->setCommand('anyCommand');
-
-        $task->setHelp(true);
-        $task->setQuiet(true);
-        $task->setVersion(true);
-        $task->setANSI(true);
-        $task->setNoANSI(true);
-        $task->setNoInteraction(true);
-        $task->setVerbose(true);
-
-        $this->builder->build($task);
-
-        $expectedCommand = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            '--help'
-            '--quiet'
-            '--version'
-            '--ansi'
-            '--no-ansi'
-            '--no-interaction'
-            '--verbose'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Switch Indentation -50 removed lines

@@ -49,53 +49,3 @@
         $this->builder->build($task);
 
         $cmd = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($cmd, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-
-    public function testItFailsWhenExecutableNotSet(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('');
-
-        $this->expectException(BuildException::class);
-
-        $this->builder->build($task);
-    }
-
-    public function testItHandlesCommonOptions(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('anyExecutable');
-        $task->setCommand('anyCommand');
-
-        $task->setHelp(true);
-        $task->setQuiet(true);
-        $task->setVersion(true);
-        $task->setANSI(true);
-        $task->setNoANSI(true);
-        $task->setNoInteraction(true);
-        $task->setVerbose(true);
-
-        $this->builder->build($task);
-
-        $expectedCommand = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            '--help'
-            '--quiet'
-            '--version'
-            '--ansi'
-            '--no-ansi'
-            '--no-interaction'
-            '--verbose'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Spacing -50 removed lines

@@ -49,53 +49,3 @@
         $this->builder->build($task);
 
         $cmd = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($cmd, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-
-    public function testItFailsWhenExecutableNotSet(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('');
-
-        $this->expectException(BuildException::class);
-
-        $this->builder->build($task);
-    }
-
-    public function testItHandlesCommonOptions(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('anyExecutable');
-        $task->setCommand('anyCommand');
-
-        $task->setHelp(true);
-        $task->setQuiet(true);
-        $task->setVersion(true);
-        $task->setANSI(true);
-        $task->setNoANSI(true);
-        $task->setNoInteraction(true);
-        $task->setVerbose(true);
-
-        $this->builder->build($task);
-
-        $expectedCommand = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            '--help'
-            '--quiet'
-            '--version'
-            '--ansi'
-            '--no-ansi'
-            '--no-interaction'
-            '--verbose'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Braces -50 removed lines

@@ -49,53 +49,3 @@
         $this->builder->build($task);
 
         $cmd = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($cmd, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-
-    public function testItFailsWhenExecutableNotSet(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('');
-
-        $this->expectException(BuildException::class);
-
-        $this->builder->build($task);
-    }
-
-    public function testItHandlesCommonOptions(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('anyExecutable');
-        $task->setCommand('anyCommand');
-
-        $task->setHelp(true);
-        $task->setQuiet(true);
-        $task->setVersion(true);
-        $task->setANSI(true);
-        $task->setNoANSI(true);
-        $task->setNoInteraction(true);
-        $task->setVerbose(true);
-
-        $this->builder->build($task);
-
-        $expectedCommand = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            '--help'
-            '--quiet'
-            '--version'
-            '--ansi'
-            '--no-ansi'
-            '--no-interaction'
-            '--verbose'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Upper-Lower-Casing -50 removed lines

@@ -49,53 +49,3 @@
         $this->builder->build($task);
 
         $cmd = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($cmd, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-
-    public function testItFailsWhenExecutableNotSet(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('');
-
-        $this->expectException(BuildException::class);
-
-        $this->builder->build($task);
-    }
-
-    public function testItHandlesCommonOptions(): void
-    {
-        $task = new PHPStanTask();
-        $task->setExecutable('anyExecutable');
-        $task->setCommand('anyCommand');
-
-        $task->setHelp(true);
-        $task->setQuiet(true);
-        $task->setVersion(true);
-        $task->setANSI(true);
-        $task->setNoANSI(true);
-        $task->setNoInteraction(true);
-        $task->setVerbose(true);
-
-        $this->builder->build($task);
-
-        $expectedCommand = <<<'CMD'
-            Executing 'anyExecutable' with arguments:
-            'anyCommand'
-            '--help'
-            '--quiet'
-            '--version'
-            '--ansi'
-            '--no-ansi'
-            '--no-interaction'
-            '--verbose'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

tests/Phing/Task/Optional/PHPStan/PHPStanListCommandBuilderTest.php

Indentation -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'list'
-            '--format=anyFormat'
-            '--raw'
-            'anyNamespace'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Switch Indentation -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'list'
-            '--format=anyFormat'
-            '--raw'
-            'anyNamespace'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Spacing -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'list'
-            '--format=anyFormat'
-            '--raw'
-            'anyNamespace'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Braces -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'list'
-            '--format=anyFormat'
-            '--raw'
-            'anyNamespace'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Upper-Lower-Casing -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'list'
-            '--format=anyFormat'
-            '--raw'
-            'anyNamespace'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

tests/Phing/Task/Optional/PHPStan/PHPStanHelpCommandBuilderTest.php

Indentation -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'help'
-            '--format=anyFormat'
-            '--raw'
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Switch Indentation -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'help'
-            '--format=anyFormat'
-            '--raw'
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Spacing -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'help'
-            '--format=anyFormat'
-            '--raw'
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Braces -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'help'
-            '--format=anyFormat'
-            '--raw'
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

Upper-Lower-Casing -11 removed lines

@@ -53,14 +53,3 @@
         $this->builder->build($task);
 
         $expectedCommand = <<<'CMD'
-            Executing 'phpstan' with arguments:
-            'help'
-            '--format=anyFormat'
-            '--raw'
-            'anyCommand'
-            The ' characters around the executable and arguments are not part of the command.
-            CMD;
-
-        $this->assertEquals($expectedCommand, str_replace("\r", '', $task->getCommandline()->describeCommand()));
-    }
-}

tests/Phing/Task/Optional/PDODelimitersTest.php

Indentation -141 removed lines

@@ -70,144 +70,3 @@
         // for some reason default splitter mangles spaces on subsequent lines
         $expected = [
             <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                delete
-                 from
-                 foo where bar = 'some value'
-                SQL,
-            <<<'SQL'
-                update dump -- I should not be ignored
-                 set message = 'I am a string with \\ backslash \' escapes and semicolons;'
-                SQL,
-            <<<'SQL'
-                create procedure setfoo(newfoo int)
-                 begin
-                 set @foo = newfoo;
-                 end
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-normal.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    public function testDelimiterTypeRow()
-    {
-        // for some reason default splitter mangles spaces on subsequent lines
-        $expected = [
-            <<<'SQL'
-                insert into "duh" (foo) values ('duh')
-                SQL,
-            <<<'SQL'
-                update "duh?" -- I should not be ignored
-                 set foo = 'some value'
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-row.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_ROW);
-        $this->mockTask->setDelimiter('duh');
-        $this->project->setProperty('foo.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    /**
-     * Checks that PDOSQLExecTask properly understands PostgreSQL dialect
-     * (especially "dollar quoting") when working with 'pgsql:' URLs.
-     *
-     * @see http://www.phing.info/trac/ticket/499
-     * @see http://www.postgresql.org/docs/9.0/interactive/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
-     */
-    public function testRequest499()
-    {
-        $expected = [
-            <<<'SQL'
-                select 1
-                # 2
-                SQL,
-            <<<'SQL'
-                select 'foo'
-                // 'bar'
-                SQL,
-            <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                create function foo(text)
-                returns boolean as
-                $function$
-                BEGIN
-                    RETURN ($1 ~ $q$[\t\r\n\v\\]$q$);
-                END;
-                $function$
-                language plpgsql
-                SQL,
-            <<<'SQL'
-                CREATE FUNCTION phingPDOtest() RETURNS "trigger"
-                    AS $_X$
-                if (1)
-                {
-                    # All is well - just continue
-
-                    return;
-                }
-                else
-                {
-                    # Not good - this is probably a fatal error!
-                    elog(ERROR,"True is not true");
-
-                    return "SKIP";
-                }
-                $_X$
-                    LANGUAGE plperl
-                SQL,
-            "insert into foo (bar) \nvalues ('some value')",
-            <<<'SQL'
-                insert into foo (bar) values ($$ a dollar-quoted string containing a few quotes ' ", a $placeholder$ and a semicolon;$$)
-                SQL,
-            <<<'SQL'
-                create rule blah_insert
-                as on insert to blah do instead (
-                    insert into foo values (new.id, 'blah');
-                    insert into bar values (new.id, 'blah-blah');
-                )
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-pgsql.sql'));
-        $this->mockTask->setUrl('pgsql:host=localhost;dbname=phing');
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-}

Switch Indentation -141 removed lines

@@ -70,144 +70,3 @@
         // for some reason default splitter mangles spaces on subsequent lines
         $expected = [
             <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                delete
-                 from
-                 foo where bar = 'some value'
-                SQL,
-            <<<'SQL'
-                update dump -- I should not be ignored
-                 set message = 'I am a string with \\ backslash \' escapes and semicolons;'
-                SQL,
-            <<<'SQL'
-                create procedure setfoo(newfoo int)
-                 begin
-                 set @foo = newfoo;
-                 end
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-normal.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    public function testDelimiterTypeRow()
-    {
-        // for some reason default splitter mangles spaces on subsequent lines
-        $expected = [
-            <<<'SQL'
-                insert into "duh" (foo) values ('duh')
-                SQL,
-            <<<'SQL'
-                update "duh?" -- I should not be ignored
-                 set foo = 'some value'
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-row.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_ROW);
-        $this->mockTask->setDelimiter('duh');
-        $this->project->setProperty('foo.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    /**
-     * Checks that PDOSQLExecTask properly understands PostgreSQL dialect
-     * (especially "dollar quoting") when working with 'pgsql:' URLs.
-     *
-     * @see http://www.phing.info/trac/ticket/499
-     * @see http://www.postgresql.org/docs/9.0/interactive/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
-     */
-    public function testRequest499()
-    {
-        $expected = [
-            <<<'SQL'
-                select 1
-                # 2
-                SQL,
-            <<<'SQL'
-                select 'foo'
-                // 'bar'
-                SQL,
-            <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                create function foo(text)
-                returns boolean as
-                $function$
-                BEGIN
-                    RETURN ($1 ~ $q$[\t\r\n\v\\]$q$);
-                END;
-                $function$
-                language plpgsql
-                SQL,
-            <<<'SQL'
-                CREATE FUNCTION phingPDOtest() RETURNS "trigger"
-                    AS $_X$
-                if (1)
-                {
-                    # All is well - just continue
-
-                    return;
-                }
-                else
-                {
-                    # Not good - this is probably a fatal error!
-                    elog(ERROR,"True is not true");
-
-                    return "SKIP";
-                }
-                $_X$
-                    LANGUAGE plperl
-                SQL,
-            "insert into foo (bar) \nvalues ('some value')",
-            <<<'SQL'
-                insert into foo (bar) values ($$ a dollar-quoted string containing a few quotes ' ", a $placeholder$ and a semicolon;$$)
-                SQL,
-            <<<'SQL'
-                create rule blah_insert
-                as on insert to blah do instead (
-                    insert into foo values (new.id, 'blah');
-                    insert into bar values (new.id, 'blah-blah');
-                )
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-pgsql.sql'));
-        $this->mockTask->setUrl('pgsql:host=localhost;dbname=phing');
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-}

Spacing -141 removed lines

@@ -70,144 +70,3 @@
         // for some reason default splitter mangles spaces on subsequent lines
         $expected = [
             <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                delete
-                 from
-                 foo where bar = 'some value'
-                SQL,
-            <<<'SQL'
-                update dump -- I should not be ignored
-                 set message = 'I am a string with \\ backslash \' escapes and semicolons;'
-                SQL,
-            <<<'SQL'
-                create procedure setfoo(newfoo int)
-                 begin
-                 set @foo = newfoo;
-                 end
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-normal.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    public function testDelimiterTypeRow()
-    {
-        // for some reason default splitter mangles spaces on subsequent lines
-        $expected = [
-            <<<'SQL'
-                insert into "duh" (foo) values ('duh')
-                SQL,
-            <<<'SQL'
-                update "duh?" -- I should not be ignored
-                 set foo = 'some value'
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-row.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_ROW);
-        $this->mockTask->setDelimiter('duh');
-        $this->project->setProperty('foo.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    /**
-     * Checks that PDOSQLExecTask properly understands PostgreSQL dialect
-     * (especially "dollar quoting") when working with 'pgsql:' URLs.
-     *
-     * @see http://www.phing.info/trac/ticket/499
-     * @see http://www.postgresql.org/docs/9.0/interactive/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
-     */
-    public function testRequest499()
-    {
-        $expected = [
-            <<<'SQL'
-                select 1
-                # 2
-                SQL,
-            <<<'SQL'
-                select 'foo'
-                // 'bar'
-                SQL,
-            <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                create function foo(text)
-                returns boolean as
-                $function$
-                BEGIN
-                    RETURN ($1 ~ $q$[\t\r\n\v\\]$q$);
-                END;
-                $function$
-                language plpgsql
-                SQL,
-            <<<'SQL'
-                CREATE FUNCTION phingPDOtest() RETURNS "trigger"
-                    AS $_X$
-                if (1)
-                {
-                    # All is well - just continue
-
-                    return;
-                }
-                else
-                {
-                    # Not good - this is probably a fatal error!
-                    elog(ERROR,"True is not true");
-
-                    return "SKIP";
-                }
-                $_X$
-                    LANGUAGE plperl
-                SQL,
-            "insert into foo (bar) \nvalues ('some value')",
-            <<<'SQL'
-                insert into foo (bar) values ($$ a dollar-quoted string containing a few quotes ' ", a $placeholder$ and a semicolon;$$)
-                SQL,
-            <<<'SQL'
-                create rule blah_insert
-                as on insert to blah do instead (
-                    insert into foo values (new.id, 'blah');
-                    insert into bar values (new.id, 'blah-blah');
-                )
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-pgsql.sql'));
-        $this->mockTask->setUrl('pgsql:host=localhost;dbname=phing');
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-}

Braces -141 removed lines

@@ -70,144 +70,3 @@
         // for some reason default splitter mangles spaces on subsequent lines
         $expected = [
             <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                delete
-                 from
-                 foo where bar = 'some value'
-                SQL,
-            <<<'SQL'
-                update dump -- I should not be ignored
-                 set message = 'I am a string with \\ backslash \' escapes and semicolons;'
-                SQL,
-            <<<'SQL'
-                create procedure setfoo(newfoo int)
-                 begin
-                 set @foo = newfoo;
-                 end
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-normal.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    public function testDelimiterTypeRow()
-    {
-        // for some reason default splitter mangles spaces on subsequent lines
-        $expected = [
-            <<<'SQL'
-                insert into "duh" (foo) values ('duh')
-                SQL,
-            <<<'SQL'
-                update "duh?" -- I should not be ignored
-                 set foo = 'some value'
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-row.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_ROW);
-        $this->mockTask->setDelimiter('duh');
-        $this->project->setProperty('foo.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    /**
-     * Checks that PDOSQLExecTask properly understands PostgreSQL dialect
-     * (especially "dollar quoting") when working with 'pgsql:' URLs.
-     *
-     * @see http://www.phing.info/trac/ticket/499
-     * @see http://www.postgresql.org/docs/9.0/interactive/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
-     */
-    public function testRequest499()
-    {
-        $expected = [
-            <<<'SQL'
-                select 1
-                # 2
-                SQL,
-            <<<'SQL'
-                select 'foo'
-                // 'bar'
-                SQL,
-            <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                create function foo(text)
-                returns boolean as
-                $function$
-                BEGIN
-                    RETURN ($1 ~ $q$[\t\r\n\v\\]$q$);
-                END;
-                $function$
-                language plpgsql
-                SQL,
-            <<<'SQL'
-                CREATE FUNCTION phingPDOtest() RETURNS "trigger"
-                    AS $_X$
-                if (1)
-                {
-                    # All is well - just continue
-
-                    return;
-                }
-                else
-                {
-                    # Not good - this is probably a fatal error!
-                    elog(ERROR,"True is not true");
-
-                    return "SKIP";
-                }
-                $_X$
-                    LANGUAGE plperl
-                SQL,
-            "insert into foo (bar) \nvalues ('some value')",
-            <<<'SQL'
-                insert into foo (bar) values ($$ a dollar-quoted string containing a few quotes ' ", a $placeholder$ and a semicolon;$$)
-                SQL,
-            <<<'SQL'
-                create rule blah_insert
-                as on insert to blah do instead (
-                    insert into foo values (new.id, 'blah');
-                    insert into bar values (new.id, 'blah-blah');
-                )
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-pgsql.sql'));
-        $this->mockTask->setUrl('pgsql:host=localhost;dbname=phing');
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-}

Upper-Lower-Casing -141 removed lines

@@ -70,144 +70,3 @@
         // for some reason default splitter mangles spaces on subsequent lines
         $expected = [
             <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                delete
-                 from
-                 foo where bar = 'some value'
-                SQL,
-            <<<'SQL'
-                update dump -- I should not be ignored
-                 set message = 'I am a string with \\ backslash \' escapes and semicolons;'
-                SQL,
-            <<<'SQL'
-                create procedure setfoo(newfoo int)
-                 begin
-                 set @foo = newfoo;
-                 end
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-normal.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    public function testDelimiterTypeRow()
-    {
-        // for some reason default splitter mangles spaces on subsequent lines
-        $expected = [
-            <<<'SQL'
-                insert into "duh" (foo) values ('duh')
-                SQL,
-            <<<'SQL'
-                update "duh?" -- I should not be ignored
-                 set foo = 'some value'
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        // and insists on "\n" linebreaks
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-row.sql'));
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_ROW);
-        $this->mockTask->setDelimiter('duh');
-        $this->project->setProperty('foo.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-
-    /**
-     * Checks that PDOSQLExecTask properly understands PostgreSQL dialect
-     * (especially "dollar quoting") when working with 'pgsql:' URLs.
-     *
-     * @see http://www.phing.info/trac/ticket/499
-     * @see http://www.postgresql.org/docs/9.0/interactive/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
-     */
-    public function testRequest499()
-    {
-        $expected = [
-            <<<'SQL'
-                select 1
-                # 2
-                SQL,
-            <<<'SQL'
-                select 'foo'
-                // 'bar'
-                SQL,
-            <<<'SQL'
-                insert into foo (bar, "strange;name""indeed") values ('bar''s value containing ;', 'a value for strange named column')
-                SQL,
-            <<<'SQL'
-                create function foo(text)
-                returns boolean as
-                $function$
-                BEGIN
-                    RETURN ($1 ~ $q$[\t\r\n\v\\]$q$);
-                END;
-                $function$
-                language plpgsql
-                SQL,
-            <<<'SQL'
-                CREATE FUNCTION phingPDOtest() RETURNS "trigger"
-                    AS $_X$
-                if (1)
-                {
-                    # All is well - just continue
-
-                    return;
-                }
-                else
-                {
-                    # Not good - this is probably a fatal error!
-                    elog(ERROR,"True is not true");
-
-                    return "SKIP";
-                }
-                $_X$
-                    LANGUAGE plperl
-                SQL,
-            "insert into foo (bar) \nvalues ('some value')",
-            <<<'SQL'
-                insert into foo (bar) values ($$ a dollar-quoted string containing a few quotes ' ", a $placeholder$ and a semicolon;$$)
-                SQL,
-            <<<'SQL'
-                create rule blah_insert
-                as on insert to blah do instead (
-                    insert into foo values (new.id, 'blah');
-                    insert into bar values (new.id, 'blah-blah');
-                )
-                SQL,
-            <<<'SQL'
-                insert into dump (message) values ('I am a statement not ending with a delimiter')
-                SQL,
-        ];
-        foreach ($expected as &$query) {
-            $query = str_replace(["\n\n", "\r"], ["\n", ''], $query);
-        }
-
-        $this->mockTask->setSrc(new File(PHING_TEST_BASE . '/etc/tasks/ext/pdo/delimiters-pgsql.sql'));
-        $this->mockTask->setUrl('pgsql:host=localhost;dbname=phing');
-        $this->mockTask->setDelimiterType(PDOSQLExecTask::DELIM_NORMAL);
-        $this->project->setProperty('bar.value', 'some value');
-        $this->project->executeTarget('test');
-
-        $this->assertEquals($expected, $this->queries);
-    }
-}

tests/Phing/Task/System/EchoXMLTest.php

Indentation -12 removed lines

@@ -50,15 +50,3 @@
         $this->assertStringEqualsFile(
             $this->getProject()->getProperty('file'),
             <<< 'XML'
-                <project name="failure" default="" basedir=".">
-                  <fail message="foo=bar"/>
-                </project>
-                XML
-        );
-    }
-
-    public function testEmpty(): void
-    {
-        $this->expectBuildException('testEmpty', 'No nested XML specified');
-    }
-}

Switch Indentation -12 removed lines

@@ -50,15 +50,3 @@
         $this->assertStringEqualsFile(
             $this->getProject()->getProperty('file'),
             <<< 'XML'
-                <project name="failure" default="" basedir=".">
-                  <fail message="foo=bar"/>
-                </project>
-                XML
-        );
-    }
-
-    public function testEmpty(): void
-    {
-        $this->expectBuildException('testEmpty', 'No nested XML specified');
-    }
-}

Spacing -12 removed lines

@@ -50,15 +50,3 @@
         $this->assertStringEqualsFile(
             $this->getProject()->getProperty('file'),
             <<< 'XML'
-                <project name="failure" default="" basedir=".">
-                  <fail message="foo=bar"/>
-                </project>
-                XML
-        );
-    }
-
-    public function testEmpty(): void
-    {
-        $this->expectBuildException('testEmpty', 'No nested XML specified');
-    }
-}

Braces -12 removed lines

@@ -50,15 +50,3 @@
         $this->assertStringEqualsFile(
             $this->getProject()->getProperty('file'),
             <<< 'XML'
-                <project name="failure" default="" basedir=".">
-                  <fail message="foo=bar"/>
-                </project>
-                XML
-        );
-    }
-
-    public function testEmpty(): void
-    {
-        $this->expectBuildException('testEmpty', 'No nested XML specified');
-    }
-}

Upper-Lower-Casing -12 removed lines

@@ -50,15 +50,3 @@
         $this->assertStringEqualsFile(
             $this->getProject()->getProperty('file'),
             <<< 'XML'
-                <project name="failure" default="" basedir=".">
-                  <fail message="foo=bar"/>
-                </project>
-                XML
-        );
-    }
-
-    public function testEmpty(): void
-    {
-        $this->expectBuildException('testEmpty', 'No nested XML specified');
-    }
-}

tests/Phing/Filter/StripWhitespaceTest.php

Indentation -9 removed lines

@@ -47,12 +47,3 @@
         $resultFile = $this->getProject()->resolveFile('result/stripwhitespace.test');
 
         $expected = <<<'EXPECTED'
-            <?php
-            class { public function __construct() { return ''; } }
-            EXPECTED;
-
-        $result = file_get_contents($resultFile->getAbsolutePath());
-
-        $this->assertEquals($expected, $result, "Files don't match!");
-    }
-}

Switch Indentation -9 removed lines

@@ -47,12 +47,3 @@
         $resultFile = $this->getProject()->resolveFile('result/stripwhitespace.test');
 
         $expected = <<<'EXPECTED'
-            <?php
-            class { public function __construct() { return ''; } }
-            EXPECTED;
-
-        $result = file_get_contents($resultFile->getAbsolutePath());
-
-        $this->assertEquals($expected, $result, "Files don't match!");
-    }
-}

Spacing -9 removed lines

@@ -47,12 +47,3 @@
         $resultFile = $this->getProject()->resolveFile('result/stripwhitespace.test');
 
         $expected = <<<'EXPECTED'
-            <?php
-            class { public function __construct() { return ''; } }
-            EXPECTED;
-
-        $result = file_get_contents($resultFile->getAbsolutePath());
-
-        $this->assertEquals($expected, $result, "Files don't match!");
-    }
-}

Braces -9 removed lines

@@ -47,12 +47,3 @@
         $resultFile = $this->getProject()->resolveFile('result/stripwhitespace.test');
 
         $expected = <<<'EXPECTED'
-            <?php
-            class { public function __construct() { return ''; } }
-            EXPECTED;
-
-        $result = file_get_contents($resultFile->getAbsolutePath());
-
-        $this->assertEquals($expected, $result, "Files don't match!");
-    }
-}

Upper-Lower-Casing -9 removed lines

@@ -47,12 +47,3 @@
         $resultFile = $this->getProject()->resolveFile('result/stripwhitespace.test');
 
         $expected = <<<'EXPECTED'
-            <?php
-            class { public function __construct() { return ''; } }
-            EXPECTED;
-
-        $result = file_get_contents($resultFile->getAbsolutePath());
-
-        $this->assertEquals($expected, $result, "Files don't match!");
-    }
-}