HgBaseTask::checkRepositoryIsDirAndExists() - Code Metrics - Inspection of "[core] Move internal build steps from travis to gi..." - phingofficial/phing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a862c8...fef60d )

by Siad

created 2020-12-07 21:36 UTC

HgBaseTask::checkRepositoryIsDirAndExists() A

↳ Parent: HgBaseTask

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php
/**
 * Utilise Mercurial from within Phing.
 *
 * PHP Version 5.4
 *
 * @category Tasks
 * @package  phing.tasks.ext
 * @author   Ken Guest <[email protected]>
 * @license  LGPL (see http://www.gnu.org/licenses/lgpl.html)
 * @link     https://github.com/kenguest/Phing-HG
 */

/**
 * Base task for integrating phing and mercurial.
 *
 * @category Tasks
 * @package  phing.tasks.ext.hg
 * @author   Ken Guest <[email protected]>
 * @license  LGPL (see http://www.gnu.org/licenses/lgpl.html)
 * @link     HgBaseTask.php
 */
abstract class HgBaseTask extends Task
{
    /**
     * Insecure argument
     *
     * @var string
     */
    protected $insecure = '';

    /**
     * Repository directory
     *
     * @var string
     */
    protected $repository = '';

    /**
     * Whether to be quiet... --quiet argument.
     *
     * @var bool
     */
    protected $quiet = false;

    /**
     * Username.
     *
     * @var string
     */
    protected $user = '';

    public static $factory = null;
    /**
     * Set repository attribute
     *
     * @param string $repository Repository
     *
     * @return void
     */
    public function setRepository($repository)
    {
        $this->repository = $repository;
    }


    /**
     * Set the quiet attribute --quiet
     *
     * @param string $quiet yes|no|true|false|1|0
     *
     * @return void
     */
    public function setQuiet($quiet)
    {
        $this->quiet = StringHelper::booleanValue($quiet);
    }

    /**
     * Get the quiet attribute value.
     *
     * @return bool
     */
    public function getQuiet()
    {
        return $this->quiet;
    }

    /**
     * Get Repository attribute/directory.
     *
     * @return string
     */
    public function getRepository()
    {
        return $this->repository;
    }

    /**
     * Set insecure attribute
     *
     * @param string $insecure 'yes', etc.
     *
     * @return void
     */
    public function setInsecure($insecure)
    {
        $this->insecure = StringHelper::booleanValue($insecure);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Get 'insecure' attribute value. (--insecure or null)
     *
     * @return string
     */
    public function getInsecure()
    {
        return $this->insecure;
    }

    /**
     * Set user attribute
     *
     * @param string $user username/email address.
     *
     * @return void
     */
    public function setUser($user)
    {
        $this->user = $user;
    }

    /**
     * Get username attribute.
     *
     * @return string
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * Check provided repository directory actually is an existing directory.
     *
     * @param string $dir Repository directory
     *
     * @return bool
     * @throws BuildException
     */
    public function checkRepositoryIsDirAndExists($dir)
    {
        if (file_exists($dir)) {
            if (!is_dir($dir)) {
                throw new BuildException("Repository '$dir' is not a directory.");
            }
        } else {
            throw new BuildException("Repository directory '$dir' does not exist.");
        }
        return true;
    }

    /**
     * Initialise the task.
     *
     * @return void
     */
    public function init()
    {
        @include_once 'vendor/autoload.php';
    }

    public function getFactoryInstance($command, $options = [])
    {
        $vchq = '\\Siad007\\VersionControl\\HG\\Factory';
        self::$factory = $vchq::getInstance($command, $options);
        return self::$factory;
    }
}


1		<?php
2		/**
3		* Utilise Mercurial from within Phing.
4		*
5		* PHP Version 5.4
6		*
7		* @category Tasks
8		* @package phing.tasks.ext
9		* @author Ken Guest <[email protected]>
10		* @license LGPL (see http://www.gnu.org/licenses/lgpl.html)
11		* @link https://github.com/kenguest/Phing-HG
12		*/
13
14		/**
15		* Base task for integrating phing and mercurial.
16		*
17		* @category Tasks
18		* @package phing.tasks.ext.hg
19		* @author Ken Guest <[email protected]>
20		* @license LGPL (see http://www.gnu.org/licenses/lgpl.html)
21		* @link HgBaseTask.php
22		*/
23		abstract class HgBaseTask extends Task
24		{
25		/**
26		* Insecure argument
27		*
28		* @var string
29		*/
30		protected $insecure = '';
31
32		/**
33		* Repository directory
34		*
35		* @var string
36		*/
37		protected $repository = '';
38
39		/**
40		* Whether to be quiet... --quiet argument.
41		*
42		* @var bool
43		*/
44		protected $quiet = false;
45
46		/**
47		* Username.
48		*
49		* @var string
50		*/
51		protected $user = '';
52
53		public static $factory = null;
54		/**
55		* Set repository attribute
56		*
57		* @param string $repository Repository
58		*
59		* @return void
60		*/
61	16	public function setRepository($repository)
62		{
63	16	$this->repository = $repository;
64	16	}
65
66
67		/**
68		* Set the quiet attribute --quiet
69		*
70		* @param string $quiet yes\|no\|true\|false\|1\|0
71		*
72		* @return void
73		*/
74		public function setQuiet($quiet)
75		{
76		$this->quiet = StringHelper::booleanValue($quiet);
77		}
78
79		/**
80		* Get the quiet attribute value.
81		*
82		* @return bool
83		*/
84	15	public function getQuiet()
85		{
86	15	return $this->quiet;
87		}
88
89		/**
90		* Get Repository attribute/directory.
91		*
92		* @return string
93		*/
94	3	public function getRepository()
95		{
96	3	return $this->repository;
97		}
98
99		/**
100		* Set insecure attribute
101		*
102		* @param string $insecure 'yes', etc.
103		*
104		* @return void
105		*/
106		public function setInsecure($insecure)
107		{
108		$this->insecure = StringHelper::booleanValue($insecure);
		0 ignored issues – show Documentation Bug introduced 2019-07-31 09:36 UTC by Report Bug Copy Issue Report The property `$insecure` was declared of type `string`, but `StringHelper::booleanValue($insecure)` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
109		}
110
111		/**
112		* Get 'insecure' attribute value. (--insecure or null)
113		*
114		* @return string
115		*/
116	11	public function getInsecure()
117		{
118	11	return $this->insecure;
119		}
120
121		/**
122		* Set user attribute
123		*
124		* @param string $user username/email address.
125		*
126		* @return void
127		*/
128	2	public function setUser($user)
129		{
130	2	$this->user = $user;
131	2	}
132
133		/**
134		* Get username attribute.
135		*
136		* @return string
137		*/
138	1	public function getUser()
139		{
140	1	return $this->user;
141		}
142
143		/**
144		* Check provided repository directory actually is an existing directory.
145		*
146		* @param string $dir Repository directory
147		*
148		* @return bool
149		* @throws BuildException
150		*/
151	11	public function checkRepositoryIsDirAndExists($dir)
152		{
153	11	if (file_exists($dir)) {
154	7	if (!is_dir($dir)) {
155	7	throw new BuildException("Repository '$dir' is not a directory.");
156		}
157		} else {
158	4	throw new BuildException("Repository directory '$dir' does not exist.");
159		}
160	7	return true;
161		}
162
163		/**
164		* Initialise the task.
165		*
166		* @return void
167		*/
168	22	public function init()
169		{
170	22	@include_once 'vendor/autoload.php';
171	22	}
172
173	21	public function getFactoryInstance($command, $options = [])
174		{
175	21	$vchq = '\\Siad007\\VersionControl\\HG\\Factory';
176	21	self::$factory = $vchq::getInstance($command, $options);
177	21	return self::$factory;
178		}
179		}
180

phingofficial / phing

Push — master ( a862c8...fef60d )

HgBaseTask::checkRepositoryIsDirAndExists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like