HgBaseTask::setInsecure() - Code Metrics - Inspection of "Add missing requires php extension to tests (patch..." - phingofficial/phing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 8d4d49...a3997f )

by Michiel

created 2025-07-07 09:53 UTC

HgBaseTask::setInsecure() A

↳ Parent: HgBaseTask

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
rs	10
ccs	0
cts	0
cp	0
cc	1
nc	1
nop	1
crap	2

<?php

/**
 * Utilise Mercurial from within Phing.
 *
 * PHP Version 5.4
 *
 * @category Tasks
 * @package  phing.tasks.ext
 * @author   Ken Guest <[email protected]>
 * @license  LGPL (see http://www.gnu.org/licenses/lgpl.html)
 * @link     https://github.com/kenguest/Phing-HG
 */

namespace Phing\Task\Ext\Hg;

use Phing\Task;
use Phing\Exception\BuildException;
use Phing\Util\StringHelper;
use Siad007\VersionControl\HG\Factory;

/**
 * Base task for integrating phing and mercurial.
 *
 * @category Tasks
 * @package  phing.tasks.ext.hg
 * @author   Ken Guest <[email protected]>
 * @license  LGPL (see http://www.gnu.org/licenses/lgpl.html)
 * @link     HgBaseTask.php
 */
abstract class HgBaseTask extends Task
{
    /**
     * Insecure argument
     *
     * @var string
     */
    protected $insecure = '';

    /**
     * Repository directory
     *
     * @var string
     */
    protected $repository = '';

    /**
     * Whether to be quiet... --quiet argument.
     *
     * @var bool
     */
    protected $quiet = false;

    /**
     * Username.
     *
     * @var string
     */
    protected $user = '';

    public static $factory = null;

    /**
     * Initialize Task.
     * Check and include necessary libraries.
     */
    public function init()
    {
        if (!class_exists(Factory::class)) {
            throw new BuildException(
                "The Hg tasks depend on the siad007/versioncontrol_hg package being installed.",
                $this->getLocation()
            );
        }
    }

    /**
     * Set repository attribute
     *
     * @param string $repository Repository
     *
     * @return void
     */
    public function setRepository($repository)
    {
        $this->repository = $repository;
    }


    /**
     * Set the quiet attribute --quiet
     *
     * @param string $quiet yes|no|true|false|1|0
     *
     * @return void
     */
    public function setQuiet($quiet)
    {
        $this->quiet = StringHelper::booleanValue($quiet);
    }

    /**
     * Get the quiet attribute value.
     *
     * @return bool
     */
    public function getQuiet()
    {
        return $this->quiet;
    }

    /**
     * Get Repository attribute/directory.
     *
     * @return string
     */
    public function getRepository()
    {
        return $this->repository;
    }

    /**
     * Set insecure attribute
     *
     * @param string $insecure 'yes', etc.
     *
     * @return void
     */
    public function setInsecure($insecure)
    {
        $this->insecure = StringHelper::booleanValue($insecure);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Get 'insecure' attribute value. (--insecure or null)
     *
     * @return string
     */
    public function getInsecure()
    {
        return $this->insecure;
    }

    /**
     * Set user attribute
     *
     * @param string $user username/email address.
     *
     * @return void
     */
    public function setUser($user)
    {
        $this->user = $user;
    }

    /**
     * Get username attribute.
     *
     * @return string
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * Check provided repository directory actually is an existing directory.
     *
     * @param string $dir Repository directory
     *
     * @return bool
     * @throws BuildException
     */
    public function checkRepositoryIsDirAndExists($dir)
    {
        if (file_exists($dir)) {
            if (!is_dir($dir)) {
                throw new BuildException("Repository '$dir' is not a directory.");
            }
        } else {
            throw new BuildException("Repository directory '$dir' does not exist.");
        }
        return true;
    }

    public function getFactoryInstance($command, $options = [])
    {
        self::$factory = Factory::getInstance($command, $options);
        return self::$factory;
    }
}


1		<?php
2
3		/**
4		* Utilise Mercurial from within Phing.
5		*
6		* PHP Version 5.4
7		*
8		* @category Tasks
9		* @package phing.tasks.ext
10		* @author Ken Guest <[email protected]>
11		* @license LGPL (see http://www.gnu.org/licenses/lgpl.html)
12		* @link https://github.com/kenguest/Phing-HG
13		*/
14
15		namespace Phing\Task\Ext\Hg;
16
17		use Phing\Task;
18		use Phing\Exception\BuildException;
19		use Phing\Util\StringHelper;
20		use Siad007\VersionControl\HG\Factory;
21
22		/**
23		* Base task for integrating phing and mercurial.
24		*
25		* @category Tasks
26		* @package phing.tasks.ext.hg
27		* @author Ken Guest <[email protected]>
28		* @license LGPL (see http://www.gnu.org/licenses/lgpl.html)
29		* @link HgBaseTask.php
30		*/
31		abstract class HgBaseTask extends Task
32		{
33		/**
34		* Insecure argument
35		*
36		* @var string
37		*/
38		protected $insecure = '';
39
40		/**
41		* Repository directory
42		*
43		* @var string
44		*/
45		protected $repository = '';
46
47		/**
48		* Whether to be quiet... --quiet argument.
49		*
50		* @var bool
51		*/
52		protected $quiet = false;
53
54		/**
55		* Username.
56		*
57		* @var string
58		*/
59		protected $user = '';
60
61		public static $factory = null;
62
63		/**
64		* Initialize Task.
65		* Check and include necessary libraries.
66		*/
67		public function init()
68		{
69	16	if (!class_exists(Factory::class)) {
70		throw new BuildException(
71	16	"The Hg tasks depend on the siad007/versioncontrol_hg package being installed.",
72		$this->getLocation()
73		);
74		}
75		}
76
77		/**
78		* Set repository attribute
79		*
80		* @param string $repository Repository
81		*
82		* @return void
83		*/
84		public function setRepository($repository)
85		{
86		$this->repository = $repository;
87		}
88
89
90		/**
91		* Set the quiet attribute --quiet
92	15	*
93		* @param string $quiet yes\|no\|true\|false\|1\|0
94	15	*
95		* @return void
96		*/
97		public function setQuiet($quiet)
98		{
99		$this->quiet = StringHelper::booleanValue($quiet);
100		}
101
102	3	/**
103		* Get the quiet attribute value.
104	3	*
105		* @return bool
106		*/
107		public function getQuiet()
108		{
109		return $this->quiet;
110		}
111
112		/**
113		* Get Repository attribute/directory.
114		*
115		* @return string
116		*/
117		public function getRepository()
118		{
119		return $this->repository;
120		}
121
122		/**
123		* Set insecure attribute
124	11	*
125		* @param string $insecure 'yes', etc.
126	11	*
127		* @return void
128		*/
129		public function setInsecure($insecure)
130		{
131		$this->insecure = StringHelper::booleanValue($insecure);
		0 ignored issues – show Documentation Bug introduced 2021-01-21 09:52 UTC by Report Bug Copy Issue Report The property `$insecure` was declared of type `string`, but `Phing\Util\StringHelper::booleanValue($insecure)` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
132		}
133
134		/**
135		* Get 'insecure' attribute value. (--insecure or null)
136	2	*
137		* @return string
138	2	*/
139		public function getInsecure()
140		{
141		return $this->insecure;
142		}
143
144		/**
145		* Set user attribute
146	1	*
147		* @param string $user username/email address.
148	1	*
149		* @return void
150		*/
151		public function setUser($user)
152		{
153		$this->user = $user;
154		}
155
156		/**
157		* Get username attribute.
158		*
159	11	* @return string
160		*/
161	11	public function getUser()
162	7	{
163		return $this->user;
164		}
165
166	4	/**
167		* Check provided repository directory actually is an existing directory.
168	7	*
169		* @param string $dir Repository directory
170		*
171	21	* @return bool
172		* @throws BuildException
173	21	*/
174	21	public function checkRepositoryIsDirAndExists($dir)
175		{
176		if (file_exists($dir)) {
177		if (!is_dir($dir)) {
178		throw new BuildException("Repository '$dir' is not a directory.");
179		}
180		} else {
181		throw new BuildException("Repository directory '$dir' does not exist.");
182		}
183		return true;
184		}
185
186		public function getFactoryInstance($command, $options = [])
187		{
188		self::$factory = Factory::getInstance($command, $options);
189		return self::$factory;
190		}
191		}
192

phingofficial / phing

Push — main ( 8d4d49...a3997f )

HgBaseTask::setInsecure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like