phingofficial /
phing
| Conditions | 18 |
| Paths | 64 |
| Total Lines | 97 |
| Code Lines | 62 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 40 |
| CRAP Score | 28.8171 |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | 32 | public function restrict(&$files, $srcDir, $destDir, $mapper, $force = false) |
|
| 68 | { |
||
| 69 | 32 | $now = time(); |
|
| 70 | 32 | $targetList = ""; |
|
|
Unused Code
introduced
by
|
|||
| 71 | |||
| 72 | /* |
||
| 73 | If we're on Windows, we have to munge the time up to 2 secs to |
||
| 74 | be able to check file modification times. |
||
| 75 | (Windows has a max resolution of two secs for modification times) |
||
| 76 | */ |
||
| 77 | 32 | $osname = strtolower(Phing::getProperty('os.name')); |
|
| 78 | |||
| 79 | // indexOf() |
||
| 80 | 32 | $index = ((($res = strpos($osname, 'win')) === false) ? -1 : $res); |
|
| 81 | 32 | if ($index >= 0) { |
|
| 82 | $now += 2000; |
||
| 83 | } |
||
| 84 | |||
| 85 | 32 | $v = []; |
|
| 86 | |||
| 87 | 32 | for ($i = 0, $size = count($files); $i < $size; $i++) { |
|
| 88 | 31 | $targets = $mapper->main($files[$i]); |
|
| 89 | 31 | if (empty($targets)) { |
|
| 90 | 3 | $this->task->log($files[$i] . " skipped - don't know how to handle it", Project::MSG_VERBOSE); |
|
| 91 | 3 | continue; |
|
| 92 | } |
||
| 93 | |||
| 94 | 31 | $src = null; |
|
| 95 | try { |
||
| 96 | 31 | if ($srcDir === null) { |
|
| 97 | $src = new PhingFile($files[$i]); |
||
| 98 | } else { |
||
| 99 | 31 | $src = $this->fileUtils->resolveFile($srcDir, $files[$i]); |
|
| 100 | } |
||
| 101 | |||
| 102 | 31 | if ($src->lastModified() > $now) { |
|
| 103 | $this->task->log( |
||
| 104 | "Warning: " . $files[$i] . " modified in the future (" . $src->lastModified() . " > " . $now . ")", |
||
| 105 | 31 | Project::MSG_WARN |
|
| 106 | ); |
||
| 107 | } |
||
| 108 | } catch (IOException $ioe) { |
||
| 109 | $this->task->log("Unable to read file " . $files[$i] . " (skipping): " . $ioe->getMessage()); |
||
| 110 | continue; |
||
| 111 | } |
||
| 112 | |||
| 113 | 31 | $added = false; |
|
| 114 | 31 | $targetList = ""; |
|
| 115 | |||
| 116 | 31 | for ($j = 0, $_j = count($targets); (!$added && $j < $_j); $j++) { |
|
| 117 | 31 | $dest = null; |
|
| 118 | 31 | if ($destDir === null) { |
|
| 119 | 3 | $dest = new PhingFile($targets[$j]); |
|
| 120 | } else { |
||
| 121 | 28 | $dest = $this->fileUtils->resolveFile($destDir, $targets[$j]); |
|
| 122 | } |
||
| 123 | |||
| 124 | 31 | if (!$dest->exists()) { |
|
| 125 | 29 | $this->task->log( |
|
| 126 | 29 | ($files[$i] ?: ".") . " added as " . $dest->__toString() . " doesn't exist.", |
|
| 127 | 29 | Project::MSG_VERBOSE |
|
| 128 | ); |
||
| 129 | 29 | $v[] = $files[$i]; |
|
| 130 | 29 | $added = true; |
|
| 131 | 19 | } elseif ($src->lastModified() > $dest->lastModified()) { |
|
| 132 | $this->task->log( |
||
| 133 | $files[$i] . " added as " . $dest->__toString() . " is outdated.", |
||
| 134 | Project::MSG_VERBOSE |
||
| 135 | ); |
||
| 136 | $v[] = $files[$i]; |
||
| 137 | $added = true; |
||
| 138 | 19 | } elseif ($force === true) { |
|
| 139 | $this->task->log( |
||
| 140 | $files[$i] . " added as " . $dest->__toString() . " is forced to be overwritten.", |
||
| 141 | Project::MSG_VERBOSE |
||
| 142 | ); |
||
| 143 | $v[] = $files[$i]; |
||
| 144 | $added = true; |
||
| 145 | } else { |
||
| 146 | 19 | if (strlen($targetList) > 0) { |
|
| 147 | $targetList .= ", "; |
||
| 148 | } |
||
| 149 | 19 | $targetList .= $dest->getAbsolutePath(); |
|
| 150 | } |
||
| 151 | } |
||
| 152 | |||
| 153 | 31 | if (!$added) { |
|
| 154 | 19 | $this->task->log( |
|
| 155 | 19 | $files[$i] . " omitted as " . $targetList . " " . (count( |
|
| 156 | $targets |
||
| 157 | 19 | ) === 1 ? " is " : " are ") . "up to date.", |
|
| 158 | 19 | Project::MSG_VERBOSE |
|
| 159 | ); |
||
| 160 | } |
||
| 161 | } |
||
| 162 | |||
| 163 | 32 | return $v; |
|
| 164 | } |
||
| 188 |
Loading history...