phingofficial /
phing
| Total Complexity | 56 |
| Total Lines | 264 |
| Duplicated Lines | 0 % |
| Coverage | 86.67% |
| Changes | 0 | ||
Complex classes like PgsqlPDOQuerySplitter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PgsqlPDOQuerySplitter, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 36 | class PgsqlPDOQuerySplitter extends PDOQuerySplitter |
||
| 37 | { |
||
| 38 | /**#@+ |
||
| 39 | * Lexer states |
||
| 40 | */ |
||
| 41 | public const STATE_NORMAL = 0; |
||
| 42 | public const STATE_SINGLE_QUOTED = 1; |
||
| 43 | public const STATE_DOUBLE_QUOTED = 2; |
||
| 44 | public const STATE_DOLLAR_QUOTED = 3; |
||
| 45 | public const STATE_COMMENT_LINEEND = 4; |
||
| 46 | public const STATE_COMMENT_MULTILINE = 5; |
||
| 47 | public const STATE_BACKSLASH = 6; |
||
| 48 | /**#@-*/ |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Nesting depth of current multiline comment |
||
| 52 | * |
||
| 53 | * @var int |
||
| 54 | */ |
||
| 55 | protected $commentDepth = 0; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * Current dollar-quoting "tag" |
||
| 59 | * |
||
| 60 | * @var string |
||
| 61 | */ |
||
| 62 | protected $quotingTag = ''; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * Current lexer state, one of STATE_* constants |
||
| 66 | * |
||
| 67 | * @var int |
||
| 68 | */ |
||
| 69 | protected $state = self::STATE_NORMAL; |
||
| 70 | |||
| 71 | /** |
||
| 72 | * Whether a backslash was just encountered in quoted string |
||
| 73 | * |
||
| 74 | * @var bool |
||
| 75 | */ |
||
| 76 | protected $escape = false; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * Current source line being examined |
||
| 80 | * |
||
| 81 | * @var string |
||
| 82 | */ |
||
| 83 | protected $line = ''; |
||
| 84 | |||
| 85 | /** |
||
| 86 | * Position in current source line |
||
| 87 | * |
||
| 88 | * @var int |
||
| 89 | */ |
||
| 90 | protected $inputIndex; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Gets next symbol from the input, false if at end |
||
| 94 | * |
||
| 95 | * @return string|bool |
||
| 96 | */ |
||
| 97 | 1 | public function getc() |
|
| 109 | } |
||
| 110 | |||
| 111 | /** |
||
| 112 | * Bactracks one symbol on the input |
||
| 113 | * |
||
| 114 | * NB: we don't need ungetc() at the start of the line, so this case is |
||
| 115 | * not handled. |
||
| 116 | */ |
||
| 117 | 1 | public function ungetc() |
|
| 118 | { |
||
| 119 | 1 | $this->inputIndex--; |
|
| 120 | 1 | } |
|
| 121 | |||
| 122 | /** |
||
| 123 | * Checks whether symbols after $ are a valid dollar-quoting tag |
||
| 124 | * |
||
| 125 | * @return string|bool Dollar-quoting "tag" if it is present, false otherwise |
||
| 126 | */ |
||
| 127 | 1 | protected function checkDollarQuote() |
|
| 128 | { |
||
| 129 | 1 | $ch = $this->getc(); |
|
| 130 | 1 | if ('$' === $ch) { |
|
| 131 | // empty tag |
||
| 132 | 1 | return ''; |
|
| 133 | } |
||
| 134 | |||
| 135 | 1 | if (!ctype_alpha($ch) && '_' !== $ch) { |
|
| 136 | // not a delimiter |
||
| 137 | 1 | $this->ungetc(); |
|
| 138 | |||
| 139 | 1 | return false; |
|
| 140 | } |
||
| 141 | |||
| 142 | 1 | $tag = $ch; |
|
| 143 | 1 | while (false !== ($ch = $this->getc())) { |
|
| 144 | 1 | if ('$' === $ch) { |
|
| 145 | 1 | return $tag; |
|
| 146 | } |
||
| 147 | |||
| 148 | 1 | if (ctype_alnum($ch) || '_' === $ch) { |
|
| 149 | 1 | $tag .= $ch; |
|
| 150 | } else { |
||
| 151 | for ($i = 0, $tagLength = strlen($tag); $i < $tagLength; $i++) { |
||
|
Bug
introduced
by
|
|||
| 152 | $this->ungetc(); |
||
| 153 | } |
||
| 154 | |||
| 155 | return false; |
||
| 156 | } |
||
| 157 | } |
||
| 158 | } |
||
| 159 | |||
| 160 | /** |
||
| 161 | * @return null|string |
||
| 162 | */ |
||
| 163 | 1 | public function nextQuery() |
|
| 300 | } |
||
| 301 | } |
||
| 302 |
Loading history...
