OlderThan::compare() - Code Metrics - Inspection of "nicer method name" - philiplb/Valdi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4fa3c4...9bcafd )

by Philip

created 2016-03-16 11:10 UTC

OlderThan::compare() A

↳ Parent: OlderThan

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	4
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	4
loc	4
rs	10
nc	1
cc	1
eloc	3
nop	3

<?php

/*
 * This file is part of the Valdi package.
 *
 * (c) Philip Lehmann-Böhm <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Valdi\Validator;

/**
 * Validator for a date time being older than a certain amount of seconds
 * compared to the current moment.
 * For the format, see:
 * http://php.net/manual/en/datetime.createfromformat.php
 */
class OlderThan extends AbstractDateTimeComparator {


    /**
     * Holds whether to parse the parameters as \DateTimes so the child class
     * can decide.
     */
    protected $parseParametersAsDateTimes = false;


    /**
     * Holds the type of the validator.
     */
    protected $type = 'olderThan';

    /**
     * {@inheritdoc}
     */
    protected function isValidComparison(\DateTime $date, array $datetimes, array $parameters) {
        $now = new \DateTime();
        return $now->getTimestamp() - $date->getTimestamp() > $parameters[0];
    }

}


1		<?php
2
3		/*
4		* This file is part of the Valdi package.
5		*
6		* (c) Philip Lehmann-Böhm <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Valdi\Validator;
13
14		/**
15		* Validator for a date time being older than a certain amount of seconds
16		* compared to the current moment.
17		* For the format, see:
18		* http://php.net/manual/en/datetime.createfromformat.php
19		*/
20	View Code Duplication	class OlderThan extends AbstractDateTimeComparator {
		0 ignored issues – show Duplication introduced 2016-03-15 14:40 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21
22		/**
23		* Holds whether to parse the parameters as \DateTimes so the child class
24		* can decide.
25		*/
26		protected $parseParametersAsDateTimes = false;
		0 ignored issues – show Comprehensibility Naming introduced 2016-03-15 13:55 UTC by Report Bug Copy Issue Report The variable name `$parseParametersAsDateTimes` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
27
28		/**
29		* Holds the type of the validator.
30		*/
31		protected $type = 'olderThan';
32
33		/**
34		* {@inheritdoc}
35		*/
36		protected function isValidComparison(\DateTime $date, array $datetimes, array $parameters) {
37		$now = new \DateTime();
38		return $now->getTimestamp() - $date->getTimestamp() > $parameters[0];
39		}
40
41		}
42

philiplb / Valdi

Push — master ( 4fa3c4...9bcafd )

OlderThan::compare() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like