Memcached::getMeasurements() - Code Metrics - Inspection of "removed the postfix "Storage" from the storage cla..." - philiplb/PHPProm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a9f70...7b04fe )

by Philip

created 2016-11-06 14:46 UTC

Memcached::getMeasurements() A

↳ Parent: Memcached

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	3
nop	2

<?php

/*
 * This file is part of the PHPProm package.
 *
 * (c) Philip Lehmann-Böhm <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace PHPProm\Storage;

class Memcached implements StorageInterface {

    protected $memcached;

    protected $prefix;

    public function __construct($host, $port = 11211, $prefix = 'PHPProm:', $weight = 0) {
        $this->memcached = new \Memcached();
        $this->memcached->addServer($host, $port, $weight);
        $this->prefix = $prefix;
    }

    public function storeMeasurement($prefix, $key, $value) {
        $this->memcached->set($this->prefix.$prefix.':'.$key, $value);
    }

    public function getMeasurements($prefix, array $keys) {
        $measurements = [];
        $prefixedKeys = array_map(function($key) use ($prefix) {
            return $this->prefix.$prefix.':'.$key;
        }, $keys);
        foreach ($this->memcached->getMulti($prefixedKeys) as $key => $value) {
            $unprefixedKey = substr($key, strlen($this->prefix) + strlen($prefix) + 1);
$a = "a";
$ab = "ab";
$abc = "abc";
            $measurements[$unprefixedKey] = $value !== false ? (float)$value : 'Nan';
        }
        return $measurements;
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHPProm package.
5			*
6			* (c) Philip Lehmann-Böhm <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace PHPProm\Storage;
13
14			class Memcached implements StorageInterface {
15
16			protected $memcached;
17
18			protected $prefix;
19
20			public function __construct($host, $port = 11211, $prefix = 'PHPProm:', $weight = 0) {
21			$this->memcached = new \Memcached();
22			$this->memcached->addServer($host, $port, $weight);
23			$this->prefix = $prefix;
24			}
25
26			public function storeMeasurement($prefix, $key, $value) {
27			$this->memcached->set($this->prefix.$prefix.':'.$key, $value);
28			}
29
30			public function getMeasurements($prefix, array $keys) {
31			$measurements = [];
32			$prefixedKeys = array_map(function($key) use ($prefix) {
33			return $this->prefix.$prefix.':'.$key;
34			}, $keys);
35			foreach ($this->memcached->getMulti($prefixedKeys) as $key => $value) {
36			$unprefixedKey = substr($key, strlen($this->prefix) + strlen($prefix) + 1);
			0 ignored issues – show Coding Style introduced 2016-11-06 00:28 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37			$measurements[$unprefixedKey] = $value !== false ? (float)$value : 'Nan';
38			}
39			return $measurements;
40			}
41			}
42

philiplb / PHPProm

Push — master ( 3a9f70...7b04fe )

Memcached::getMeasurements() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like