DBALStorage - Code Metrics - Inspection of "reduced the line count a bit" - philiplb/PHPProm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85f910...e74426 )

by Philip

created 2016-11-06 00:42 UTC

DBALStorage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	1
dl	0
loc	75
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	storeMeasurement()	10	2
A	getMeasurements()	22	3
A	buildStatements()	22	1
A	__construct()	5	1

<?php

/*
 * This file is part of the PHPProm package.
 *
 * (c) Philip Lehmann-Böhm <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace PHPProm\Storage;

use \Doctrine\DBAL\Connection;

class DBALStorage extends AbstractStorage {

    protected $connection;

    protected $table;

    protected $statementKeyExists;

    protected $statementKeyInsert;

    protected $statementKeyUpdate;

    protected function buildStatements() {
        $queryBuilder = $this->connection->createQueryBuilder()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('COUNT(`key`) AS amount')
            ->from('`'.$this->table.'`')
            ->where('`key` = ?')
        ;
        $this->statementKeyExists = $this->connection->prepare($queryBuilder->getSQL());

        $queryBuilder = $this->connection->createQueryBuilder()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->insert('`'.$this->table.'`')
            ->setValue('`value`', '?')
            ->setValue('`key`', '?')
        ;
        $this->statementKeyInsert = $this->connection->prepare($queryBuilder->getSQL());

        $queryBuilder = $this->connection->createQueryBuilder()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->update('`'.$this->table.'`')
            ->set('`value`', '?')
            ->where('`key` = ?')
        ;
        $this->statementKeyUpdate = $this->connection->prepare($queryBuilder->getSQL());
    }

    public function __construct(Connection $connection, $table = 'phpprom') {
        $this->connection = $connection;
        $this->table      = $table;
        $this->buildStatements();
    }

    public function storeMeasurement($prefix, $key, $value) {
        $prefixedKey = $prefix.':'.$key;
        $this->statementKeyExists->bindValue(1, $prefixedKey);
        $this->statementKeyExists->execute();
        $exists         = $this->statementKeyExists->fetch(\PDO::FETCH_ASSOC);
        $statementStore = $exists['amount'] > 0 ? $this->statementKeyUpdate : $this->statementKeyInsert;
        $statementStore->bindValue(1, $value);
        $statementStore->bindValue(2, $prefixedKey);
        $statementStore->execute();
    }

    public function getMeasurements($prefix, array $keys) {
        $prefixedKeys = array_map(function($key) use ($prefix) {
            return $prefix.':'.$key;
        }, $keys);
        $queryBuilder = $this->connection->createQueryBuilder();
        $queryBuilder
            ->select('`key`', '`value`')
            ->from('`'.$this->table.'`')
            ->where('`key` IN (?)')
            ->setParameter(1, $prefixedKeys, Connection::PARAM_STR_ARRAY)
        ;
        $measurements = [];
        foreach ($keys as $key) {
            $measurements[$key] = 'Nan';
        }
        $rows = $queryBuilder->execute()->fetchAll(\PDO::FETCH_ASSOC);
        foreach ($rows as $row) {
            $unprefixedKey                = substr($row['key'], strlen($prefix) + 1);
            $measurements[$unprefixedKey] = (float)$row['value'];
        }
        return $measurements;
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHPProm package.
5			*
6			* (c) Philip Lehmann-Böhm <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace PHPProm\Storage;
13
14			use \Doctrine\DBAL\Connection;
15
16			class DBALStorage extends AbstractStorage {
17
18			protected $connection;
19
20			protected $table;
21
22			protected $statementKeyExists;
23
24			protected $statementKeyInsert;
25
26			protected $statementKeyUpdate;
27
28			protected function buildStatements() {
29			$queryBuilder = $this->connection->createQueryBuilder()
			0 ignored issues – show Coding Style introduced 2016-11-06 00:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30			->select('COUNT(`key`) AS amount')
31			->from('`'.$this->table.'`')
32			->where('`key` = ?')
33			;
34			$this->statementKeyExists = $this->connection->prepare($queryBuilder->getSQL());
35
36			$queryBuilder = $this->connection->createQueryBuilder()
			0 ignored issues – show Coding Style introduced 2016-11-06 00:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37			->insert('`'.$this->table.'`')
38			->setValue('`value`', '?')
39			->setValue('`key`', '?')
40			;
41			$this->statementKeyInsert = $this->connection->prepare($queryBuilder->getSQL());
42
43			$queryBuilder = $this->connection->createQueryBuilder()
			0 ignored issues – show Coding Style introduced 2016-11-06 00:43 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
44			->update('`'.$this->table.'`')
45			->set('`value`', '?')
46			->where('`key` = ?')
47			;
48			$this->statementKeyUpdate = $this->connection->prepare($queryBuilder->getSQL());
49			}
50
51			public function __construct(Connection $connection, $table = 'phpprom') {
52			$this->connection = $connection;
53			$this->table = $table;
54			$this->buildStatements();
55			}
56
57			public function storeMeasurement($prefix, $key, $value) {
58			$prefixedKey = $prefix.':'.$key;
59			$this->statementKeyExists->bindValue(1, $prefixedKey);
60			$this->statementKeyExists->execute();
61			$exists = $this->statementKeyExists->fetch(\PDO::FETCH_ASSOC);
62			$statementStore = $exists['amount'] > 0 ? $this->statementKeyUpdate : $this->statementKeyInsert;
63			$statementStore->bindValue(1, $value);
64			$statementStore->bindValue(2, $prefixedKey);
65			$statementStore->execute();
66			}
67
68			public function getMeasurements($prefix, array $keys) {
69			$prefixedKeys = array_map(function($key) use ($prefix) {
70			return $prefix.':'.$key;
71			}, $keys);
72			$queryBuilder = $this->connection->createQueryBuilder();
73			$queryBuilder
74			->select('`key`', '`value`')
75			->from('`'.$this->table.'`')
76			->where('`key` IN (?)')
77			->setParameter(1, $prefixedKeys, Connection::PARAM_STR_ARRAY)
78			;
79			$measurements = [];
80			foreach ($keys as $key) {
81			$measurements[$key] = 'Nan';
82			}
83			$rows = $queryBuilder->execute()->fetchAll(\PDO::FETCH_ASSOC);
84			foreach ($rows as $row) {
85			$unprefixedKey = substr($row['key'], strlen($prefix) + 1);
86			$measurements[$unprefixedKey] = (float)$row['value'];
87			}
88			return $measurements;
89			}
90			}
91

philiplb / PHPProm

Push — master ( 85f910...e74426 )

DBALStorage A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like