Complex classes like ServiceProvider often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ServiceProvider, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 29 | class ServiceProvider implements ServiceProviderInterface, BootableProviderInterface { |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Holds the {@see AbstractData} instances. |
||
| 33 | */ |
||
| 34 | protected $datas; |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Initializes needed but yet missing service providers. |
||
| 38 | * |
||
| 39 | * @param Container $app |
||
| 40 | * the application container |
||
| 41 | */ |
||
| 42 | protected function initMissingServiceProviders(Container $app) { |
||
| 43 | |||
| 44 | if (!$app->offsetExists('translator')) { |
||
| 45 | $app->register(new LocaleServiceProvider()); |
||
| 46 | $app->register(new TranslationServiceProvider(), [ |
||
| 47 | 'locale_fallbacks' => ['en'], |
||
| 48 | ]); |
||
| 49 | } |
||
| 50 | |||
| 51 | if (!$app->offsetExists('session')) { |
||
| 52 | $app->register(new SessionServiceProvider()); |
||
| 53 | } |
||
| 54 | |||
| 55 | if (!$app->offsetExists('twig')) { |
||
| 56 | $app->register(new TwigServiceProvider()); |
||
| 57 | } |
||
| 58 | $app['twig.loader.filesystem']->addPath(__DIR__.'/../views/', 'crud'); |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Initializes the available locales. |
||
| 63 | * |
||
| 64 | * @param Container $app |
||
| 65 | * the application container |
||
| 66 | * |
||
| 67 | * @return array |
||
| 68 | * the available locales |
||
| 69 | */ |
||
| 70 | protected function initLocales(Container $app) { |
||
| 71 | $locales = $this->getLocales(); |
||
| 72 | $localeDir = __DIR__.'/../locales'; |
||
| 73 | $app['translator']->addLoader('yaml', new YamlFileLoader()); |
||
| 74 | foreach ($locales as $locale) { |
||
| 75 | $app['translator']->addResource('yaml', $localeDir.'/'.$locale.'.yml', $locale); |
||
| 76 | } |
||
| 77 | return $locales; |
||
| 78 | } |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Initializes the children of the data entries. |
||
| 82 | */ |
||
| 83 | protected function initChildren() { |
||
| 84 | foreach ($this->datas as $name => $data) { |
||
| 85 | $fields = $data->getDefinition()->getFieldNames(); |
||
| 86 | foreach ($fields as $field) { |
||
| 87 | if ($data->getDefinition()->getType($field) == 'reference') { |
||
| 88 | $this->datas[$data->getDefinition()->getSubTypeField($field, 'reference', 'entity')]->getDefinition()->addChild($data->getDefinition()->getTable(), $field, $name); |
||
| 89 | } |
||
| 90 | } |
||
| 91 | } |
||
| 92 | } |
||
| 93 | |||
| 94 | /** |
||
| 95 | * Gets a map with localized entity labels from the CRUD YML. |
||
| 96 | * |
||
| 97 | * @param array $locales |
||
| 98 | * the available locales |
||
| 99 | * @param array $crud |
||
| 100 | * the CRUD entity map |
||
| 101 | * |
||
| 102 | * @return array |
||
| 103 | * the map with localized entity labels |
||
| 104 | */ |
||
| 105 | protected function getLocaleLabels($locales, $crud) { |
||
| 106 | $localeLabels = []; |
||
| 107 | foreach ($locales as $locale) { |
||
| 108 | if (array_key_exists('label_'.$locale, $crud)) { |
||
| 109 | $localeLabels[$locale] = $crud['label_'.$locale]; |
||
| 110 | } |
||
| 111 | } |
||
| 112 | return $localeLabels; |
||
| 113 | } |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Configures the EntityDefinition according to the given |
||
| 117 | * CRUD entity map. |
||
| 118 | * |
||
| 119 | * @param EntityDefinition $definition |
||
| 120 | * the definition to configure |
||
| 121 | * @param array $crud |
||
| 122 | * the CRUD entity map |
||
| 123 | */ |
||
| 124 | protected function configureDefinition(EntityDefinition $definition, array $crud) { |
||
| 125 | $toConfigure = [ |
||
| 126 | 'deleteCascade', |
||
| 127 | 'listFields', |
||
| 128 | 'filter', |
||
| 129 | 'childrenLabelFields', |
||
| 130 | 'pageSize', |
||
| 131 | 'initialSortField', |
||
| 132 | 'initialSortAscending', |
||
| 133 | 'navBarGroup' |
||
| 134 | ]; |
||
| 135 | foreach ($toConfigure as $field) { |
||
| 136 | if (array_key_exists($field, $crud)) { |
||
| 137 | $function = 'set'.ucfirst($field); |
||
| 138 | $definition->$function($crud[$field]); |
||
| 139 | } |
||
| 140 | } |
||
| 141 | } |
||
| 142 | |||
| 143 | /** |
||
| 144 | * Creates and setups an EntityDefinition instance. |
||
| 145 | * |
||
| 146 | * @param Container $app |
||
| 147 | * the application container |
||
| 148 | * @param array $locales |
||
| 149 | * the available locales |
||
| 150 | * @param array $crud |
||
| 151 | * the parsed YAML of a CRUD entity |
||
| 152 | * @param string $name |
||
| 153 | * the name of the entity |
||
| 154 | * |
||
| 155 | * @return EntityDefinition |
||
| 156 | * the EntityDefinition good to go |
||
| 157 | */ |
||
| 158 | protected function createDefinition(Container $app, array $locales, array $crud, $name) { |
||
| 180 | |||
| 181 | /** |
||
| 182 | * Validates the parsed entity definition. |
||
| 183 | * |
||
| 184 | * @param Container $app |
||
| 185 | * the application container |
||
| 186 | * @param array $entityDefinition |
||
| 187 | * the entity definition to validate |
||
| 188 | */ |
||
| 189 | protected function validateEntityDefinition(Container $app, array $entityDefinition) { |
||
| 198 | |||
| 199 | /** |
||
| 200 | * Initializes the instance. |
||
| 201 | * |
||
| 202 | * @param DataFactoryInterface $dataFactory |
||
| 203 | * the factory to create the concrete AbstractData instances |
||
| 204 | * @param string $crudFile |
||
| 205 | * the CRUD YAML file to parse |
||
| 206 | * @param string|null $crudFileCachingDirectory |
||
| 207 | * the writable directory to store the CRUD YAML file cache |
||
| 208 | * @param FileProcessorInterface $fileProcessor |
||
| 209 | * the file processor used for file fields |
||
| 210 | * @param Container $app |
||
| 211 | * the application container |
||
| 212 | */ |
||
| 213 | public function init(DataFactoryInterface $dataFactory, $crudFile, $crudFileCachingDirectory, FileProcessorInterface $fileProcessor, Container $app) { |
||
| 230 | |||
| 231 | /** |
||
| 232 | * Implements ServiceProviderInterface::register() registering $app['crud']. |
||
| 233 | * $app['crud'] contains an instance of the ServiceProvider afterwards. |
||
| 234 | * |
||
| 235 | * @param Container $app |
||
| 236 | * the Container instance of the Silex application |
||
| 237 | */ |
||
| 238 | public function register(Container $app) { |
||
| 247 | |||
| 248 | /** |
||
| 249 | * Initializes the crud service right after boot. |
||
| 250 | * |
||
| 251 | * @param Application $app |
||
| 252 | * the Container instance of the Silex application |
||
| 253 | */ |
||
| 254 | public function boot(Application $app) { |
||
| 259 | |||
| 260 | /** |
||
| 261 | * Getter for the {@see AbstractData} instances. |
||
| 262 | * |
||
| 263 | * @param string $name |
||
| 264 | * the entity name of the desired Data instance |
||
| 265 | * |
||
| 266 | * @return AbstractData |
||
| 267 | * the AbstractData instance or null on invalid name |
||
| 268 | */ |
||
| 269 | public function getData($name) { |
||
| 275 | |||
| 276 | /** |
||
| 277 | * Getter for all available entity names. |
||
| 278 | * |
||
| 279 | * @return string[] |
||
| 280 | * a list of all available entity names |
||
| 281 | */ |
||
| 282 | public function getEntities() { |
||
| 285 | |||
| 286 | /** |
||
| 287 | * Getter for the entities for the navigation bar. |
||
| 288 | * |
||
| 289 | * @return string[] |
||
|
|
|||
| 290 | * a list of all available entity names with their group |
||
| 291 | */ |
||
| 292 | public function getEntitiesNavBar() { |
||
| 303 | |||
| 304 | /** |
||
| 305 | * Determines the Twig template to use for the given parameters depending on |
||
| 306 | * the existance of certain keys in the Container $app in this order: |
||
| 307 | * |
||
| 308 | * crud.$section.$action.$entity |
||
| 309 | * crud.$section.$action |
||
| 310 | * crud.$section |
||
| 311 | * |
||
| 312 | * If nothing exists, this string is returned: "@crud/<action>.twig" |
||
| 313 | * |
||
| 314 | * @param Container $app |
||
| 315 | * the Silex application |
||
| 316 | * @param string $section |
||
| 317 | * the section of the template, either "layout" or "template" |
||
| 318 | * @param string $action |
||
| 319 | * the current calling action like "create" or "show" |
||
| 320 | * @param string $entity |
||
| 321 | * the current calling entity |
||
| 322 | * |
||
| 323 | * @return string |
||
| 324 | * the best fitting template |
||
| 325 | */ |
||
| 326 | public function getTemplate(Container $app, $section, $action, $entity) { |
||
| 344 | |||
| 345 | /** |
||
| 346 | * Sets the locale to be used. |
||
| 347 | * |
||
| 348 | * @param string $locale |
||
| 349 | * the locale to be used. |
||
| 350 | */ |
||
| 351 | public function setLocale($locale) { |
||
| 356 | |||
| 357 | /** |
||
| 358 | * Gets the available locales. |
||
| 359 | * |
||
| 360 | * @return array |
||
| 361 | * the available locales |
||
| 362 | */ |
||
| 363 | public function getLocales() { |
||
| 380 | |||
| 381 | } |
||
| 382 |
This check compares the return type specified in the
@returnannotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.