Monitor\Notification\Notifier

Complexity

Total Complexity

11

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	setNotificationData()	0	4	1
A	getNotificationById()	0	5	1
A	parseNotification()	0	4	1
A	prepareNotification()	0	9	1
A	hasNotificationDelayExpired()	0	13	3
A	triggerHasBeenFired()	0	6	1
A	notifyServices()	0	6	2

<?php
namespace Monitor\Notification;

use Monitor\Model\Notification;
use Monitor\Model\Trigger;
use Monitor\Service\NotificationLog as NotificationLogService;
use Doctrine\ORM\EntityRepository;

class Notifier extends Observable
{

    /**
     * @var \Monitor\Notification\Parser
     */
    private $notificationParser;
    /**
     * @var integer
     */
    private $notificationDelayInHours;
    /**
     * @var \Monitor\Service\NotificationLog
     */
    private $notificationLogService;
    /**
     * Notification repository
     * @var \Doctrine\ORM\EntityRepository
     */
    private $repository;
    /**
     * @var array
     */
    private $notificationData;

    public function __construct(
        Parser $notificationParser,
        $notificationDelay,
        NotificationLogService $notificationLogService,
        EntityRepository $repository
    ) {
    
        $this->notificationParser = $notificationParser;
        $this->notificationDelayInHours = $notificationDelay;
        $this->notificationLogService = $notificationLogService;
        $this->repository = $repository;
    }

    /**
     * Add notification data, we will use them in notification services
     *
     * @param array $data
     */
    public function setNotificationData(array $data)
    {
        $this->notificationData = $data;
    }
    /**
     * Get Notification by id
     *
     * @param int $id
     * @return \Monitor\Model\Notification $notification
     */
    private function getNotificationById($id)
    {
        $notification = $this->repository->find($id);
        return $notification;
    }

    /**
     * Parse notification message
     *
     * @param \Monitor\Model\Notification $notification
     * @param array $data
     */
    private function parseNotification(Notification $notification, $data)
    {
        $this->notificationParser->parse($notification, $data);
    }

    /**
     * Prepare notification
     *
     * @access private
     * @param  Trigger $trigger
     * @param  array   $serverData
     * @return \Monitor\Notification\Notification
     */
    private function prepareNotification(Trigger $trigger, array $serverData)
    {
        $notificationId = $trigger->getNotificationId();
        $notification = $this->getNotificationById($notificationId);
        //merge server data and trigger properties so we can use them in fulfilling notification message
        $data = array_merge($serverData, $trigger->toArray());
        $this->parseNotification($notification, $data);

It seems like $notification defined by $this->getNotificationById($notificationId) on line 90 can be null; however, Monitor\Notification\Notifier::parseNotification() does not accept null, maybe add an additional type check?

        return $notification;
    }

    /**
     * Check if same type of notification for concret server has been sent already
     *
     * @access private
     * @param  int $triggerId
     * @param  int $serverId
     * @return boolean
     */
    public function hasNotificationDelayExpired($triggerId, $serverId, $msDelay)
    {
        $queryResult = $this->notificationLogService->getLastForTrigger(
            $triggerId,
            $serverId
        );
        if ( ! $queryResult) {
            return true;
        }
        $timeOfLastFiredUpTrigger = $queryResult[0]['created'];
        $timeDiff = $timeOfLastFiredUpTrigger - time();
        return ($this->notificationDelayInHours * $msDelay + $timeDiff >= 0) ? false : true;
    }
    /**
     *
     *
     * @param  Trigger $trigger
     * @param  array   $serverData
     * @return \Monitor\Notification\Notification
     */
    public function triggerHasBeenFired(Trigger $trigger, array $serverData)
    {
        $notification = $this->prepareNotification($trigger, $serverData);
        $this->notifyServices($notification);

It seems like $notification defined by $this->prepareNotification($trigger, $serverData) on line 127 can be null; however, Monitor\Notification\Notifier::notifyServices() does not accept null, maybe add an additional type check?

        return $notification;
    }

    /**
     * Send notification to notification service
     *
     * @access public
     * @param  Notification $notification
     * @return
     */
    public function notifyServices(Notification $notification)
    {
        foreach ($this->observers as $observer) {
            $observer->sendNotification($notification, $this->notificationData);
        }
    }
}