phanan / koel

app/Repositories/AbstractRepository.php

<?php

namespace App\Repositories;

use Exception;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;

abstract class AbstractRepository implements RepositoryInterface
{
    /** @var Model */
    protected $model;

    /** @var Guard */
    protected $auth;

    abstract public function getModelClass(): string;

    public function __construct()
    {
        $this->model = app($this->getModelClass());

It seems like app($this->getModelClass()) can also be of type Illuminate\Contracts\Foundation\Application. However, the property $model is declared as type Illuminate\Database\Eloquent\Model. Maybe add an additional type check?

        // This instantiation may fail during a console command if e.g. APP_KEY is empty,
        // rendering the whole installation failing.
        try {
            $this->auth = app(Guard::class);
        } catch (Exception $e) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    public function getOneById($id): ?Model
    {
        return $this->model->find($id);
    }

    public function getByIds(array $ids): Collection
    {
        return $this->model->whereIn($this->model->getKeyName(), $ids)->get();
    }

    public function getAll(): Collection
    {
        return $this->model->all();
    }
}