SongController::play() - Code Metrics - Inspection of "Gcp" - phanan/koel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#590)

unknown

created 2017-07-15 14:10 UTC

SongController::play() D

↳ Parent: SongController

Complexity

Conditions	9
Paths	10

Size

Total Lines	39
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	39
c	0
b	0
f	0
rs	4.909
cc	9
eloc	25
nc	10
nop	4

<?php

namespace App\Http\Controllers\API;

use App\Http\Requests\API\SongUpdateRequest;
use App\Models\Song;
use App\Services\Streamers\PHPStreamer;
use App\Services\Streamers\S3Streamer;
use App\Services\Streamers\TranscodingStreamer;
use App\Services\Streamers\XAccelRedirectStreamer;
use App\Services\Streamers\XSendFileStreamer;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use App\Services\Streamers\GCPStreamer;

class SongController extends Controller
{
    /**
     * Play/stream a song.
     *
     * @link https://github.com/phanan/koel/wiki#streaming-music
     *
     * @param Request   $request
     * @param Song      $song      The song to stream.
     * @param null|bool $transcode Whether to force transcoding the song.
     *                             If this is omitted, by default Koel will transcode FLAC.
     * @param null|int  $bitRate   The target bit rate to transcode, defaults to OUTPUT_BIT_RATE.
     *                             Only taken into account if $transcode is truthy.
     *
     * @return RedirectResponse|Redirector
     */
    public function play(Request $request, Song $song, $transcode = null, $bitRate = null)
    {
        if ($song->s3_params) {
            return (new S3Streamer($song))->stream();
        }

        if ($song->gcp_params) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return (new GCPStreamer($song))->stream();
        }
		
        // If `transcode` parameter isn't passed, the default is to only transcode FLAC.
        if ($transcode === null && ends_with(mime_content_type($song->path), 'flac')) {
            $transcode = true;
        }

        $streamer = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($transcode) {
            $streamer = new TranscodingStreamer(
                $song,
                $bitRate ?: config('koel.streaming.bitrate'),
                floatval($request->time)
            );
        } else {
            switch (config('koel.streaming.method')) {
                case 'x-sendfile':
                    $streamer = new XSendFileStreamer($song);
                    break;
                case 'x-accel-redirect':
                    $streamer = new XAccelRedirectStreamer($song);
                    break;
                default:
                    $streamer = new PHPStreamer($song);
                    break;
            }
        }

        $streamer->stream();
    }

    /**
     * Get extra information about a song via Last.fm.
     *
     * @param Song $song
     *
     * @return JsonResponse
     */
    public function show(Song $song)
    {
        return response()->json([
            'lyrics' => $song->lyrics,
            'album_info' => $song->album->getInfo(),
            'artist_info' => $song->artist->getInfo(),
            'youtube' => $song->getRelatedYouTubeVideos(),
        ]);
    }

    /**
     * Update songs info.
     *
     * @param SongUpdateRequest $request
     *
     * @return JsonResponse
     */
    public function update(SongUpdateRequest $request)
    {
        return response()->json(Song::updateInfo($request->songs, $request->data));
    }
}


1			<?php
2
3			namespace App\Http\Controllers\API;
4
5			use App\Http\Requests\API\SongUpdateRequest;
6			use App\Models\Song;
7			use App\Services\Streamers\PHPStreamer;
8			use App\Services\Streamers\S3Streamer;
9			use App\Services\Streamers\TranscodingStreamer;
10			use App\Services\Streamers\XAccelRedirectStreamer;
11			use App\Services\Streamers\XSendFileStreamer;
12			use Illuminate\Http\JsonResponse;
13			use Illuminate\Http\RedirectResponse;
14			use Illuminate\Http\Request;
15			use Illuminate\Routing\Redirector;
16			use App\Services\Streamers\GCPStreamer;
17
18			class SongController extends Controller
19			{
20			/**
21			* Play/stream a song.
22			*
23			* @link https://github.com/phanan/koel/wiki#streaming-music
24			*
25			* @param Request $request
26			* @param Song $song The song to stream.
27			* @param null\|bool $transcode Whether to force transcoding the song.
28			* If this is omitted, by default Koel will transcode FLAC.
29			* @param null\|int $bitRate The target bit rate to transcode, defaults to OUTPUT_BIT_RATE.
30			* Only taken into account if $transcode is truthy.
31			*
32			* @return RedirectResponse\|Redirector
33			*/
34			public function play(Request $request, Song $song, $transcode = null, $bitRate = null)
35			{
36			if ($song->s3_params) {
37			return (new S3Streamer($song))->stream();
38			}
39
40			if ($song->gcp_params) {
			0 ignored issues – show Documentation introduced 2017-07-15 14:21 UTC by Report Bug Copy Issue Report The property `gcp_params` does not exist on `object<App\Models\Song>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			return (new GCPStreamer($song))->stream();
42			}
43
44			// If `transcode` parameter isn't passed, the default is to only transcode FLAC.
45			if ($transcode === null && ends_with(mime_content_type($song->path), 'flac')) {
46			$transcode = true;
47			}
48
49			$streamer = null;
			0 ignored issues – show Unused Code introduced 2017-06-03 00:27 UTC by Report Bug Copy Issue Report `$streamer` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50
51			if ($transcode) {
52			$streamer = new TranscodingStreamer(
53			$song,
54			$bitRate ?: config('koel.streaming.bitrate'),
55			floatval($request->time)
56			);
57			} else {
58			switch (config('koel.streaming.method')) {
59			case 'x-sendfile':
60			$streamer = new XSendFileStreamer($song);
61			break;
62			case 'x-accel-redirect':
63			$streamer = new XAccelRedirectStreamer($song);
64			break;
65			default:
66			$streamer = new PHPStreamer($song);
67			break;
68			}
69			}
70
71			$streamer->stream();
72			}
73
74			/**
75			* Get extra information about a song via Last.fm.
76			*
77			* @param Song $song
78			*
79			* @return JsonResponse
80			*/
81			public function show(Song $song)
82			{
83			return response()->json([
84			'lyrics' => $song->lyrics,
85			'album_info' => $song->album->getInfo(),
86			'artist_info' => $song->artist->getInfo(),
87			'youtube' => $song->getRelatedYouTubeVideos(),
88			]);
89			}
90
91			/**
92			* Update songs info.
93			*
94			* @param SongUpdateRequest $request
95			*
96			* @return JsonResponse
97			*/
98			public function update(SongUpdateRequest $request)
99			{
100			return response()->json(Song::updateInfo($request->songs, $request->data));
101			}
102			}
103

phanan / koel

Pull Request — master (#590)

SongController::play() D

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like