Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | View Code Duplication | class SongController extends Controller |
|
|
|||
16 | { |
||
17 | /** |
||
18 | * Store a new song or update an existing one with data from AWS. |
||
19 | * |
||
20 | * @param PutSongRequest $request |
||
21 | * |
||
22 | * @return JsonResponse |
||
23 | */ |
||
24 | public function put(PutSongRequest $request) |
||
51 | |||
52 | /** |
||
53 | * Remove a song whose info matches with data sent from AWS. |
||
54 | * |
||
55 | * @param RemoveSongRequest $request |
||
56 | * |
||
57 | * @throws Exception |
||
58 | * |
||
59 | * * @return JsonResponse |
||
60 | */ |
||
61 | public function remove(RemoveSongRequest $request) |
||
69 | } |
||
70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.