ChangePasswordCommand::validatePasswords() - Code Metrics - Inspection of "feat: Allow changing admin password via console" - phanan/koel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cfcf27...c41e28 )

by Phan

created 2019-10-23 13:33 UTC

ChangePasswordCommand::validatePasswords() A

↳ Parent: ChangePasswordCommand

Complexity

Conditions	4
Paths	3

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	15
ccs	0
cts	8
cp	0
rs	10
cc	4
nc	3
nop	2
crap	20

<?php

namespace App\Console\Commands\Admin;

use App\Models\User;
use Illuminate\Console\Command;
use Illuminate\Contracts\Hashing\Hasher as Hash;

class ChangePasswordCommand extends Command
{
    protected $name = 'koel:admin:change-password';
    protected $description = "Change the default admin's password";

    private $hash;

    public function __construct(Hash $hash)
    {
        parent::__construct();
        $this->hash = $hash;
    }

    public function handle(): void
    {
        /** @var User $user */
        $user = User::where('is_admin', true)->first();

        if (!$user) {

            $this->error('An admin account cannot be found. Have you set up Koel yet?');

            return;
        }

        $this->comment("Changing the default admin's password (ID: {$user->id}, email: {$user->email})");

        do {
            $password = $this->secret('New password');
            $confirmedPassword = $this->secret('Again, just to be sure');
        } while (!$this->validatePasswords($password, $confirmedPassword));

        $user->password = $this->hash->make($password);
        $user->save();

        $this->comment('New password saved, enjoy! 👌');
    }

    private function validatePasswords(?string $password, ?string $confirmedPassword): bool
    {
        if (!$password || !$confirmedPassword) {
            $this->error('Passwords cannot be empty. You know that.');

            return false;
        }

        if (strcmp($password, $confirmedPassword) !== 0) {
            $this->error('The passwords do not match. Try again maybe?');

            return false;
        }

        return true;
    }
}


1		<?php
2
3		namespace App\Console\Commands\Admin;
4
5		use App\Models\User;
6		use Illuminate\Console\Command;
7		use Illuminate\Contracts\Hashing\Hasher as Hash;
8
9		class ChangePasswordCommand extends Command
10		{
11		protected $name = 'koel:admin:change-password';
12		protected $description = "Change the default admin's password";
13
14		private $hash;
15
16	132	public function __construct(Hash $hash)
17		{
18	132	parent::__construct();
19	132	$this->hash = $hash;
20	132	}
21
22		public function handle(): void
23		{
24		/** @var User $user */
25		$user = User::where('is_admin', true)->first();
26
27		if (!$user) {
		0 ignored issues – show introduced 2019-10-23 13:47 UTC by Report Bug Copy Issue Report `$user` is of type `App\Models\User`, thus it always evaluated to `true`. Loading history...
28		$this->error('An admin account cannot be found. Have you set up Koel yet?');
29
30		return;
31		}
32
33		$this->comment("Changing the default admin's password (ID: {$user->id}, email: {$user->email})");
34
35		do {
36		$password = $this->secret('New password');
37		$confirmedPassword = $this->secret('Again, just to be sure');
38		} while (!$this->validatePasswords($password, $confirmedPassword));
39
40		$user->password = $this->hash->make($password);
41		$user->save();
42
43		$this->comment('New password saved, enjoy! 👌');
44		}
45
46		private function validatePasswords(?string $password, ?string $confirmedPassword): bool
47		{
48		if (!$password \|\| !$confirmedPassword) {
49		$this->error('Passwords cannot be empty. You know that.');
50
51		return false;
52		}
53
54		if (strcmp($password, $confirmedPassword) !== 0) {
55		$this->error('The passwords do not match. Try again maybe?');
56
57		return false;
58		}
59
60		return true;
61		}
62		}
63

phanan / koel

Push — master ( cfcf27...c41e28 )

ChangePasswordCommand::validatePasswords() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like