Test Setup Failed
Push — master ( 7ec5cf...f827c6 )
by Phan
04:13
created

ArtistInfoController::show()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 4
rs 10
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace App\Http\Controllers\API;
4
5
use App\Http\Controllers\Controller;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, App\Http\Controllers\API\Controller.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use App\Models\Artist;
7
use Illuminate\Http\JsonResponse;
8
9
class ArtistInfoController extends Controller
10
{
11
    /**
12
     * Get extra information about an artist via Last.fm.
13
     *
14
     * @param Artist $artist
15
     *
16
     * @return JsonResponse
17
     */
18
    public function show(Artist $artist)
19
    {
20
        return response()->json($artist->getInfo());
0 ignored issues
show
Security Bug introduced by
It seems like $artist->getInfo() targeting App\Models\Artist::getInfo() can also be of type false; however, Illuminate\Contracts\Rou...ResponseFactory::json() does only seem to accept string|array, did you maybe forget to handle an error condition?
Loading history...
21
    }
22
}
23