PHPStreamer::stream() - Code Metrics - Inspection of "Apply fixes from StyleCI (#796)" - phanan/koel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Branch — master (86cd0f)

by Phan

created 2018-08-30 02:56 UTC

PHPStreamer::stream() B

↳ Parent: PHPStreamer

Complexity

Conditions	6
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	0
cts	10
cp	0
rs	8.9457
c	0
b	0
f	0
cc	6
nc	16
nop	0
crap	42

<?php

namespace App\Services\Streamers;

use DaveRandom\Resume\FileResource;
use DaveRandom\Resume\InvalidRangeHeaderException;
use DaveRandom\Resume\NonExistentFileException;
use DaveRandom\Resume\RangeSet;
use DaveRandom\Resume\Resource;
use DaveRandom\Resume\ResourceServlet;
use DaveRandom\Resume\SendFileFailureException;
use DaveRandom\Resume\UnreadableFileException;
use DaveRandom\Resume\UnsatisfiableRangeException;
use function DaveRandom\Resume\get_request_header;

class PHPStreamer extends Streamer implements DirectStreamerInterface
{
    public function stream()
    {
        try {
            $rangeSet = RangeSet::createFromHeader(get_request_header('Range'));
            /** @var resource $resource */
            $resource = new FileResource($this->song->path, 'application/octet-stream');
            (new ResourceServlet($resource))->sendResource($rangeSet);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (InvalidRangeHeaderException $e) {
            abort(400);
        } catch (UnsatisfiableRangeException $e) {
            abort(416);
        } catch (NonExistentFileException $e) {
            abort(404);
        } catch (UnreadableFileException $e) {
            abort(500);
        } catch (SendFileFailureException $e) {
            abort_unless(headers_sent(), 500);
            echo "An error occurred while attempting to send the requested resource: {$e->getMessage()}";
        }

        exit;
    }
}


1			<?php
2
3			namespace App\Services\Streamers;
4
5			use DaveRandom\Resume\FileResource;
6			use DaveRandom\Resume\InvalidRangeHeaderException;
7			use DaveRandom\Resume\NonExistentFileException;
8			use DaveRandom\Resume\RangeSet;
9			use DaveRandom\Resume\Resource;
10			use DaveRandom\Resume\ResourceServlet;
11			use DaveRandom\Resume\SendFileFailureException;
12			use DaveRandom\Resume\UnreadableFileException;
13			use DaveRandom\Resume\UnsatisfiableRangeException;
14			use function DaveRandom\Resume\get_request_header;
15
16			class PHPStreamer extends Streamer implements DirectStreamerInterface
17			{
18			public function stream()
19			{
20			try {
21			$rangeSet = RangeSet::createFromHeader(get_request_header('Range'));
22			/** @var resource $resource */
23			$resource = new FileResource($this->song->path, 'application/octet-stream');
24			(new ResourceServlet($resource))->sendResource($rangeSet);
			0 ignored issues – show Documentation introduced 2018-08-30 03:01 UTC by Report Bug Copy Issue Report `$resource` is of type `resource`, but the function expects a `object<DaveRandom\Resume\Resource>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			} catch (InvalidRangeHeaderException $e) {
26			abort(400);
27			} catch (UnsatisfiableRangeException $e) {
28			abort(416);
29			} catch (NonExistentFileException $e) {
30			abort(404);
31			} catch (UnreadableFileException $e) {
32			abort(500);
33			} catch (SendFileFailureException $e) {
34			abort_unless(headers_sent(), 500);
35			echo "An error occurred while attempting to send the requested resource: {$e->getMessage()}";
36			}
37
38			exit;
39			}
40			}
41

phanan / koel

Branch — master (86cd0f)

PHPStreamer::stream() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like