ApplicationInformationService::getLatestVersionNumber() - Code Metrics - Inspection of "Fix parameter type" - phanan/koel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Branch — master (4b8153)

by Phan

created 2018-09-04 06:13 UTC

getLatestVersionNumber() A

↳ Parent: ApplicationInformationService

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
cc	2
nc	1
nop	0

<?php

namespace App\Services;

use App\Application;
use Exception;
use GuzzleHttp\Client;
use Illuminate\Contracts\Cache\Repository as Cache;
use Illuminate\Log\Logger;

class ApplicationInformationService
{
    private const CACHE_KEY = 'latestKoelVersion';

    private $client;
    private $cache;
    private $logger;

    public function __construct(Client $client, Cache $cache, Logger $logger)
    {
        $this->client = $client;
        $this->cache = $cache;
        $this->logger = $logger;
    }

    /**
     * Get the latest version number of Koel from GitHub.
     */
    public function getLatestVersionNumber(): string
    {
        return $this->cache->remember(self::CACHE_KEY, 1 * 24 * 60, function (): string {
            try {
                return json_decode(
                    $this->client->get('https://api.github.com/repos/phanan/koel/tags')->getBody()
                )[0]->name;
            } catch (Exception $e) {
                $this->logger->error($e);

                return Application::KOEL_VERSION;
            }
        });
    }
}


1			<?php
2
3			namespace App\Services;
4
5			use App\Application;
6			use Exception;
7			use GuzzleHttp\Client;
8			use Illuminate\Contracts\Cache\Repository as Cache;
9			use Illuminate\Log\Logger;
10
11			class ApplicationInformationService
12			{
13			private const CACHE_KEY = 'latestKoelVersion';
14
15			private $client;
16			private $cache;
17			private $logger;
18
19			public function __construct(Client $client, Cache $cache, Logger $logger)
20			{
21			$this->client = $client;
22			$this->cache = $cache;
23			$this->logger = $logger;
24			}
25
26			/**
27			* Get the latest version number of Koel from GitHub.
28			*/
29			public function getLatestVersionNumber(): string
30			{
31			return $this->cache->remember(self::CACHE_KEY, 1 * 24 * 60, function (): string {
32			try {
33			return json_decode(
34			$this->client->get('https://api.github.com/repos/phanan/koel/tags')->getBody()
35			)[0]->name;
36			} catch (Exception $e) {
37			$this->logger->error($e);
38
39			return Application::KOEL_VERSION;
40			}
41			});
42			}
43			}
44

phanan / koel

Branch — master (4b8153)

getLatestVersionNumber() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like