App\Http\Controllers\API\ObjectStorage\S3\SongController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Test Coverage

Coverage

96.67%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	put()	0	28	4
A	remove()	0	9	1
A	__construct()	0	8	1

<?php

namespace App\Http\Controllers\API\ObjectStorage\S3;

use App\Events\LibraryChanged;
use App\Http\Requests\API\ObjectStorage\S3\PutSongRequest;
use App\Http\Requests\API\ObjectStorage\S3\RemoveSongRequest;
use App\Models\Album;
use App\Models\Artist;
use App\Models\Song;
use App\Repositories\SongRepository;
use App\Services\HelperService;
use App\Services\MediaMetadataService;
use Exception;
use Illuminate\Http\JsonResponse;

/**
 * @group AWS integration
 *
 * These routes are meant for Amazon Web Services (AWS) integration with Koel. For more information, visit
 * [koel-aws](https://github.com/koel/koel-aws).
 */
class SongController extends Controller
{
    private $mediaMetadataService;
    private $songRepository;
    private $helperService;

    public function __construct(
        MediaMetadataService $mediaMetadataService,
        HelperService $helperService,
        SongRepository $songRepository
    ) {
        $this->mediaMetadataService = $mediaMetadataService;
        $this->songRepository = $songRepository;
        $this->helperService = $helperService;
    }

    /**
     * Store a song.
     *
     * Create a new song or update an existing one with data sent from AWS.
     *
     * @return JsonResponse
     */
    public function put(PutSongRequest $request)
    {
        $path = "s3://{$request->bucket}/{$request->key}";

        $tags = $request->tags;
        $artist = Artist::get(array_get($tags, 'artist'));

It seems like array_get($tags, 'artist') can also be of type null and string[]; however, parameter $name of App\Models\Artist::get() does only seem to accept string, maybe add an additional type check?

        $compilation = (bool) trim(array_get($tags, 'albumartist'));

It seems like array_get($tags, 'albumartist') can also be of type string[]; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

        $album = Album::get($artist, array_get($tags, 'album'), $compilation);

It seems like array_get($tags, 'album') can also be of type null and string[]; however, parameter $name of App\Models\Album::get() does only seem to accept string, maybe add an additional type check?

        if ($cover = array_get($tags, 'cover')) {
            $this->mediaMetadataService->writeAlbumCover($album, base64_decode($cover['data']), $cover['extension']);
        }

        $song = Song::updateOrCreate(['id' => $this->helperService->getFileHash($path)], [
            'path' => $path,
            'album_id' => $album->id,
            'artist_id' => $artist->id,
            'title' => trim(array_get($tags, 'title', '')),
            'length' => array_get($tags, 'duration', 0) ?: 0,
            'track' => (int) array_get($tags, 'track'),
            'lyrics' => array_get($tags, 'lyrics', '') ?: '',
            'mtime' => time(),
        ]);

        event(new LibraryChanged());

        return response()->json($song);
    }

    /**
     * Remove a song.
     *
     * Remove a song whose information matches with data sent from AWS.
     *
     * @throws Exception
     *
     * @return JsonResponse
     */
    public function remove(RemoveSongRequest $request)
    {
        $song = $this->songRepository->getOneByPath("s3://{$request->bucket}/{$request->key}");
        abort_unless((bool) $song, 404);

        $song->delete();
        event(new LibraryChanged());

        return response()->json();
    }
}