Issues in ScopeService.php (devel) - Issues in devel - pgaultier/yii2-oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (199)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/services/redis/ScopeService.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ScopeService.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\services\redis
 */

namespace sweelix\oauth2\server\services\redis;

use sweelix\oauth2\server\exceptions\DuplicateIndexException;
use sweelix\oauth2\server\exceptions\DuplicateKeyException;
use sweelix\oauth2\server\interfaces\ScopeModelInterface;
use sweelix\oauth2\server\models\Scope;
use sweelix\oauth2\server\interfaces\ScopeServiceInterface;
use yii\db\Exception as DatabaseException;
use Yii;

/**
 * This is the scope service for redis
 *  database structure
 *    * oauth2:scopes:<sid> : hash (Scope)
 *    * oauth2:scopes:keys : set scopeIds
 *    * oauth2:scopes:defaultkeys : set default scopeIds
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\services\redis
 * @since 1.0.0
 */
class ScopeService extends BaseService implements ScopeServiceInterface
{

    /**
     * @param string $sid scope ID
     * @return string scope Key
     * @since 1.0.0
     */
    protected function getScopeKey($sid)
    {
        return $this->namespace . ':' . $sid;
    }

    /**
     * @return string key of all scopes list
     * @since 1.0.0
     */
    protected function getScopeListKey()
    {
        return $this->namespace . ':keys';
    }

    /**
     * @return string key of default scopes list
     * @since 1.0.0
     */
    protected function getScopeDefaultListKey()
    {
        return $this->namespace . ':defaultkeys';
    }

    /**
     * @inheritdoc
     */
    public function save(ScopeModelInterface $scope, $attributes)
    {
        if ($scope->getIsNewRecord()) {
            $result = $this->insert($scope, $attributes);
        } else {
            $result = $this->update($scope, $attributes);
        }
        return $result;
    }

    /**
     * Save Scope
     * @param ScopeModelInterface $scope
     * @param null|array $attributes attributes to save
     * @return bool
     * @throws DatabaseException
     * @throws DuplicateIndexException
     * @throws DuplicateKeyException
     * @since 1.0.0
     */
    protected function insert(ScopeModelInterface $scope, $attributes)
    {
        $result = false;
        if (!$scope->beforeSave(true)) {
            return $result;
        }
        $scopeKey = $this->getScopeKey($scope->getKey());
        $scopeListKey = $this->getScopeListKey();
        $scopeDefaultListKey = $this->getScopeDefaultListKey();
        //check if record exists
        $entityStatus = (int)$this->db->executeCommand('EXISTS', [$scopeKey]);
        if ($entityStatus === 1) {
            throw new DuplicateKeyException('Duplicate key "'.$scopeKey.'"');
        }

        $values = $scope->getDirtyAttributes($attributes);

        $redisParameters = [$scopeKey];
        $this->setAttributesDefinitions($scope->attributesDefinition());
        foreach ($values as $key => $value)
        {
            if ($value !== null) {
                $redisParameters[] = $key;
                $redisParameters[] = $this->convertToDatabase($key, $value);
            }
        }
        //TODO: use EXEC/MULTI to avoid errors
        $transaction = $this->db->executeCommand('MULTI');
        if ($transaction === true) {
            try {
                $this->db->executeCommand('HMSET', $redisParameters);
                $this->db->executeCommand('SADD', [$scopeListKey, $scope->getKey()]);
                if ($scope->isDefault === true) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $this->db->executeCommand('SADD', [$scopeDefaultListKey, $scope->getKey()]);
                }
                $this->db->executeCommand('EXEC');
            } catch (DatabaseException $e) {
                // @codeCoverageIgnoreStart
                // we have a REDIS exception, we should not discard
                Yii::debug('Error while inserting entity', __METHOD__);
                throw $e;
                // @codeCoverageIgnoreEnd
            }
        }
        $changedAttributes = array_fill_keys(array_keys($values), null);
        $scope->setOldAttributes($values);
        $scope->afterSave(true, $changedAttributes);
        $result = true;
        return $result;
    }


    /**
     * Update ScopeModelInterface
     * @param Scope $scope
     * @param null|array $attributes attributes to save
     * @return bool
     * @throws DatabaseException
     * @throws DuplicateIndexException
     * @throws DuplicateKeyException
     */
    protected function update(ScopeModelInterface $scope, $attributes)
    {
        if (!$scope->beforeSave(false)) {
            return false;
        }

        $values = $scope->getDirtyAttributes($attributes);

        $modelKey = $scope->key();
        $scopeId = isset($values[$modelKey]) ? $values[$modelKey] : $scope->getKey();
        $scopeKey = $this->getScopeKey($scopeId);
        $scopeListKey = $this->getScopeListKey();
        $scopeDefaultListKey = $this->getScopeDefaultListKey();


        if (isset($values[$modelKey]) === true) {
            $newScopeKey = $this->getScopeKey($values[$modelKey]);
            $entityStatus = (int)$this->db->executeCommand('EXISTS', [$newScopeKey]);
            if ($entityStatus === 1) {
                throw new DuplicateKeyException('Duplicate key "'.$newScopeKey.'"');
            }
        }

        $this->db->executeCommand('MULTI');
        try {
            $reAddKeyInList = false;
            if (array_key_exists($modelKey, $values) === true) {
                $oldId = $scope->getOldKey();
                $oldScopeKey = $this->getScopeKey($oldId);

                $this->db->executeCommand('RENAMENX', [$oldScopeKey, $scopeKey]);
                $this->db->executeCommand('SREM', [$scopeListKey, $oldScopeKey]);
                $this->db->executeCommand('SREM', [$scopeDefaultListKey, $oldScopeKey]);
                $reAddKeyInList = true;
            }

            $redisUpdateParameters = [$scopeKey];
            $redisDeleteParameters = [$scopeKey];
            $this->setAttributesDefinitions($scope->attributesDefinition());
            foreach ($values as $key => $value)
            {
                if ($value === null) {
                    $redisDeleteParameters[] = $key;
                } else {
                    $redisUpdateParameters[] = $key;
                    $redisUpdateParameters[] = $this->convertToDatabase($key, $value);
                }
            }
            if (count($redisDeleteParameters) > 1) {
                $this->db->executeCommand('HDEL', $redisDeleteParameters);
            }
            if (count($redisUpdateParameters) > 1) {
                $this->db->executeCommand('HMSET', $redisUpdateParameters);
            }

            if ($reAddKeyInList === true) {
                $this->db->executeCommand('SADD', [$scopeListKey, $scopeId]);
            }
            if ($scope->isDefault === true) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->db->executeCommand('SADD', [$scopeDefaultListKey, $scopeId]);
            } else {
                $this->db->executeCommand('SREM', [$scopeDefaultListKey, $scopeId]);
            }

            $this->db->executeCommand('EXEC');
        } catch (DatabaseException $e) {
            // @codeCoverageIgnoreStart
            // we have a REDIS exception, we should not discard
            Yii::debug('Error while updating entity', __METHOD__);
            throw $e;
            // @codeCoverageIgnoreEnd
        }

        $changedAttributes = [];
        foreach ($values as $name => $value) {
            $oldAttributes = $scope->getOldAttributes();
            $changedAttributes[$name] = isset($oldAttributes[$name]) ? $oldAttributes[$name] : null;
            $scope->setOldAttribute($name, $value);
        }
        $scope->afterSave(false, $changedAttributes);
        return true;
    }

    /**
     * @inheritdoc
     */
    public function findOne($key)
    {
        $record = null;
        $scopeKey = $this->getScopeKey($key);
        $scopeExists = (bool)$this->db->executeCommand('EXISTS', [$scopeKey]);
        if ($scopeExists === true) {
            $scopeData = $this->db->executeCommand('HGETALL', [$scopeKey]);
            $record = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
            /** @var ScopeModelInterface $record */
            $properties = $record->attributesDefinition();
            $this->setAttributesDefinitions($properties);
            $attributes = [];
            for ($i = 0; $i < count($scopeData); $i += 2) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                if (isset($properties[$scopeData[$i]]) === true) {
                    $scopeData[$i + 1] = $this->convertToModel($scopeData[$i], $scopeData[($i + 1)]);
                    $record->setAttribute($scopeData[$i], $scopeData[$i + 1]);
                    $attributes[$scopeData[$i]] = $scopeData[$i + 1];
                // @codeCoverageIgnoreStart
                } elseif ($record->canSetProperty($scopeData[$i])) {
                    // TODO: find a way to test attribute population
                    $record->{$scopeData[$i]} = $scopeData[$i + 1];
                }
                // @codeCoverageIgnoreEnd
            }
            if (empty($attributes) === false) {
                $record->setOldAttributes($attributes);
            }
            $record->afterFind();
        }
        return $record;
    }

    /**
     * @inheritdoc
     */
    public function findAvailableScopeIds()
    {
        $scopeListKey = $this->getScopeListKey();
        return $this->db->executeCommand('SMEMBERS', [$scopeListKey]);
    }

    /**
     * @inheritdoc
     */
    public function findDefaultScopeIds($clientId = null)
    {
        //TODO: add default scopes for clients
        $scopeDefaultListKey = $this->getScopeDefaultListKey();
        return $this->db->executeCommand('SMEMBERS', [$scopeDefaultListKey]);
    }

    /**
     * @inheritdoc
     */
    public function delete(ScopeModelInterface $scope)
    {
        $result = false;
        if ($scope->beforeDelete()) {
            $this->db->executeCommand('MULTI');
            $id = $scope->getOldKey();
            $scopeKey = $this->getScopeKey($id);
            $scopeListKey = $this->getScopeListKey();
            $scopeDefaultListKey = $this->getScopeDefaultListKey();


            $this->db->executeCommand('DEL', [$scopeKey]);
            $this->db->executeCommand('SREM', [$scopeListKey, $id]);
            $this->db->executeCommand('SREM', [$scopeDefaultListKey, $id]);
            //TODO: check results to return correct information
            $queryResult = $this->db->executeCommand('EXEC');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $scope->setIsNewRecord(true);
            $scope->afterDelete();
            $result = true;
        }
        return $result;
    }

}


Issues (199)

Security Analysis not enabled

src/services/redis/ScopeService.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1		<?php
2		/**
3		* ScopeService.php
4		*
5		* PHP version 5.6+
6		*
7		* @author Philippe Gaultier <[email protected]>
8		* @copyright 2010-2017 Philippe Gaultier
9		* @license http://www.sweelix.net/license license
10		* @version 1.2.0
11		* @link http://www.sweelix.net
12		* @package sweelix\oauth2\server\services\redis
13		*/
14
15		namespace sweelix\oauth2\server\services\redis;
16
17		use sweelix\oauth2\server\exceptions\DuplicateIndexException;
18		use sweelix\oauth2\server\exceptions\DuplicateKeyException;
19		use sweelix\oauth2\server\interfaces\ScopeModelInterface;
20		use sweelix\oauth2\server\models\Scope;
21		use sweelix\oauth2\server\interfaces\ScopeServiceInterface;
22		use yii\db\Exception as DatabaseException;
23		use Yii;
24
25		/**
26		* This is the scope service for redis
27		* database structure
28		* * oauth2:scopes:<sid> : hash (Scope)
29		* * oauth2:scopes:keys : set scopeIds
30		* * oauth2:scopes:defaultkeys : set default scopeIds
31		*
32		* @author Philippe Gaultier <[email protected]>
33		* @copyright 2010-2017 Philippe Gaultier
34		* @license http://www.sweelix.net/license license
35		* @version 1.2.0
36		* @link http://www.sweelix.net
37		* @package sweelix\oauth2\server\services\redis
38		* @since 1.0.0
39		*/
40		class ScopeService extends BaseService implements ScopeServiceInterface
41		{
42
43		/**
44		* @param string $sid scope ID
45		* @return string scope Key
46		* @since 1.0.0
47		*/
48	18	protected function getScopeKey($sid)
49		{
50	18	return $this->namespace . ':' . $sid;
51		}
52
53		/**
54		* @return string key of all scopes list
55		* @since 1.0.0
56		*/
57	18	protected function getScopeListKey()
58		{
59	18	return $this->namespace . ':keys';
60		}
61
62		/**
63		* @return string key of default scopes list
64		* @since 1.0.0
65		*/
66	25	protected function getScopeDefaultListKey()
67		{
68	25	return $this->namespace . ':defaultkeys';
69		}
70
71		/**
72		* @inheritdoc
73		*/
74	18	public function save(ScopeModelInterface $scope, $attributes)
75		{
76	18	if ($scope->getIsNewRecord()) {
77	18	$result = $this->insert($scope, $attributes);
78	18	} else {
79	1	$result = $this->update($scope, $attributes);
80		}
81	18	return $result;
82		}
83
84		/**
85		* Save Scope
86		* @param ScopeModelInterface $scope
87		* @param null\|array $attributes attributes to save
88		* @return bool
89		* @throws DatabaseException
90		* @throws DuplicateIndexException
91		* @throws DuplicateKeyException
92		* @since 1.0.0
93		*/
94	18	protected function insert(ScopeModelInterface $scope, $attributes)
95		{
96	18	$result = false;
97	18	if (!$scope->beforeSave(true)) {
98		return $result;
99		}
100	18	$scopeKey = $this->getScopeKey($scope->getKey());
101	18	$scopeListKey = $this->getScopeListKey();
102	18	$scopeDefaultListKey = $this->getScopeDefaultListKey();
103		//check if record exists
104	18	$entityStatus = (int)$this->db->executeCommand('EXISTS', [$scopeKey]);
105	18	if ($entityStatus === 1) {
106	1	throw new DuplicateKeyException('Duplicate key "'.$scopeKey.'"');
107		}
108
109	18	$values = $scope->getDirtyAttributes($attributes);
		0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$attributes` defined by parameter `$attributes` on line 94 can also be of type `array`; however, `sweelix\oauth2\server\in...e::getDirtyAttributes()` does only seem to accept `array<integer,string>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
110	18	$redisParameters = [$scopeKey];
111	18	$this->setAttributesDefinitions($scope->attributesDefinition());
112	18	foreach ($values as $key => $value)
113		{
114	18	if ($value !== null) {
115	18	$redisParameters[] = $key;
116	18	$redisParameters[] = $this->convertToDatabase($key, $value);
117	18	}
118	18	}
119		//TODO: use EXEC/MULTI to avoid errors
120	18	$transaction = $this->db->executeCommand('MULTI');
121	18	if ($transaction === true) {
122		try {
123	18	$this->db->executeCommand('HMSET', $redisParameters);
124	18	$this->db->executeCommand('SADD', [$scopeListKey, $scope->getKey()]);
125	18	if ($scope->isDefault === true) {
		0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
126	17	$this->db->executeCommand('SADD', [$scopeDefaultListKey, $scope->getKey()]);
127	17	}
128	18	$this->db->executeCommand('EXEC');
129	18	} catch (DatabaseException $e) {
130		// @codeCoverageIgnoreStart
131		// we have a REDIS exception, we should not discard
132		Yii::debug('Error while inserting entity', __METHOD__);
133		throw $e;
134		// @codeCoverageIgnoreEnd
135		}
136	18	}
137	18	$changedAttributes = array_fill_keys(array_keys($values), null);
138	18	$scope->setOldAttributes($values);
139	18	$scope->afterSave(true, $changedAttributes);
140	18	$result = true;
141	18	return $result;
142		}
143
144
145		/**
146		* Update ScopeModelInterface
147		* @param Scope $scope
148		* @param null\|array $attributes attributes to save
149		* @return bool
150		* @throws DatabaseException
151		* @throws DuplicateIndexException
152		* @throws DuplicateKeyException
153		*/
154	1	protected function update(ScopeModelInterface $scope, $attributes)
155		{
156	1	if (!$scope->beforeSave(false)) {
157		return false;
158		}
159
160	1	$values = $scope->getDirtyAttributes($attributes);
		0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$attributes` defined by parameter `$attributes` on line 154 can also be of type `array`; however, `sweelix\oauth2\server\in...e::getDirtyAttributes()` does only seem to accept `array<integer,string>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
161	1	$modelKey = $scope->key();
162	1	$scopeId = isset($values[$modelKey]) ? $values[$modelKey] : $scope->getKey();
163	1	$scopeKey = $this->getScopeKey($scopeId);
164	1	$scopeListKey = $this->getScopeListKey();
165	1	$scopeDefaultListKey = $this->getScopeDefaultListKey();
166
167
168	1	if (isset($values[$modelKey]) === true) {
169	1	$newScopeKey = $this->getScopeKey($values[$modelKey]);
170	1	$entityStatus = (int)$this->db->executeCommand('EXISTS', [$newScopeKey]);
171	1	if ($entityStatus === 1) {
172	1	throw new DuplicateKeyException('Duplicate key "'.$newScopeKey.'"');
173		}
174	1	}
175
176	1	$this->db->executeCommand('MULTI');
177		try {
178	1	$reAddKeyInList = false;
179	1	if (array_key_exists($modelKey, $values) === true) {
180	1	$oldId = $scope->getOldKey();
181	1	$oldScopeKey = $this->getScopeKey($oldId);
182
183	1	$this->db->executeCommand('RENAMENX', [$oldScopeKey, $scopeKey]);
184	1	$this->db->executeCommand('SREM', [$scopeListKey, $oldScopeKey]);
185	1	$this->db->executeCommand('SREM', [$scopeDefaultListKey, $oldScopeKey]);
186	1	$reAddKeyInList = true;
187	1	}
188
189	1	$redisUpdateParameters = [$scopeKey];
190	1	$redisDeleteParameters = [$scopeKey];
191	1	$this->setAttributesDefinitions($scope->attributesDefinition());
192	1	foreach ($values as $key => $value)
193		{
194	1	if ($value === null) {
195	1	$redisDeleteParameters[] = $key;
196	1	} else {
197	1	$redisUpdateParameters[] = $key;
198	1	$redisUpdateParameters[] = $this->convertToDatabase($key, $value);
199		}
200	1	}
201	1	if (count($redisDeleteParameters) > 1) {
202	1	$this->db->executeCommand('HDEL', $redisDeleteParameters);
203	1	}
204	1	if (count($redisUpdateParameters) > 1) {
205	1	$this->db->executeCommand('HMSET', $redisUpdateParameters);
206	1	}
207
208	1	if ($reAddKeyInList === true) {
209	1	$this->db->executeCommand('SADD', [$scopeListKey, $scopeId]);
210	1	}
211	1	if ($scope->isDefault === true) {
		0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
212	1	$this->db->executeCommand('SADD', [$scopeDefaultListKey, $scopeId]);
213	1	} else {
214	1	$this->db->executeCommand('SREM', [$scopeDefaultListKey, $scopeId]);
215		}
216
217	1	$this->db->executeCommand('EXEC');
218	1	} catch (DatabaseException $e) {
219		// @codeCoverageIgnoreStart
220		// we have a REDIS exception, we should not discard
221		Yii::debug('Error while updating entity', __METHOD__);
222		throw $e;
223		// @codeCoverageIgnoreEnd
224		}
225
226	1	$changedAttributes = [];
227	1	foreach ($values as $name => $value) {
228	1	$oldAttributes = $scope->getOldAttributes();
229	1	$changedAttributes[$name] = isset($oldAttributes[$name]) ? $oldAttributes[$name] : null;
230	1	$scope->setOldAttribute($name, $value);
231	1	}
232	1	$scope->afterSave(false, $changedAttributes);
233	1	return true;
234		}
235
236		/**
237		* @inheritdoc
238		*/
239	2	public function findOne($key)
240		{
241	2	$record = null;
242	2	$scopeKey = $this->getScopeKey($key);
243	2	$scopeExists = (bool)$this->db->executeCommand('EXISTS', [$scopeKey]);
244	2	if ($scopeExists === true) {
245	2	$scopeData = $this->db->executeCommand('HGETALL', [$scopeKey]);
246	2	$record = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
247		/** @var ScopeModelInterface $record */
248	2	$properties = $record->attributesDefinition();
249	2	$this->setAttributesDefinitions($properties);
250	2	$attributes = [];
251	2	for ($i = 0; $i < count($scopeData); $i += 2) {
		0 ignored issues – show Performance Best Practice introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
252	2	if (isset($properties[$scopeData[$i]]) === true) {
253	2	$scopeData[$i + 1] = $this->convertToModel($scopeData[$i], $scopeData[($i + 1)]);
254	2	$record->setAttribute($scopeData[$i], $scopeData[$i + 1]);
255	2	$attributes[$scopeData[$i]] = $scopeData[$i + 1];
256		// @codeCoverageIgnoreStart
257		} elseif ($record->canSetProperty($scopeData[$i])) {
258		// TODO: find a way to test attribute population
259		$record->{$scopeData[$i]} = $scopeData[$i + 1];
260		}
261		// @codeCoverageIgnoreEnd
262	2	}
263	2	if (empty($attributes) === false) {
264	2	$record->setOldAttributes($attributes);
265	2	}
266	2	$record->afterFind();
267	2	}
268	2	return $record;
269		}
270
271		/**
272		* @inheritdoc
273		*/
274	17	public function findAvailableScopeIds()
275		{
276	17	$scopeListKey = $this->getScopeListKey();
277	17	return $this->db->executeCommand('SMEMBERS', [$scopeListKey]);
278		}
279
280		/**
281		* @inheritdoc
282		*/
283	11	public function findDefaultScopeIds($clientId = null)
284		{
285		//TODO: add default scopes for clients
286	11	$scopeDefaultListKey = $this->getScopeDefaultListKey();
287	11	return $this->db->executeCommand('SMEMBERS', [$scopeDefaultListKey]);
288		}
289
290		/**
291		* @inheritdoc
292		*/
293	1	public function delete(ScopeModelInterface $scope)
294		{
295	1	$result = false;
296	1	if ($scope->beforeDelete()) {
297	1	$this->db->executeCommand('MULTI');
298	1	$id = $scope->getOldKey();
299	1	$scopeKey = $this->getScopeKey($id);
300	1	$scopeListKey = $this->getScopeListKey();
301	1	$scopeDefaultListKey = $this->getScopeDefaultListKey();
302
303
304	1	$this->db->executeCommand('DEL', [$scopeKey]);
305	1	$this->db->executeCommand('SREM', [$scopeListKey, $id]);
306	1	$this->db->executeCommand('SREM', [$scopeDefaultListKey, $id]);
307		//TODO: check results to return correct information
308	1	$queryResult = $this->db->executeCommand('EXEC');
		0 ignored issues – show Unused Code introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$queryResult` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
309	1	$scope->setIsNewRecord(true);
310	1	$scope->afterDelete();
311	1	$result = true;
312	1	}
313	1	return $result;
314		}
315
316		}
317

pgaultier / yii2-oauth2

Issues (199)

Security Analysis not enabled

src/services/redis/ScopeService.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like