Issues in KeyController.php (devel) - Issues in devel - pgaultier/yii2-oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (199)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/commands/KeyController.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * KeyController.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 */

namespace sweelix\oauth2\server\commands;

use yii\console\Controller;
use Yii;
use yii\console\ExitCode;

/**
 * Manage oauth keys
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 * @since 1.0.0
 */
class KeyController extends Controller
{

    /**
     * @var string alias to public key file
     */
    public $publicKey;
    /**
     * @var string alias to private key file
     */
    public $privateKey;
    /**
     * @var string encryption algorithm
     */
    public $encryptionAlgorithm;

    /**
     * @inheritdoc
     */
    public function options($actionID)
    {
        return [
            'publicKey',
            'privateKey',
            'encryptionAlgorithm',
        ];
    }

    /**
     * Create new Oauth CypherKey
     * @param string $id Should be client-id or default for common key
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     * @since 1.0.0
     */
    public function actionCreate($id)
    {
        $cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
        /* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
        $cypherKey->id = $id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $hasKey = false;
        if (($this->privateKey !== null) && ($this->publicKey !== null)) {
            $this->privateKey = Yii::getAlias($this->privateKey);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            $this->publicKey = Yii::getAlias($this->publicKey);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            if ((file_exists($this->privateKey) === true) && (file_exists($this->publicKey) === true)) {
                $cypherKey->privateKey = file_get_contents($this->privateKey);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $cypherKey->publicKey = file_get_contents($this->publicKey);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $hasKey = true;
            }
        }
        if ($hasKey === false) {
            $cypherKey->generateKeys();
        }
        if ($cypherKey->save() === true) {
            $this->stdout('Key created :' . "\n");
            $this->stdout(' - id: ' . $cypherKey->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return ExitCode::OK;
        } else {
            $this->stdout('Key cannot be created.' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Update existing Oauth CypherKey
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     */
    public function actionUpdate($id)
    {
        $cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
        $cypherKeyClass = get_class($cypherKey);
        /* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
        $cypherKey = $cypherKeyClass::findOne($id);
        if ($cypherKey !== null) {
            $hasKey = false;
            if (($this->privateKey !== null) && ($this->publicKey !== null)) {
                $this->privateKey = Yii::getAlias($this->privateKey);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                $this->publicKey = Yii::getAlias($this->publicKey);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                if ((file_exists($this->privateKey) === true) && (file_exists($this->publicKey) === true)) {
                    $cypherKey->privateKey = file_get_contents($this->privateKey);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $cypherKey->publicKey = file_get_contents($this->publicKey);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $hasKey = true;
                }
            }
            if ($hasKey === false) {
                $cypherKey->generateKeys();
            }
            if ($cypherKey->save() === true) {
                $this->stdout('Key updated :' . "\n");
                $this->stdout(' - id: ' . $cypherKey->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                return ExitCode::OK;
            } else {
                $this->stdout('Key ' . $id . ' cannot be updated' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Key ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Delete Oauth CypherKey
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     */
    public function actionDelete($id)
    {
        $cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
        $cypherKeyClass = get_class($cypherKey);
        /* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
        $cypherKey = $cypherKeyClass::findOne($id);
        if ($cypherKey !== null) {
            if ($cypherKey->delete() === true) {
                $this->stdout('Key ' . $id . ' deleted' . "\n");
                return ExitCode::OK;
            } else {
                $this->stdout('Key ' . $id . ' cannot be deleted' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Key ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }
}


1			<?php
2			/**
3			* KeyController.php
4			*
5			* PHP version 5.6+
6			*
7			* @author Philippe Gaultier <[email protected]>
8			* @copyright 2010-2017 Philippe Gaultier
9			* @license http://www.sweelix.net/license license
10			* @version 1.2.0
11			* @link http://www.sweelix.net
12			* @package sweelix\oauth2\server\commands
13			*/
14
15			namespace sweelix\oauth2\server\commands;
16
17			use yii\console\Controller;
18			use Yii;
19			use yii\console\ExitCode;
20
21			/**
22			* Manage oauth keys
23			*
24			* @author Philippe Gaultier <[email protected]>
25			* @copyright 2010-2017 Philippe Gaultier
26			* @license http://www.sweelix.net/license license
27			* @version 1.2.0
28			* @link http://www.sweelix.net
29			* @package sweelix\oauth2\server\commands
30			* @since 1.0.0
31			*/
32			class KeyController extends Controller
33			{
34
35			/**
36			* @var string alias to public key file
37			*/
38			public $publicKey;
39			/**
40			* @var string alias to private key file
41			*/
42			public $privateKey;
43			/**
44			* @var string encryption algorithm
45			*/
46			public $encryptionAlgorithm;
47
48			/**
49			* @inheritdoc
50			*/
51			public function options($actionID)
52			{
53			return [
54			'publicKey',
55			'privateKey',
56			'encryptionAlgorithm',
57			];
58			}
59
60			/**
61			* Create new Oauth CypherKey
62			* @param string $id Should be client-id or default for common key
63			* @return int
64			* @throws \yii\base\InvalidConfigException
65			* @throws \yii\base\UnknownClassException
66			* @since 1.0.0
67			*/
68			public function actionCreate($id)
69			{
70			$cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
71			/* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
72			$cypherKey->id = $id;
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73			$hasKey = false;
74			if (($this->privateKey !== null) && ($this->publicKey !== null)) {
75			$this->privateKey = Yii::getAlias($this->privateKey);
			0 ignored issues – show Documentation Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Yii::getAlias($this->privateKey)` can also be of type `boolean`. However, the property `$privateKey` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
76			$this->publicKey = Yii::getAlias($this->publicKey);
			0 ignored issues – show Documentation Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Yii::getAlias($this->publicKey)` can also be of type `boolean`. However, the property `$publicKey` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
77			if ((file_exists($this->privateKey) === true) && (file_exists($this->publicKey) === true)) {
78			$cypherKey->privateKey = file_get_contents($this->privateKey);
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `privateKey` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79			$cypherKey->publicKey = file_get_contents($this->publicKey);
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `publicKey` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
80			$hasKey = true;
81			}
82			}
83			if ($hasKey === false) {
84			$cypherKey->generateKeys();
85			}
86			if ($cypherKey->save() === true) {
87			$this->stdout('Key created :' . "\n");
88			$this->stdout(' - id: ' . $cypherKey->id . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
89			$this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `encryptionAlgorithm` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
90			return ExitCode::OK;
91			} else {
92			$this->stdout('Key cannot be created.' . "\n");
93			return ExitCode::UNSPECIFIED_ERROR;
94			}
95			}
96
97			/**
98			* Update existing Oauth CypherKey
99			* @param $id
100			* @return int
101			* @throws \yii\base\InvalidConfigException
102			* @throws \yii\base\UnknownClassException
103			*/
104			public function actionUpdate($id)
105			{
106			$cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
107			$cypherKeyClass = get_class($cypherKey);
108			/* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
109			$cypherKey = $cypherKeyClass::findOne($id);
110			if ($cypherKey !== null) {
111			$hasKey = false;
112			if (($this->privateKey !== null) && ($this->publicKey !== null)) {
113			$this->privateKey = Yii::getAlias($this->privateKey);
			0 ignored issues – show Documentation Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Yii::getAlias($this->privateKey)` can also be of type `boolean`. However, the property `$privateKey` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
114			$this->publicKey = Yii::getAlias($this->publicKey);
			0 ignored issues – show Documentation Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Yii::getAlias($this->publicKey)` can also be of type `boolean`. However, the property `$publicKey` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
115			if ((file_exists($this->privateKey) === true) && (file_exists($this->publicKey) === true)) {
116			$cypherKey->privateKey = file_get_contents($this->privateKey);
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `privateKey` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
117			$cypherKey->publicKey = file_get_contents($this->publicKey);
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `publicKey` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
118			$hasKey = true;
119			}
120			}
121			if ($hasKey === false) {
122			$cypherKey->generateKeys();
123			}
124			if ($cypherKey->save() === true) {
125			$this->stdout('Key updated :' . "\n");
126			$this->stdout(' - id: ' . $cypherKey->id . "\n");
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
127			$this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `encryptionAlgorithm` on the interface `sweelix\oauth2\server\in...CypherKeyModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
128			return ExitCode::OK;
129			} else {
130			$this->stdout('Key ' . $id . ' cannot be updated' . "\n");
131			return ExitCode::UNSPECIFIED_ERROR;
132			}
133			} else {
134			$this->stdout('Key ' . $id . ' does not exist' . "\n");
135			return ExitCode::UNSPECIFIED_ERROR;
136			}
137			}
138
139			/**
140			* Delete Oauth CypherKey
141			* @param $id
142			* @return int
143			* @throws \yii\base\InvalidConfigException
144			* @throws \yii\base\UnknownClassException
145			*/
146			public function actionDelete($id)
147			{
148			$cypherKey = Yii::createObject('sweelix\oauth2\server\interfaces\CypherKeyModelInterface');
149			$cypherKeyClass = get_class($cypherKey);
150			/* @var \sweelix\oauth2\server\interfaces\CypherKeyModelInterface $cypherKey */
151			$cypherKey = $cypherKeyClass::findOne($id);
152			if ($cypherKey !== null) {
153			if ($cypherKey->delete() === true) {
154			$this->stdout('Key ' . $id . ' deleted' . "\n");
155			return ExitCode::OK;
156			} else {
157			$this->stdout('Key ' . $id . ' cannot be deleted' . "\n");
158			return ExitCode::UNSPECIFIED_ERROR;
159			}
160			} else {
161			$this->stdout('Key ' . $id . ' does not exist' . "\n");
162			return ExitCode::UNSPECIFIED_ERROR;
163			}
164			}
165			}
166

pgaultier / yii2-oauth2

Issues (199)

Security Analysis not enabled

src/commands/KeyController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like