Issues in ClientController.php (devel) - Issues in devel - pgaultier/yii2-oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (199)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/commands/ClientController.php (22 issues)

Labels

Bug 22

Severity

Major 22

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ClientController.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 */

namespace sweelix\oauth2\server\commands;

use sweelix\oauth2\server\models\Client;
use yii\console\Controller;
use Yii;
use yii\console\ExitCode;

/**
 * Manage oauth clients
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 * @since 1.0.0
 */
class ClientController extends Controller
{

    public $redirectUri;
    public $grantTypes;
    public $scopes;
    public $userId;
    public $name;
    public $isPublic;

    /**
     * @inheritdoc
     */
    public function options($actionID)
    {
        return [
            // Generated 'id',
            // Generated 'secret',
            'redirectUri',
            'grantTypes',
            'scopes',
            'userId',
            'name',
            'isPublic'
        ];
    }

    /**
     * Create new Oauth client
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     * @since 1.0.0
     */
    public function actionCreate()
    {

        $client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
        /* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
        $client->id = $this->getRandomString();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->secret = $this->getRandomString();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->name = $this->name;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $redirectUri = empty($this->redirectUri) ? null : explode(',', $this->redirectUri);
        $client->redirectUri = $redirectUri;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->userId = $this->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->isPublic = (bool)$this->isPublic;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->scopes = empty($this->scopes) ? null : explode(',', $this->scopes);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $client->grantTypes = empty($this->grantTypes) ? null : explode(',', $this->grantTypes);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        if ($client->save() === true) {
            $this->stdout('Client created :' . "\n");
            $this->stdout(' - id: ' . $client->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - secret: ' . $client->secret . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - name: ' . $client->name . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - redirectUri: ' . implode(',', $client->redirectUri) . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return ExitCode::OK;
        } else {
            $this->stdout('Client cannot be created.' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Generate random string
     * @param int $length
     * @return string
     * @since 1.0.0
     */
    protected function getRandomString($length = 40)
    {
        $bytes = (int)$length / 2;
        return bin2hex(openssl_random_pseudo_bytes($bytes));
    }

    /**
     * Update Oauth client
     * @param $id
     * @return int
     * @throws \yii\base\UnknownClassException
     * @throws \yii\base\InvalidConfigException
     */
    public function actionUpdate($id)
    {
        $client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
        $clientClass = get_class($client);
        /* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
        $client = $clientClass::findOne($id);
        if ($client !== null) {
            $client->redirectUri = $this->redirectUri;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $client->name = $this->name;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $client->userId = $this->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $client->isPublic = (bool)$this->isPublic;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $client->scopes = empty($this->scopes) ? null : explode(',', $this->scopes);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $client->grantTypes = empty($this->grantTypes) ? null : explode(',', $this->grantTypes);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            if ($client->save() === true) {
                $this->stdout('Client updated :' . "\n");
                $this->stdout(' - id: ' . $client->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - secret: ' . $client->secret . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - name: ' . $client->name . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - redirectUri: ' . implode(',', $client->redirectUri) . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                return ExitCode::OK;
            } else {
                $this->stdout('Client ' . $id . ' cannot be updated.' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Client ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Delete Oauth client
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     */
    public function actionDelete($id)
    {
        $client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
        $clientClass = get_class($client);
        /* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
        $client = $clientClass::findOne($id);
        if ($client !== null) {
            if ($client->delete() === true) {
                $this->stdout('Client ' . $id . ' deleted' . "\n");
                return ExitCode::OK;
            } else {
                $this->stdout('Client ' . $id . ' cannot be deleted.' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Client ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }
}


1			<?php
2			/**
3			* ClientController.php
4			*
5			* PHP version 5.6+
6			*
7			* @author Philippe Gaultier <[email protected]>
8			* @copyright 2010-2017 Philippe Gaultier
9			* @license http://www.sweelix.net/license license
10			* @version 1.2.0
11			* @link http://www.sweelix.net
12			* @package sweelix\oauth2\server\commands
13			*/
14
15			namespace sweelix\oauth2\server\commands;
16
17			use sweelix\oauth2\server\models\Client;
18			use yii\console\Controller;
19			use Yii;
20			use yii\console\ExitCode;
21
22			/**
23			* Manage oauth clients
24			*
25			* @author Philippe Gaultier <[email protected]>
26			* @copyright 2010-2017 Philippe Gaultier
27			* @license http://www.sweelix.net/license license
28			* @version 1.2.0
29			* @link http://www.sweelix.net
30			* @package sweelix\oauth2\server\commands
31			* @since 1.0.0
32			*/
33			class ClientController extends Controller
34			{
35
36			public $redirectUri;
37			public $grantTypes;
38			public $scopes;
39			public $userId;
40			public $name;
41			public $isPublic;
42
43			/**
44			* @inheritdoc
45			*/
46			public function options($actionID)
47			{
48			return [
49			// Generated 'id',
50			// Generated 'secret',
51			'redirectUri',
52			'grantTypes',
53			'scopes',
54			'userId',
55			'name',
56			'isPublic'
57			];
58			}
59
60			/**
61			* Create new Oauth client
62			* @return int
63			* @throws \yii\base\InvalidConfigException
64			* @throws \yii\base\UnknownClassException
65			* @since 1.0.0
66			*/
67			public function actionCreate()
68			{
69
70			$client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
71			/* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
72			$client->id = $this->getRandomString();
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73			$client->secret = $this->getRandomString();
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `secret` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
74			$client->name = $this->name;
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `name` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
75			$redirectUri = empty($this->redirectUri) ? null : explode(',', $this->redirectUri);
76			$client->redirectUri = $redirectUri;
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `redirectUri` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
77			$client->userId = $this->userId;
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `userId` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
78			$client->isPublic = (bool)$this->isPublic;
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `isPublic` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79			$client->scopes = empty($this->scopes) ? null : explode(',', $this->scopes);
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `scopes` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
80			$client->grantTypes = empty($this->grantTypes) ? null : explode(',', $this->grantTypes);
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `grantTypes` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
81			if ($client->save() === true) {
82			$this->stdout('Client created :' . "\n");
83			$this->stdout(' - id: ' . $client->id . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
84			$this->stdout(' - secret: ' . $client->secret . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `secret` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
85			$this->stdout(' - name: ' . $client->name . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `name` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
86			$this->stdout(' - redirectUri: ' . implode(',', $client->redirectUri) . "\n");
			0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `redirectUri` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
87			return ExitCode::OK;
88			} else {
89			$this->stdout('Client cannot be created.' . "\n");
90			return ExitCode::UNSPECIFIED_ERROR;
91			}
92			}
93
94			/**
95			* Generate random string
96			* @param int $length
97			* @return string
98			* @since 1.0.0
99			*/
100			protected function getRandomString($length = 40)
101			{
102			$bytes = (int)$length / 2;
103			return bin2hex(openssl_random_pseudo_bytes($bytes));
104			}
105
106			/**
107			* Update Oauth client
108			* @param $id
109			* @return int
110			* @throws \yii\base\UnknownClassException
111			* @throws \yii\base\InvalidConfigException
112			*/
113			public function actionUpdate($id)
114			{
115			$client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
116			$clientClass = get_class($client);
117			/* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
118			$client = $clientClass::findOne($id);
119			if ($client !== null) {
120			$client->redirectUri = $this->redirectUri;
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `redirectUri` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
121			$client->name = $this->name;
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `name` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
122			$client->userId = $this->userId;
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `userId` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
123			$client->isPublic = (bool)$this->isPublic;
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `isPublic` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
124			$client->scopes = empty($this->scopes) ? null : explode(',', $this->scopes);
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `scopes` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
125			$client->grantTypes = empty($this->grantTypes) ? null : explode(',', $this->grantTypes);
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `grantTypes` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
126			if ($client->save() === true) {
127			$this->stdout('Client updated :' . "\n");
128			$this->stdout(' - id: ' . $client->id . "\n");
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
129			$this->stdout(' - secret: ' . $client->secret . "\n");
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `secret` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
130			$this->stdout(' - name: ' . $client->name . "\n");
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `name` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
131			$this->stdout(' - redirectUri: ' . implode(',', $client->redirectUri) . "\n");
			0 ignored issues – show Bug introduced 2016-11-05 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `redirectUri` on the interface `sweelix\oauth2\server\in...es\ClientModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
132			return ExitCode::OK;
133			} else {
134			$this->stdout('Client ' . $id . ' cannot be updated.' . "\n");
135			return ExitCode::UNSPECIFIED_ERROR;
136			}
137			} else {
138			$this->stdout('Client ' . $id . ' does not exist' . "\n");
139			return ExitCode::UNSPECIFIED_ERROR;
140			}
141			}
142
143			/**
144			* Delete Oauth client
145			* @param $id
146			* @return int
147			* @throws \yii\base\InvalidConfigException
148			* @throws \yii\base\UnknownClassException
149			*/
150			public function actionDelete($id)
151			{
152			$client = Yii::createObject('sweelix\oauth2\server\interfaces\ClientModelInterface');
153			$clientClass = get_class($client);
154			/* @var \sweelix\oauth2\server\interfaces\ClientModelInterface $client */
155			$client = $clientClass::findOne($id);
156			if ($client !== null) {
157			if ($client->delete() === true) {
158			$this->stdout('Client ' . $id . ' deleted' . "\n");
159			return ExitCode::OK;
160			} else {
161			$this->stdout('Client ' . $id . ' cannot be deleted.' . "\n");
162			return ExitCode::UNSPECIFIED_ERROR;
163			}
164			} else {
165			$this->stdout('Client ' . $id . ' does not exist' . "\n");
166			return ExitCode::UNSPECIFIED_ERROR;
167			}
168			}
169			}
170

pgaultier / yii2-oauth2

Issues (199)

Security Analysis not enabled

src/commands/ClientController.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like