sweelix\oauth2\server\services\redis\AccessTokenService::insert()

Complexity

Conditions	9
Paths	57

Size

Total Lines	55
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	36
CRAP Score	9.0117

Importance

Changes

0

<?php
    protected function insert(AccessTokenModelInterface $accessToken, $attributes)
    {
        $result = false;
        if (!$accessToken->beforeSave(true)) {
            return $result;
        }
        $accessTokenId = $accessToken->getKey();
        $accessTokenKey = $this->getAccessTokenKey($accessTokenId);
        if (empty($accessToken->userId) === false) {

Accessing userId on the interface sweelix\oauth2\server\interfaces\AccessTokenModelInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $userAccessTokensKey = $this->getUserAccessTokensKey($accessToken->userId);

Accessing userId on the interface sweelix\oauth2\server\interfaces\AccessTokenModelInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        } else {
            $userAccessTokensKey = null;
        }
        $clientAccessTokensKey = $this->getClientAccessTokensKey($accessToken->clientId);

Accessing clientId on the interface sweelix\oauth2\server\interfaces\AccessTokenModelInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        //check if record exists
        $entityStatus = (int)$this->db->executeCommand('EXISTS', [$accessTokenKey]);
        if ($entityStatus === 1) {
            throw new DuplicateKeyException('Duplicate key "'.$accessTokenKey.'"');
        }

        $values = $accessToken->getDirtyAttributes($attributes);

It seems like $attributes defined by parameter $attributes on line 104 can also be of type array; however, sweelix\oauth2\server\interfaces\BaseModelInterface::getDirtyAttributes() does only seem to accept array<integer,string>|null, maybe add an additional type check?

        $redisParameters = [$accessTokenKey];
        $this->setAttributesDefinitions($accessToken->attributesDefinition());
        foreach ($values as $key => $value)
        {
            if ($value !== null) {
                $redisParameters[] = $key;
                $redisParameters[] = $this->convertToDatabase($key, $value);
            }
        }
        //TODO: use EXEC/MULTI to avoid errors
        $transaction = $this->db->executeCommand('MULTI');
        if ($transaction === true) {
            try {
                $this->db->executeCommand('HMSET', $redisParameters);
                if ($userAccessTokensKey !== null) {
                    $this->db->executeCommand('SADD', [$userAccessTokensKey, $accessTokenId]);
                }
                $this->db->executeCommand('SADD', [$clientAccessTokensKey, $accessTokenId]);
                $this->db->executeCommand('EXEC');
            } catch (DatabaseException $e) {
                // @codeCoverageIgnoreStart
                // we have a REDIS exception, we should not discard
                Yii::trace('Error while inserting entity', __METHOD__);
                throw $e;
                // @codeCoverageIgnoreEnd
            }
        }
        $changedAttributes = array_fill_keys(array_keys($values), null);
        $accessToken->setOldAttributes($values);
        $accessToken->afterSave(true, $changedAttributes);
        $result = true;
        return $result;
    }