BaseService::__construct() - Code Metrics - Inspection of "Merge branch 'feature/testing' into 'devel'" - pgaultier/yii2-oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — devel ( 7508db...540322 )

by Philippe

created 2016-11-06 21:05 UTC

BaseService::__construct() A

↳ Parent: BaseService

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
c	0
b	0
f	0
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php
/**
 * BearerService.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2016 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version XXX
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\services\redis
 */

namespace sweelix\oauth2\server\services\redis;

use sweelix\oauth2\server\interfaces\BaseModelInterface;
use sweelix\oauth2\server\models\BaseModel;
use sweelix\oauth2\server\Module;
use sweelix\oauth2\server\traits\redis\TypeConverter;
use yii\base\Object;
use yii\di\Instance;
use yii\helpers\Json;
use yii\redis\Connection;
use Yii;

/**
 * This is the base service for redis
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2016 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version XXX
 * @link http://www.sweelix.net
 * @package modules\v1\services\redis
 * @since XXX
 */
class BaseService extends Object
{
    use TypeConverter;

    /**
     * @var string namespace used for key generation
     */
    public $namespace = '';

    /**
     * @var Connection|array|string the Redis DB connection object or the application component ID of the DB connection.
     */
    protected $db;

    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();
        $this->db = Instance::ensure(Module::getInstance()->db, Connection::className());
    }

    /**
     * Compute etag based on model attributes
     * @param BaseModelInterface $model
     * @return string
     * @since XXX
     */
    protected function computeEtag(BaseModelInterface $model)
    {
        return $this->encodeAttributes($model->attributes);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Encode attributes array
     *
     * @param array $attributes
     *
     * @return string
     * @since  XXX
     */
    protected function encodeAttributes(Array $attributes)
    {
        $data = Json::encode($attributes);
        $etag = '"' . rtrim(base64_encode(sha1($data, true)), '=') . '"';
        return $etag;
    }

}


1		<?php
2		/**
3		* BearerService.php
4		*
5		* PHP version 5.6+
6		*
7		* @author Philippe Gaultier <[email protected]>
8		* @copyright 2010-2016 Philippe Gaultier
9		* @license http://www.sweelix.net/license license
10		* @version XXX
11		* @link http://www.sweelix.net
12		* @package sweelix\oauth2\server\services\redis
13		*/
14
15		namespace sweelix\oauth2\server\services\redis;
16
17		use sweelix\oauth2\server\interfaces\BaseModelInterface;
18		use sweelix\oauth2\server\models\BaseModel;
19		use sweelix\oauth2\server\Module;
20		use sweelix\oauth2\server\traits\redis\TypeConverter;
21		use yii\base\Object;
22		use yii\di\Instance;
23		use yii\helpers\Json;
24		use yii\redis\Connection;
25		use Yii;
26
27		/**
28		* This is the base service for redis
29		*
30		* @author Philippe Gaultier <[email protected]>
31		* @copyright 2010-2016 Philippe Gaultier
32		* @license http://www.sweelix.net/license license
33		* @version XXX
34		* @link http://www.sweelix.net
35		* @package modules\v1\services\redis
36		* @since XXX
37		*/
38		class BaseService extends Object
39		{
40		use TypeConverter;
41
42		/**
43		* @var string namespace used for key generation
44		*/
45		public $namespace = '';
46
47		/**
48		* @var Connection\|array\|string the Redis DB connection object or the application component ID of the DB connection.
49		*/
50		protected $db;
51
52		/**
53		* @inheritdoc
54		*/
55	6	public function init()
56		{
57	6	parent::init();
58	6	$this->db = Instance::ensure(Module::getInstance()->db, Connection::className());
59	6	}
60
61		/**
62		* Compute etag based on model attributes
63		* @param BaseModelInterface $model
64		* @return string
65		* @since XXX
66		*/
67		protected function computeEtag(BaseModelInterface $model)
68		{
69		return $this->encodeAttributes($model->attributes);
		0 ignored issues – show Bug introduced 2016-11-02 21:28 UTC by Report Bug Copy Issue Report Accessing `attributes` on the interface `sweelix\oauth2\server\in...aces\BaseModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
70		}
71
72		/**
73		* Encode attributes array
74		*
75		* @param array $attributes
76		*
77		* @return string
78		* @since XXX
79		*/
80		protected function encodeAttributes(Array $attributes)
81		{
82		$data = Json::encode($attributes);
83		$etag = '"' . rtrim(base64_encode(sha1($data, true)), '=') . '"';
84		return $etag;
85		}
86
87		}
88

pgaultier / yii2-oauth2

Push — devel ( 7508db...540322 )

BaseService::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like