Issues in NodeTrait.php (master) - Issues in master - pgaultier/tree - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/NodeTrait.php (3 issues)

Labels

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * NodeTrait.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2016 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version XXX
 * @link http://www.sweelix.net
 * @package sweelix\tree
 */

namespace sweelix\tree;

/**
 * Trait used to handle tree node management
 *
 * All matrices used are 2x2. The array notation is done like this :
 *
 *  Matrix | a, b | is written in array [a, b, c, d]
 *         | c, d |
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2016 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version XXX
 * @link http://www.sweelix.net
 * @package sweelix\tree
 * @since XXX
 */
trait NodeTrait
{

    /**
     * @var string node path in dot notation
     */
    protected $nodePath;

    /**
     * @var array node path in matrix notation
     */
    protected $nodeMatrix;

    /**
     * @return string node path in dot notation
     * @since XXX
     */
    public function getPath()
    {
        return $this->nodePath;
    }

    /**
     * @param string $path node path in dot notation (1.1.2)
     * @return static
     * @since XXX
     */
    public function setPath($path)
    {
        $this->nodePath = $path;
        $this->nodeMatrix = Helper::convertPathToMatrix($path);

    }

    /**
     * @return array node path in matrix notation
     * @since XXX
     */
    public function getMatrix()
    {
        return $this->nodeMatrix;
    }

    /**
     * Create a node object from a matrix
     * @param array $matrix node path in matrix notation [a, b, c, d]
     * @return static
     * @since XXX
     */
    public function setMatrix($matrix)
    {
        if (is_array($matrix) === true) {
            $matrix = new Matrix($matrix);
        }
        $this->nodeMatrix = $matrix;

        $this->nodePath = Helper::convertMatrixToPath($matrix);

    }

    /**
     * @return float left border
     * @since XXX
     */
    public function getLeft()
    {
        return $this->nodeMatrix->a / $this->nodeMatrix->c;
    }

    /**
     * @return float right border
     * @since XXX
     */
    public function getRight()
    {
        return $this->nodeMatrix->b / $this->nodeMatrix->d;
    }

    /**
     * Check if we can perform selected move
     * @param string $fromPath original Path
     * @param string $toPath new Path
     * @return bool
     * @since XXX
     */
    public function canMove($fromPath, $toPath)
    {
        return (strncmp($fromPath, $toPath, strlen($fromPath)) !== 0);
    }

    /**
     * Move current node from one path to another
     * @param string $fromPath original Path
     * @param string $toPath new Path
     * @param int $bump offset if we need to re-key the path
     * @return boolean
     * @since XXX
     */
    public function move($fromPath, $toPath, $bump = 0)
    {
        // cannot move into self tree
        $status = $this->canMove($fromPath, $toPath);
        if($status === true) {
            $fromMatrix = Helper::convertPathToMatrix($fromPath);
            $toMatrix = Helper::convertPathToMatrix($toPath);
            $moveMatrix = Helper::buildMoveMatrix($fromMatrix, $toMatrix, $bump);
            $moveMatrix->multiply($this->nodeMatrix);
            $this->nodeMatrix = $moveMatrix;

            $this->nodePath = Helper::convertMatrixToPath($this->nodeMatrix);
        }
        return $status;
    }
    
}


1			<?php
2			/**
3			* NodeTrait.php
4			*
5			* PHP version 5.6+
6			*
7			* @author Philippe Gaultier <[email protected]>
8			* @copyright 2010-2016 Philippe Gaultier
9			* @license http://www.sweelix.net/license license
10			* @version XXX
11			* @link http://www.sweelix.net
12			* @package sweelix\tree
13			*/
14
15			namespace sweelix\tree;
16
17			/**
18			* Trait used to handle tree node management
19			*
20			* All matrices used are 2x2. The array notation is done like this :
21			*
22			* Matrix \| a, b \| is written in array [a, b, c, d]
23			* \| c, d \|
24			*
25			* @author Philippe Gaultier <[email protected]>
26			* @copyright 2010-2016 Philippe Gaultier
27			* @license http://www.sweelix.net/license license
28			* @version XXX
29			* @link http://www.sweelix.net
30			* @package sweelix\tree
31			* @since XXX
32			*/
33			trait NodeTrait
34			{
35
36			/**
37			* @var string node path in dot notation
38			*/
39			protected $nodePath;
40
41			/**
42			* @var array node path in matrix notation
43			*/
44			protected $nodeMatrix;
45
46			/**
47			* @return string node path in dot notation
48			* @since XXX
49			*/
50			public function getPath()
51			{
52			return $this->nodePath;
53			}
54
55			/**
56			* @param string $path node path in dot notation (1.1.2)
57			* @return static
58			* @since XXX
59			*/
60			public function setPath($path)
61			{
62			$this->nodePath = $path;
63			$this->nodeMatrix = Helper::convertPathToMatrix($path);
			0 ignored issues – show Documentation Bug introduced 2016-03-21 17:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\sweelix\tree\Helper::convertPathToMatrix($path)` of type `object<sweelix\tree\Matrix>` is incompatible with the declared type `array` of property `$nodeMatrix`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
64			}
65
66			/**
67			* @return array node path in matrix notation
68			* @since XXX
69			*/
70			public function getMatrix()
71			{
72			return $this->nodeMatrix;
73			}
74
75			/**
76			* Create a node object from a matrix
77			* @param array $matrix node path in matrix notation [a, b, c, d]
78			* @return static
79			* @since XXX
80			*/
81			public function setMatrix($matrix)
82			{
83			if (is_array($matrix) === true) {
84			$matrix = new Matrix($matrix);
85			}
86			$this->nodeMatrix = $matrix;
			0 ignored issues – show Documentation Bug introduced 2016-03-21 17:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$matrix` of type `object<sweelix\tree\Matrix>` is incompatible with the declared type `array` of property `$nodeMatrix`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
87			$this->nodePath = Helper::convertMatrixToPath($matrix);
88
89			}
90
91			/**
92			* @return float left border
93			* @since XXX
94			*/
95			public function getLeft()
96			{
97			return $this->nodeMatrix->a / $this->nodeMatrix->c;
98			}
99
100			/**
101			* @return float right border
102			* @since XXX
103			*/
104			public function getRight()
105			{
106			return $this->nodeMatrix->b / $this->nodeMatrix->d;
107			}
108
109			/**
110			* Check if we can perform selected move
111			* @param string $fromPath original Path
112			* @param string $toPath new Path
113			* @return bool
114			* @since XXX
115			*/
116			public function canMove($fromPath, $toPath)
117			{
118			return (strncmp($fromPath, $toPath, strlen($fromPath)) !== 0);
119			}
120
121			/**
122			* Move current node from one path to another
123			* @param string $fromPath original Path
124			* @param string $toPath new Path
125			* @param int $bump offset if we need to re-key the path
126			* @return boolean
127			* @since XXX
128			*/
129			public function move($fromPath, $toPath, $bump = 0)
130			{
131			// cannot move into self tree
132			$status = $this->canMove($fromPath, $toPath);
133			if($status === true) {
134			$fromMatrix = Helper::convertPathToMatrix($fromPath);
135			$toMatrix = Helper::convertPathToMatrix($toPath);
136			$moveMatrix = Helper::buildMoveMatrix($fromMatrix, $toMatrix, $bump);
137			$moveMatrix->multiply($this->nodeMatrix);
138			$this->nodeMatrix = $moveMatrix;
			0 ignored issues – show Documentation Bug introduced 2016-03-21 17:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$moveMatrix` of type `object<sweelix\tree\Matrix>` is incompatible with the declared type `array` of property `$nodeMatrix`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
139			$this->nodePath = Helper::convertMatrixToPath($this->nodeMatrix);
140			}
141			return $status;
142			}
143
144			}
145

pgaultier / tree

Issues (6)

Security Analysis no request data

src/NodeTrait.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like