Pfilsx\DataGrid\Config\ConfigurationContainer

Complexity

Total Complexity

5

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
A	getInstance()	0	3	2

<?php


namespace Pfilsx\DataGrid\Config;


class ConfigurationContainer implements ConfigurationContainerInterface
{
    /**
     * @var ConfigurationInterface[]
     */
    private $instances = [];

    public function __construct(array $config)
    {
        $this->instances['default'] = new Configuration([
            'template' => '@DataGrid/grid.blocks.html.twig',
            'no_data_message' => 'No data found',
            'show_titles' => true,
            'pagination_enabled' => true,
            'pagination_limit' => 10,
            'translation_domain' => null
        ]);
        if (!empty($config['instances'])){
            foreach ($config['instances'] as $key => $configuration) {
                $this->instances[$key] = new Configuration($configuration);
            }
        }
    }

    public function getInstance(string $name): ConfigurationInterface
    {
        return array_key_exists($name, $this->instances) ? $this->instances[$name] : null;

The expression return array_key_exists($name, $this->instances) ? $this->instances[$name] : null could return the type null which is incompatible with the type-hinted return Pfilsx\DataGrid\Config\ConfigurationInterface. Consider adding an additional type-check to rule them out.

    }
}