MemoryGauge::getSystemMemoryInfo() - Code Metrics - Inspection of "refactor gauge initialization" - petrica/php-statsd-system - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (98e19a)

by Petrică

created 2016-03-30 21:23 UTC

MemoryGauge::getSystemMemoryInfo() A

↳ Parent: MemoryGauge

Complexity

Conditions	4
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	0
cts	13
cp	0
rs	9.2
cc	4
eloc	10
nc	2
nop	0
crap	20

<?php
/**
 * Created by PhpStorm.
 * User: Petrica
 * Date: 3/24/2016
 * Time: 1:17
 */
namespace Petrica\StatsdSystem\Gauge;

use Petrica\StatsdSystem\Collection\ValuesCollection;

class MemoryGauge implements GaugeInterface
{
    const MEMINFO_PATH = '/proc/meminfo';

    /**
     * {@inheritdoc}
     */
    public function getSamplingPeriod()
    {
        return 10;
    }

    /**
     * {@inheritdoc}
     */
    public function getCollection()
    {
        $collection = new ValuesCollection();

        $info = $this->getSystemMemoryInfo();

        if (!empty($info) &&
            isset($info['MemTotal']) &&
            isset($info['MemFree'])) {

            $collection->add('total.value', $info['MemTotal']);
            $collection->add('free.value', $info['MemFree']);
            $collection->add('used.value', $this->getUsedMemory($info));
        }

        return $collection;
    }

    /**
     * Only for linux/unix OS
     *
     * @return array
     */
    protected function getSystemMemoryInfo()
    {
        $meminfo = array();

        if (file_exists(static::MEMINFO_PATH)) {
            $data = explode("\n", file_get_contents(static::MEMINFO_PATH));
            $meminfo = array();
            foreach ($data as $line) {
                if (!empty($line)) {
                    list($key, $val) = explode(":", $line);

                    $meminfo[$key] = intval($val);
                }
            }
        }

        return $meminfo;
    }

    /**
     * Return used memory
     *
     * @param $info
     * @return null
     */
    protected function getUsedMemory($info)
    {
        if (isset($info['MemFree'])
            && isset($info['MemTotal'])) {
            return $info['MemTotal'] - $info['MemFree'];
        }

        return null;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Petrica
5		* Date: 3/24/2016
6		* Time: 1:17
7		*/
8		namespace Petrica\StatsdSystem\Gauge;
9
10		use Petrica\StatsdSystem\Collection\ValuesCollection;
11
12		class MemoryGauge implements GaugeInterface
13		{
14		const MEMINFO_PATH = '/proc/meminfo';
15
16		/**
17		* {@inheritdoc}
18		*/
19		public function getSamplingPeriod()
20		{
21		return 10;
22		}
23
24		/**
25		* {@inheritdoc}
26		*/
27	1	public function getCollection()
28		{
29	1	$collection = new ValuesCollection();
30
31	1	$info = $this->getSystemMemoryInfo();
32
33	1	if (!empty($info) &&
34	1	isset($info['MemTotal']) &&
35	1	isset($info['MemFree'])) {
36
37	1	$collection->add('total.value', $info['MemTotal']);
38	1	$collection->add('free.value', $info['MemFree']);
39	1	$collection->add('used.value', $this->getUsedMemory($info));
40	1	}
41
42	1	return $collection;
43		}
44
45		/**
46		* Only for linux/unix OS
47		*
48		* @return array
49		*/
50		protected function getSystemMemoryInfo()
51		{
52		$meminfo = array();
53
54		if (file_exists(static::MEMINFO_PATH)) {
55		$data = explode("\n", file_get_contents(static::MEMINFO_PATH));
56		$meminfo = array();
57		foreach ($data as $line) {
58		if (!empty($line)) {
59		list($key, $val) = explode(":", $line);
60
61		$meminfo[$key] = intval($val);
62		}
63		}
64		}
65
66		return $meminfo;
67		}
68
69		/**
70		* Return used memory
71		*
72		* @param $info
73		* @return null
74		*/
75	1	protected function getUsedMemory($info)
76		{
77	1	if (isset($info['MemFree'])
78	1	&& isset($info['MemTotal'])) {
79	1	return $info['MemTotal'] - $info['MemFree'];
80		}
81
82		return null;
83		}
84		}
85

petrica / php-statsd-system

Branch — master (98e19a)

MemoryGauge::getSystemMemoryInfo() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like