Petrica\StatsdSystem\Statsd\Connection\UdpSocket

Complexity

Total Complexity

8

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	8	2
A	close()	0	7	2
A	writeToSocket()	0	5	1
A	connect()	0	15	2
A	isConnected()	0	4	1

<?php

namespace Petrica\StatsdSystem\Statsd\Connection;

use Domnikl\Statsd\Connection;

class UdpSocket extends Connection\InetSocket implements Connection
{
    /**
     * the used UDP socket resource
     *
     * @var resource|null|false
     */
    private $socket;

    /**
     * @var bool
     */
    private $isConnected;

    /**
     * sends a message to the socket
     *
     * @param string $message
     *
     * @codeCoverageIgnore
     * this is ignored because it writes to an actual socket and is not testable
     */
    public function send($message)
    {
        try {
            parent::send($message);
        } catch (\Exception $e) {
            // ignore it: stats logging failure shouldn't stop the whole app
        }
    }

    /**
     * Manually close current connection
     */
    public function close()
    {
        if ($this->isConnected()) {
            @fclose($this->socket);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->isConnected = false;
        }
    }

    /**
     * @param string $message
     */
    protected function writeToSocket($message)
    {
        // suppress all errors
        @fwrite($this->socket, $message);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

    }

    /**
     * @param string $host
     * @param int $port
     * @param int|null $timeout
     * @param bool $persistent
     */
    protected function connect($host, $port, $timeout, $persistent = false)
    {
        $errorNumber = null;
        $errorMessage = null;

        $url = sprintf("udp://%s", $host);

        if ($persistent) {
            $this->socket = @pfsockopen($url, $port, $errorNumber, $errorMessage, $timeout);
        } else {
            $this->socket = @fsockopen($url, $port, $errorNumber, $errorMessage, $timeout);
        }

        $this->isConnected = true;
    }

    /**
     * checks whether the socket connection is alive
     *
     * only tries to connect once
     *
     * ever after isConnected will return true,
     * because $this->socket is then false
     *
     * @return bool
     */
    protected function isConnected()
    {
        return $this->isConnected;
    }
}