Issues in SesManager.php (master) - Issues in master - peternijssen/ses-configuration - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Manager/SesManager.php (4 issues)

Labels

Duplication 4

Severity

Informational 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PeterNijssen\Ses\Manager;

use Aws\Ses\SesClient;
use PeterNijssen\Ses\Exception\InvalidFetchStatusException;
use PeterNijssen\Ses\Model\Dns;
use PeterNijssen\Ses\Model\IdentityInterface;

/**
 * This service manages AWS SES
 */
abstract class SesManager
{
    /**
     * @var SesClient
     */
    protected $sesClient;

    /**
     * @var IdentityInterface
     */
    protected $identity;

    /**
     * Constructor
     *
     * @param SesClient         $sesClient
     * @param IdentityInterface $identity
     */
    public function __construct(SesClient $sesClient, IdentityInterface $identity)
    {
        $this->sesClient = $sesClient;
        $this->identity = $identity;
    }

    /**
     * Fetch the current status
     *
     * @return string
     *
     * @throws InvalidFetchStatusException
     */
    public function fetchStatus()

    {
        $result = $this->sesClient->getIdentityVerificationAttributes(
            [
                'Identities' => [$this->identity->getIdentity()],
            ]
        );

        $status = $result->search("VerificationAttributes.*.VerificationStatus");

        if (!is_array($status)) {
            throw new InvalidFetchStatusException("unable to fetch the status. Did you create the identity?");
        }

        return current($status);
    }

    /**
     * Fetch the current DKIM status
     *
     * @return string
     *
     * @throws InvalidFetchStatusException
     */
    public function fetchDkimStatus()

    {
        $result = $this->sesClient->getIdentityDkimAttributes(
            [
                'Identities' => [$this->identity->getIdentity()],
            ]
        );

        $status = $result->search("DkimAttributes.*.DkimVerificationStatus");

        if (!is_array($status)) {
            throw new InvalidFetchStatusException("unable to fetch the DKIM status. Did you create the identity?");
        }

        return current($status);
    }

    /**
     * Return the DNS records for the DKIM settings
     *
     * @return array
     */
    public function fetchDkimRecords()
    {
        $result = $this->sesClient->getIdentityDkimAttributes(
            [
                'Identities' => [$this->identity->getIdentity()],
            ]
        );

        $records = [];
        $results = $result->search("DkimAttributes.*.DkimTokens");
        if (is_array($results)) {
            foreach (current($results) as $result) {
                $name = $result."._domainkey.".$this->identity->getDomain();
                $value = $result.".dkim.amazonses.com";

                $records[] = new Dns("CNAME", $name, $value);
            }
        }

        return $records;
    }

    /**
     * Request AWS to verify DKIM
     */
    public function verifyDkim()
    {
        $this->sesClient->verifyDomainDkim(
            [
                'Domain' => $this->identity->getDomain(),
            ]
        );
    }

    /**
     * Request AWS to enable DKIM
     *
     * @return bool
     */
    public function enableDkim()

    {
        try {
            $this->sesClient->setIdentityDkimEnabled(
                [
                    'DkimEnabled' => true,
                    'Identity' => $this->identity->getIdentity(),
                ]
            );

            return true;
        } catch (\Exception $e) {
            return false;
        }
    }

    /**
     * Request AWS To disable DKIM
     *
     * @return bool
     */
    public function disableDkim()

    {
        try {
            $this->sesClient->setIdentityDkimEnabled(
                [
                    'DkimEnabled' => false,
                    'Identity' => $this->identity->getIdentity(),
                ]
            );

            return true;
        } catch (\Exception $e) {
            return false;
        }
    }
}


1			<?php
2
3			namespace PeterNijssen\Ses\Manager;
4
5			use Aws\Ses\SesClient;
6			use PeterNijssen\Ses\Exception\InvalidFetchStatusException;
7			use PeterNijssen\Ses\Model\Dns;
8			use PeterNijssen\Ses\Model\IdentityInterface;
9
10			/**
11			* This service manages AWS SES
12			*/
13			abstract class SesManager
14			{
15			/**
16			* @var SesClient
17			*/
18			protected $sesClient;
19
20			/**
21			* @var IdentityInterface
22			*/
23			protected $identity;
24
25			/**
26			* Constructor
27			*
28			* @param SesClient $sesClient
29			* @param IdentityInterface $identity
30			*/
31	17		public function __construct(SesClient $sesClient, IdentityInterface $identity)
32			{
33	17		$this->sesClient = $sesClient;
34	17		$this->identity = $identity;
35	17		}
36
37			/**
38			* Fetch the current status
39			*
40			* @return string
41			*
42			* @throws InvalidFetchStatusException
43			*/
44	2	View Code Duplication	public function fetchStatus()
			0 ignored issues – show Duplication introduced 2016-02-03 21:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46	2		$result = $this->sesClient->getIdentityVerificationAttributes(
47			[
48	2		'Identities' => [$this->identity->getIdentity()],
49			]
50	2		);
51
52	2		$status = $result->search("VerificationAttributes.*.VerificationStatus");
53
54	2		if (!is_array($status)) {
55			throw new InvalidFetchStatusException("unable to fetch the status. Did you create the identity?");
56			}
57
58	2		return current($status);
59			}
60
61			/**
62			* Fetch the current DKIM status
63			*
64			* @return string
65			*
66			* @throws InvalidFetchStatusException
67			*/
68	2	View Code Duplication	public function fetchDkimStatus()
			0 ignored issues – show Duplication introduced 2016-02-03 21:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69			{
70	2		$result = $this->sesClient->getIdentityDkimAttributes(
71			[
72	2		'Identities' => [$this->identity->getIdentity()],
73			]
74	2		);
75
76	2		$status = $result->search("DkimAttributes.*.DkimVerificationStatus");
77
78	2		if (!is_array($status)) {
79			throw new InvalidFetchStatusException("unable to fetch the DKIM status. Did you create the identity?");
80			}
81
82	2		return current($status);
83			}
84
85			/**
86			* Return the DNS records for the DKIM settings
87			*
88			* @return array
89			*/
90	2		public function fetchDkimRecords()
91			{
92	2		$result = $this->sesClient->getIdentityDkimAttributes(
93			[
94	2		'Identities' => [$this->identity->getIdentity()],
95			]
96	2		);
97
98	2		$records = [];
99	2		$results = $result->search("DkimAttributes.*.DkimTokens");
100	2		if (is_array($results)) {
101	2		foreach (current($results) as $result) {
102	2		$name = $result."._domainkey.".$this->identity->getDomain();
103	2		$value = $result.".dkim.amazonses.com";
104
105	2		$records[] = new Dns("CNAME", $name, $value);
106	2		}
107	2		}
108
109	2		return $records;
110			}
111
112			/**
113			* Request AWS to verify DKIM
114			*/
115	2		public function verifyDkim()
116			{
117	2		$this->sesClient->verifyDomainDkim(
118			[
119	2		'Domain' => $this->identity->getDomain(),
120			]
121	2		);
122	2		}
123
124			/**
125			* Request AWS to enable DKIM
126			*
127			* @return bool
128			*/
129	2	View Code Duplication	public function enableDkim()
			0 ignored issues – show Duplication introduced 2016-02-03 21:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130			{
131			try {
132	2		$this->sesClient->setIdentityDkimEnabled(
133			[
134	2		'DkimEnabled' => true,
135	2		'Identity' => $this->identity->getIdentity(),
136			]
137	2		);
138
139	2		return true;
140			} catch (\Exception $e) {
141			return false;
142			}
143			}
144
145			/**
146			* Request AWS To disable DKIM
147			*
148			* @return bool
149			*/
150	2	View Code Duplication	public function disableDkim()
			0 ignored issues – show Duplication introduced 2016-02-03 21:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151			{
152			try {
153	2		$this->sesClient->setIdentityDkimEnabled(
154			[
155	2		'DkimEnabled' => false,
156	2		'Identity' => $this->identity->getIdentity(),
157			]
158	2		);
159
160	2		return true;
161			} catch (\Exception $e) {
162			return false;
163			}
164			}
165			}
166

peternijssen / ses-configuration

Issues (4)

Security Analysis no request data

src/Manager/SesManager.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like