Match - Code Metrics - Inspection of "Explain support for JSON conversion." - petercoles/xml-soccer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 67b740...62de9e )

by Peter

created 2017-02-25 00:37 UTC

Match A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	19
c	1
b	0
f	0
lcom	1
cbo	0
dl	0
loc	149
rs	10

8 Methods

Rating	Name	Size	Complexity
A	handle()	11	2
C	processAtrribute()	27	7
A	players()	4	1
A	goals()	17	2
A	cards()	5	1
A	substitutions()	9	3
A	toArray()	6	2
A	cleanse()	4	1

<?php

namespace PeterColes\XmlSoccer\Converters\Json;

class Match
{
    const PLAYERS = [
        'HomeLineupGoalkeeper',
        'HomeLineupDefense',
        'HomeLineupMidfield',
        'HomeLineupForward',
        'HomeLineupSubstitutes',
        'AwayLineupGoalkeeper',
        'AwayLineupDefense',
        'AwayLineupMidfield',
        'AwayLineupForward',
        'AwayLineupSubstitutes'
    ];

    const GOAL_DETAILS = [
        'HomeGoalDetails',
        'AwayGoalDetails'
    ];

    const CARDS = [
        'HomeTeamYellowCardDetails',
        'HomeTeamRedCardDetails',
        'AwayTeamYellowCardDetails',
        'AwayTeamRedCardDetails'
    ];

    const SUBSTITUTIONS = [
        'HomeSubDetails',
        'AwaySubDetails'
    ];

    const NUMERIC = [
        'Id',
        'FixtureMatch_Id',
        'Round',
        'Spectators',
        'HomeTeam_Id',
        'HomeGoals',
        'HalfTimeHomeGoals',
        'HomeShots',
        'HomeShotsOnTarget',
        'HomeFouls',
        'HomeYellowCards',
        'HomeRedCards',
        'AwayTeam_Id',
        'AwayGoals',
        'HalfTimeAwayGoals',
        'AwayShots',
        'AwayShotsOnTarget',
        'AwayFouls',
        'AwayYellowCards',
        'AwayRedCards'
    ];

    public function handle($match)
    {
        $object = [];

        foreach ($match as $child) {
            $name = $child->getName();
            $object[ $name ] = $this->processAtrribute($name, $child);
        }

        return $object;
    }

    protected function processAtrribute($name, $data)
    {
        if (in_array($name, self::PLAYERS)) {
            return $this->players($data);
        }

        if (in_array($name, self::GOAL_DETAILS)) {
            return array_map([$this, 'goals'], $this->toArray($data));
        }

        if (in_array($name, self::CARDS)) {
            return array_map([$this, 'cards'], $this->toArray($data));
        }

        if (in_array($name, self::SUBSTITUTIONS)) {
            return array_map([$this, 'substitutions'], $this->toArray($data));        }

        if (in_array($name, self::NUMERIC)) {
            return (int) $data;
        }

        if ($name == 'HasBeenRescheduled') {
            return (boolean) $data;
        }

        return $match[$name] = (string) $data;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    }

    protected function players($data)
    {
        return array_map('ltrim', $this->toArray($data));
    }

    protected function goals($goal)
    {
        list($minute, $player) = explode("':", $goal);
        if (substr($player, 0, 3) == 'Own') {
            return [
                'Minute' => (int) $minute,
                'Player' => ltrim(str_replace('Own', '', $player)),
                'Own' => true
            ];
        } else {
            return [
                'Minute' => (int) $minute,
                'Player' => ltrim($player),
                'Own' => false
            ];
        }
    }

    protected function cards($card)
    {
        list($minute, $player) = explode("': ", $card);
        return [ 'Minute' => (int) $minute, 'Player' => $player ];
    }

    protected function substitutions($substitution)
    {
        list($minute, $player) = explode("': ", $substitution);
        if (strpos($player, 'in ') === 0) {
            return [ 'Minute' => (int) $minute, 'Type' => 'In', 'Player' => substr($player, 3) ];
        } elseif (strpos($player, 'out ') === 0) {
            return [ 'Minute' => (int) $minute, 'Type' => 'Out', 'Player' => substr($player, 4) ];
        }
    }

    protected function toArray($data)
    {
        $data = $this->cleanse($data);

        return empty($data) ? [] : explode(';', rtrim($data,";"));
    }

    /**
     * Very occasionally the data has spurious hard spaces that need to be removed
     */
    protected function cleanse($data)
    {
        return str_replace('&nbsp;', '', $data);
    }
}


1			<?php
2
3			namespace PeterColes\XmlSoccer\Converters\Json;
4
5			class Match
6			{
7			const PLAYERS = [
8			'HomeLineupGoalkeeper',
9			'HomeLineupDefense',
10			'HomeLineupMidfield',
11			'HomeLineupForward',
12			'HomeLineupSubstitutes',
13			'AwayLineupGoalkeeper',
14			'AwayLineupDefense',
15			'AwayLineupMidfield',
16			'AwayLineupForward',
17			'AwayLineupSubstitutes'
18			];
19
20			const GOAL_DETAILS = [
21			'HomeGoalDetails',
22			'AwayGoalDetails'
23			];
24
25			const CARDS = [
26			'HomeTeamYellowCardDetails',
27			'HomeTeamRedCardDetails',
28			'AwayTeamYellowCardDetails',
29			'AwayTeamRedCardDetails'
30			];
31
32			const SUBSTITUTIONS = [
33			'HomeSubDetails',
34			'AwaySubDetails'
35			];
36
37			const NUMERIC = [
38			'Id',
39			'FixtureMatch_Id',
40			'Round',
41			'Spectators',
42			'HomeTeam_Id',
43			'HomeGoals',
44			'HalfTimeHomeGoals',
45			'HomeShots',
46			'HomeShotsOnTarget',
47			'HomeFouls',
48			'HomeYellowCards',
49			'HomeRedCards',
50			'AwayTeam_Id',
51			'AwayGoals',
52			'HalfTimeAwayGoals',
53			'AwayShots',
54			'AwayShotsOnTarget',
55			'AwayFouls',
56			'AwayYellowCards',
57			'AwayRedCards'
58			];
59
60			public function handle($match)
61			{
62			$object = [];
63
64			foreach ($match as $child) {
65			$name = $child->getName();
66			$object[ $name ] = $this->processAtrribute($name, $child);
67			}
68
69			return $object;
70			}
71
72			protected function processAtrribute($name, $data)
73			{
74			if (in_array($name, self::PLAYERS)) {
75			return $this->players($data);
76			}
77
78			if (in_array($name, self::GOAL_DETAILS)) {
79			return array_map([$this, 'goals'], $this->toArray($data));
80			}
81
82			if (in_array($name, self::CARDS)) {
83			return array_map([$this, 'cards'], $this->toArray($data));
84			}
85
86			if (in_array($name, self::SUBSTITUTIONS)) {
87			return array_map([$this, 'substitutions'], $this->toArray($data)); }
88
89			if (in_array($name, self::NUMERIC)) {
90			return (int) $data;
91			}
92
93			if ($name == 'HasBeenRescheduled') {
94			return (boolean) $data;
95			}
96
97			return $match[$name] = (string) $data;
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-25 00:41 UTC by Report Bug Copy Issue Report `$match` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$match = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
98			}
99
100			protected function players($data)
101			{
102			return array_map('ltrim', $this->toArray($data));
103			}
104
105			protected function goals($goal)
106			{
107			list($minute, $player) = explode("':", $goal);
108			if (substr($player, 0, 3) == 'Own') {
109			return [
110			'Minute' => (int) $minute,
111			'Player' => ltrim(str_replace('Own', '', $player)),
112			'Own' => true
113			];
114			} else {
115			return [
116			'Minute' => (int) $minute,
117			'Player' => ltrim($player),
118			'Own' => false
119			];
120			}
121			}
122
123			protected function cards($card)
124			{
125			list($minute, $player) = explode("': ", $card);
126			return [ 'Minute' => (int) $minute, 'Player' => $player ];
127			}
128
129			protected function substitutions($substitution)
130			{
131			list($minute, $player) = explode("': ", $substitution);
132			if (strpos($player, 'in ') === 0) {
133			return [ 'Minute' => (int) $minute, 'Type' => 'In', 'Player' => substr($player, 3) ];
134			} elseif (strpos($player, 'out ') === 0) {
135			return [ 'Minute' => (int) $minute, 'Type' => 'Out', 'Player' => substr($player, 4) ];
136			}
137			}
138
139			protected function toArray($data)
140			{
141			$data = $this->cleanse($data);
142
143			return empty($data) ? [] : explode(';', rtrim($data,";"));
144			}
145
146			/**
147			* Very occasionally the data has spurious hard spaces that need to be removed
148			*/
149			protected function cleanse($data)
150			{
151			return str_replace(' ', '', $data);
152			}
153			}
154

petercoles / xml-soccer

Push — master ( 67b740...62de9e )

Match A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like