petercoles / Betfair-Exchange

src/Api/Betting.php

<?php

namespace PeterColes\Betfair\Api;

use PeterColes\Betfair\Api\BaseApi;

class Betting extends BaseApi
{
    /**
     * Betfair API endpoint for betting subsystem requests
     */
    const ENDPOINT = 'https://api.betfair.com/exchange/betting/rest/v1.0/';

    /**
     * Prepare parameters for API requests, ensuring the mandatory requirments are satisfied
     *
     * @param array $params
     */
    public function prepare($params)
    {
        $this->params = !empty($params) ? $params[ 0 ] : [ ];

        // force mandatory fields
        $this->filter();
        $this->maxRecords();
    }

    /**
     * Ensure that a filter parameter is passed where mandatory
     */
    protected filter()

This code did not parse for me. Apparently, there is an error somewhere around this line:

Syntax error, unexpected T_STRING, expecting T_FUNCTION

    {
        $lists = [

The visibility should be declared for property $lists.

            'listCompetitions',
            'listCountries',
            'listEvents',
            'listEventTypes',
            'listMarketTypes',
            'listVenues',
            'listMarketCatalogue'
        ];

        if (in_array($this->method, $lists) && empty($this->params[ 'filter' ])) {

It is generally advisable to only define one property per statement.

The visibility should be declared for property $this.

            $this->params['filter'] = new \stdClass;
        }
    }

    /**
     * Ensure that a maxRecord parameter is passed where mandatory
     */
    protected maxRecords()
    {
        if ($this->method == 'listMarketCatalogue' && empty($this->params[ 'maxResults' ])) {

It is generally advisable to only define one property per statement.

The visibility should be declared for property $this.

            $this->params[ 'maxResults' ] = 1000;
        }
    }
}