Issues in Pagination.php (master) - Issues in master - peteraba/FooGrid - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Pagination/Pagination.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types = 1);

namespace Foo\Grid\Pagination;

use Foo\Grid\Action\Button;
use Foo\Grid\Collection\Actions;
use Foo\Grid\Component\Component;

class Pagination extends Component implements IPagination
{
    /** @var int */
    protected $from = 0;

    /** @var int */
    protected $to = 0;

    /** @var int */
    protected $pageSize = 0;

    /** @var int */
    protected $totalCount = 0;

    /** @var int */
    protected $numberCount = 5;

    /** @var array */
    protected $pageSizes = [10, 50, 200];

    /** @var array */
    protected $attributes = ['class' => 'hello'];

    /** @var Actions */
    protected $buttons;

    /**
     * @param int   $from
     * @param int   $pageSize
     * @param int   $totalCount
     * @param int   $maxNumButtons
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $pageSizes
     * @param array $attributes
     */
    public function __construct(
        $from,
        $pageSize,
        $totalCount,
        $numberCount = 5,
        $pageSizes = [10, 50, 200],
        $attributes = []
    ) {
        $this->from        = $from;
        $this->pageSize    = $pageSize;
        $this->totalCount  = $totalCount;
        $this->pageSizes   = $pageSizes;
        $this->numberCount = $numberCount;

        $this->to      = min($this->totalCount, $this->from + $this->pageSize - 1);
        $this->buttons = new Actions();

        parent::__construct('', 'div', $attributes);

        $this->appendToAttribute(Component::ATTRIBUTE_CLASS, 'grid-pagination');
    }

    /**
     * @return int
     */
    public function getTo(): int
    {
        return min($this->totalCount, $this->from + $this->pageSize - 1);
    }

    /**
     * @return int
     */
    public function getMinPageNumber(): int
    {
        $currentPage = (int)floor($this->from / $this->pageSize);
        $minPage     = (int)($currentPage - floor($this->numberCount / 2));
        $result      = (int)max($minPage, 0) + 1;

        return $result;
    }

    /**
     * @return int
     */
    public function getMaxPageNumber(): int
    {
        $currentPage = (int)floor($this->from / $this->pageSize);
        $maxPage     = (int)($currentPage + floor($this->numberCount / 2) + 1);
        $result      = (int)min($maxPage, floor($this->totalCount / $this->pageSize));

        return $result;
    }

    /**
     * @return array
     */
    public function getPageNumbers(): array
    {
        $minPageNumber = $this->getMinPageNumber();
        $maxPageNumber = $this->getMaxPageNumber();

        $numbers = [];
        for ($i = 0; ($i < $this->numberCount) && ($minPageNumber + $i <= $maxPageNumber); $i++) {
            $numbers[] = $minPageNumber + $i;
        }

        return $numbers;
    }

    public function createButtons()
    {
        $numbers = $this->getPageNumbers();

        $lastIndex = count($numbers) - 1;

        if ($this->from < 1) {
            $this->buttons[] = new Button('<<');
            $this->buttons[] = new Button('<');
        }

        if ($numbers[0] > 1) {
            $this->buttons[] = new Button('...');
        }

        foreach ($numbers as $number) {
            $this->buttons[] = new Button("$number");
        }

        if ($numbers[$lastIndex] * $this->pageSize < $this->totalCount) {
            $this->buttons[] = new Button('...');
        }

        if ($this->to < $this->totalCount) {
            $this->buttons[] = new Button('>');
            $this->buttons[] = new Button('>>');
        }
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        $this->createButtons();

        $this->content = (string)$this->buttons;

        return parent::__toString();
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Foo\Grid\Pagination;
6
7		use Foo\Grid\Action\Button;
8		use Foo\Grid\Collection\Actions;
9		use Foo\Grid\Component\Component;
10
11		class Pagination extends Component implements IPagination
12		{
13		/** @var int */
14		protected $from = 0;
15
16		/** @var int */
17		protected $to = 0;
18
19		/** @var int */
20		protected $pageSize = 0;
21
22		/** @var int */
23		protected $totalCount = 0;
24
25		/** @var int */
26		protected $numberCount = 5;
27
28		/** @var array */
29		protected $pageSizes = [10, 50, 200];
30
31		/** @var array */
32		protected $attributes = ['class' => 'hello'];
33
34		/** @var Actions */
35		protected $buttons;
36
37		/**
38		* @param int $from
39		* @param int $pageSize
40		* @param int $totalCount
41		* @param int $maxNumButtons
		0 ignored issues – show Bug introduced 2017-04-19 21:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$maxNumButtons`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
42		* @param array $pageSizes
43		* @param array $attributes
44		*/
45	15	public function __construct(
46		$from,
47		$pageSize,
48		$totalCount,
49		$numberCount = 5,
50		$pageSizes = [10, 50, 200],
51		$attributes = []
52		) {
53	15	$this->from = $from;
54	15	$this->pageSize = $pageSize;
55	15	$this->totalCount = $totalCount;
56	15	$this->pageSizes = $pageSizes;
57	15	$this->numberCount = $numberCount;
58
59	15	$this->to = min($this->totalCount, $this->from + $this->pageSize - 1);
60	15	$this->buttons = new Actions();
61
62	15	parent::__construct('', 'div', $attributes);
63
64	15	$this->appendToAttribute(Component::ATTRIBUTE_CLASS, 'grid-pagination');
65	15	}
66
67		/**
68		* @return int
69		*/
70	3	public function getTo(): int
71		{
72	3	return min($this->totalCount, $this->from + $this->pageSize - 1);
73		}
74
75		/**
76		* @return int
77		*/
78	9	public function getMinPageNumber(): int
79		{
80	9	$currentPage = (int)floor($this->from / $this->pageSize);
81	9	$minPage = (int)($currentPage - floor($this->numberCount / 2));
82	9	$result = (int)max($minPage, 0) + 1;
83
84	9	return $result;
85		}
86
87		/**
88		* @return int
89		*/
90	9	public function getMaxPageNumber(): int
91		{
92	9	$currentPage = (int)floor($this->from / $this->pageSize);
93	9	$maxPage = (int)($currentPage + floor($this->numberCount / 2) + 1);
94	9	$result = (int)min($maxPage, floor($this->totalCount / $this->pageSize));
95
96	9	return $result;
97		}
98
99		/**
100		* @return array
101		*/
102	6	public function getPageNumbers(): array
103		{
104	6	$minPageNumber = $this->getMinPageNumber();
105	6	$maxPageNumber = $this->getMaxPageNumber();
106
107	6	$numbers = [];
108	6	for ($i = 0; ($i < $this->numberCount) && ($minPageNumber + $i <= $maxPageNumber); $i++) {
109	6	$numbers[] = $minPageNumber + $i;
110		}
111
112	6	return $numbers;
113		}
114
115	3	public function createButtons()
116		{
117	3	$numbers = $this->getPageNumbers();
118
119	3	$lastIndex = count($numbers) - 1;
120
121	3	if ($this->from < 1) {
122		$this->buttons[] = new Button('<<');
123		$this->buttons[] = new Button('<');
124		}
125
126	3	if ($numbers[0] > 1) {
127	2	$this->buttons[] = new Button('...');
128		}
129
130	3	foreach ($numbers as $number) {
131	3	$this->buttons[] = new Button("$number");
132		}
133
134	3	if ($numbers[$lastIndex] * $this->pageSize < $this->totalCount) {
135	2	$this->buttons[] = new Button('...');
136		}
137
138	3	if ($this->to < $this->totalCount) {
139	2	$this->buttons[] = new Button('>');
140	2	$this->buttons[] = new Button('>>');
141		}
142	3	}
143
144		/**
145		* @return string
146		*/
147	3	public function __toString(): string
148		{
149	3	$this->createButtons();
150
151	3	$this->content = (string)$this->buttons;
152
153	3	return parent::__toString();
154		}
155		}
156

peteraba / FooGrid

Issues (12)

Security Analysis no request data

src/Pagination/Pagination.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like