Personnage\Tinkoff\SDK\E2Card\Client

Complexity

Total Complexity

9

Size/Duplication

Total Lines	119
Duplicated Lines	18.49 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getPemFile()	0	4	1
A	init()	8	8	1
A	payment()	0	4	1
A	payout()	14	14	4
A	makeRequest()	0	10	1

<?php declare(strict_types=1);

namespace Personnage\Tinkoff\SDK\E2Card;

use GuzzleHttp\Psr7\Request;
use Personnage\Tinkoff\SDK\Exception\HttpException;
use Personnage\Tinkoff\SDK\Exception\ResponseException;
use Personnage\Tinkoff\SDK\HasSender;
use Personnage\Tinkoff\SDK\Response\Init;
use Personnage\Tinkoff\SDK\Response\Payment;
use Personnage\Tinkoff\SDK\Sender;
use Psr\Http\Message\RequestInterface;

final class Client
{
    use HasSignature, HasSender;

    private $baseUri;
    private $terminalKey;
    private $pemFile;

    /**
     * @var array
     */
    private static $requestHeaders = [
        'Accept' => 'application/json',
        'Content-Type' => 'application/x-www-form-urlencoded',
    ];

    /**
     * Init a new instance.
     *
     * @param string $uri
     * @param string $terminalKey
     * @param string $pemFile
     * @param Sender $sender
     */
    public function __construct($uri, $terminalKey, $pemFile, Sender $sender)
    {
        $this->baseUri = rtrim($uri, '/');
        $this->terminalKey = $terminalKey;
        $this->pemFile = realpath($pemFile);
        $this->setSender($sender);
    }

    /**
     * {@inheritdoc}
     */
    public function getPemFile()
    {
        return $this->pemFile;
    }

    /**
     * Init a new payment session.
     *
     * @param string $orderId Номер заказа в системе Продавца.
     * @param string $cardId  Идентификатор карты пополнения.
     * @param int    $amount  Сумма в копейках.
     * @param array  $extra   Массив дополнительных полей, которые могут быть переданы в этом запросе.
     *
     * @return Init
     * @throws HttpException
     */
    public function init(string $orderId, string $cardId, int $amount, array $extra = []): Init

This method seems to be duplicated in your project.

    {
        $extra['Amount'] = $amount;
        $extra['CardId'] = $cardId;
        $extra['OrderId'] = $orderId;

        return new Init($this->send($this->makeRequest('Init', $extra)));
    }

    /**
     * Make payout to card.
     *
     * @param mixed $paymentId
     *
     * @return Payment
     * @throws HttpException
     */
    public function payment($paymentId): Payment
    {
        return new Payment($this->send($this->makeRequest('Payment', ['PaymentId' => $paymentId])));
    }

    /**
     * Init a new payment session and make payout to card.
     *
     * @param string $orderId Номер заказа в системе Продавца.
     * @param string $cardId  Идентификатор карты пополнения.
     * @param int    $amount  Сумма в копейках.
     * @param array  $extra   Массив дополнительных полей, которые могут быть переданы в этом запросе.
     *
     * @return Payment
     * @throws HttpException
     * @throws ResponseException
     */
    public function payout(string $orderId, string $cardId, int $amount, array $extra = []): Payment

This method seems to be duplicated in your project.

    {
        $response = $this->init($orderId, $cardId, $amount, $extra);
        if ($response->hasError() || 'CHECKED' !== $response->getStatus()) {
            throw new ResponseException($response);
        }

        $response = $this->payment($response->getPaymentId());
        if ($response->hasError()) {
            throw new ResponseException($response);
        }

        return $response;
    }

    /**
     * Make a new http request.
     *
     * @param string $uri
     * @param array  $body
     *
     * @return RequestInterface
     */
    private function makeRequest(string $uri, array $body = []): RequestInterface
    {
        $body['TerminalKey'] = $this->terminalKey;

        $body['DigestValue'] = base64_encode($this->digest($body));
        $body['SignatureValue'] = base64_encode($this->sign($body));
        $body['X509SerialNumber'] = $this->getSerialNumber($this->pemFile);

The call to Client::getSerialNumber() has too many arguments starting with $this->pemFile.

        return new Request('post', "$this->baseUri/$uri", self::$requestHeaders, http_build_query($body, '', '&'));
    }
}