Issues in RouteProvider.php (master) - Issues in master - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ServiceProvider/RouteProvider.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace XHGui\ServiceProvider;

use Exception;
use Pimple\Container;
use Pimple\ServiceProviderInterface;
use Slim\Slim as App;
use Slim\Views\Twig;
use XHGui\Controller;
use XHGui\Twig\TwigExtension;

class RouteProvider implements ServiceProviderInterface
{
    public function register(Container $di): void
    {
        $this->registerRoutes($di, $di['app']);
        $this->registerControllers($di);
    }

    private function registerRoutes(Container $di, App $app): void
    {
        $app->error(static function (Exception $e) use ($di, $app): void {
            /** @var Twig $view */
            $view = $di['view'];
            $view->parserOptions['cache'] = false;
            $view->parserExtensions = [

                new TwigExtension($app),
            ];

            $app->view($view);
            $app->render('error/view.twig', [
                'message' => $e->getMessage(),
                'stack_trace' => $e->getTraceAsString(),
            ]);
        });

        // Profile Runs routes
        $app->get('/', static function () use ($di, $app): void {

            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->index($request, $response);
        })->setName('home');

        $app->get('/run/view', static function () use ($di, $app): void {

            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->view($request, $response);
        })->setName('run.view');

        $app->get('/run/delete', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->deleteForm($request);
        })->setName('run.delete.form');

        $app->post('/run/delete', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->deleteSubmit($request);
        })->setName('run.delete.submit');

        $app->get('/run/delete_all', static function () use ($di): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $controller->deleteAllForm();
        })->setName('run.deleteAll.form');

        $app->post('/run/delete_all', static function () use ($di): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $controller->deleteAllSubmit();
        })->setName('run.deleteAll.submit');

        $app->get('/url/view', static function () use ($di, $app): void {

            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->url($request);
        })->setName('url.view');

        $app->get('/run/compare', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->compare($request);
        })->setName('run.compare');

        $app->get('/run/symbol', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->symbol($request);
        })->setName('run.symbol');

        $app->get('/run/symbol/short', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->symbolShort($request);
        })->setName('run.symbol-short');

        $app->get('/run/callgraph', static function () use ($di, $app): void {
            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();

            $controller->callgraph($request);
        })->setName('run.callgraph');

        $app->get('/run/callgraph/data', static function () use ($di, $app): void {

            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->callgraphData($request, $response);
        })->setName('run.callgraph.data');

        $app->get('/run/callgraph/dot', static function () use ($di, $app): void {

            /** @var Controller\RunController $controller */
            $controller = $di[Controller\RunController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->callgraphDataDot($request, $response);
        })->setName('run.callgraph.dot');

        // Import route
        $app->post('/run/import', static function () use ($di, $app): void {

            /** @var Controller\ImportController $controller */
            $controller = $di[Controller\ImportController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->import($request, $response);
        })->setName('run.import');

        // Watch function routes.
        $app->get('/watch', static function () use ($di): void {
            /** @var Controller\WatchController $controller */
            $controller = $di[Controller\WatchController::class];
            $controller->get();
        })->setName('watch.list');

        $app->post('/watch', static function () use ($di, $app): void {

            /** @var Controller\WatchController $controller */
            $controller = $di[Controller\WatchController::class];
            $request = $app->request();

            $controller->post($request);
        })->setName('watch.save');

        // Custom report routes.
        $app->get('/custom', static function () use ($di): void {
            /** @var Controller\CustomController $controller */
            $controller = $di[Controller\CustomController::class];
            $controller->get();
        })->setName('custom.view');

        $app->get('/custom/help', static function () use ($di, $app): void {

            /** @var Controller\CustomController $controller */
            $controller = $di[Controller\CustomController::class];
            $request = $app->request();

            $controller->help($request);
        })->setName('custom.help');

        $app->post('/custom/query', static function () use ($di, $app): void {

            /** @var Controller\CustomController $controller */
            $controller = $di[Controller\CustomController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->query($request, $response);
        })->setName('custom.query');

        // Waterfall routes
        $app->get('/waterfall', static function () use ($di): void {
            /** @var Controller\WaterfallController $controller */
            $controller = $di[Controller\WaterfallController::class];
            $controller->index();
        })->setName('waterfall.list');

        $app->get('/waterfall/data', static function () use ($di, $app): void {

            /** @var Controller\WaterfallController $controller */
            $controller = $di[Controller\WaterfallController::class];
            $request = $app->request();
            $response = $app->response();

            $controller->query($request, $response);
        })->setName('waterfall.data');

        // Metrics
        $app->get('/metrics', static function () use ($di, $app): void {
            /** @var Controller\MetricsController $controller */
            $controller = $di[Controller\MetricsController::class];
            $response = $app->response();

            $controller->metrics($response);
        })->setName('metrics');
    }

    private function registerControllers(Container $app): void
    {
        $app[Controller\WatchController::class] = $app->factory(static function ($app) {
            return new Controller\WatchController($app['app'], $app['searcher']);
        });

        $app[Controller\RunController::class] = $app->factory(static function ($app) {
            return new Controller\RunController($app['app'], $app['searcher']);
        });

        $app[Controller\CustomController::class] = $app->factory(static function ($app) {
            return new Controller\CustomController($app['app'], $app['searcher']);
        });

        $app[Controller\WaterfallController::class] = $app->factory(static function ($app) {
            return new Controller\WaterfallController($app['app'], $app['searcher']);
        });

        $app[Controller\ImportController::class] = $app->factory(static function ($app) {
            return new Controller\ImportController($app['app'], $app['saver'], $app['config']['upload.token']);
        });

        $app[Controller\MetricsController::class] = $app->factory(static function ($app) {
            return new Controller\MetricsController($app['app'], $app['searcher']);
        });
    }
}


1		<?php
2
3		namespace XHGui\ServiceProvider;
4
5		use Exception;
6		use Pimple\Container;
7		use Pimple\ServiceProviderInterface;
8		use Slim\Slim as App;
9		use Slim\Views\Twig;
10		use XHGui\Controller;
11		use XHGui\Twig\TwigExtension;
12
13		class RouteProvider implements ServiceProviderInterface
14		{
15		public function register(Container $di): void
16		{
17		$this->registerRoutes($di, $di['app']);
18		$this->registerControllers($di);
19		}
20
21		private function registerRoutes(Container $di, App $app): void
22		{
23		$app->error(static function (Exception $e) use ($di, $app): void {
24		/** @var Twig $view */
25		$view = $di['view'];
26		$view->parserOptions['cache'] = false;
27		$view->parserExtensions = [
		0 ignored issues – show Documentation Bug introduced 2020-12-21 17:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array(new \XHGui\Twig\TwigExtension($app))` of type `array<integer,object<XHG...Twig\\TwigExtension>"}>` is incompatible with the declared type `object<Slim\Views\TwigExtension>` of property `$parserExtensions`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
28		new TwigExtension($app),
29		];
30
31		$app->view($view);
32		$app->render('error/view.twig', [
33		'message' => $e->getMessage(),
34		'stack_trace' => $e->getTraceAsString(),
35		]);
36		});
37
38		// Profile Runs routes
39	View Code Duplication	$app->get('/', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-12-22 22:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		/** @var Controller\RunController $controller */
41		$controller = $di[Controller\RunController::class];
42		$request = $app->request();
43		$response = $app->response();
44
45		$controller->index($request, $response);
46		})->setName('home');
47
48	View Code Duplication	$app->get('/run/view', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		/** @var Controller\RunController $controller */
50		$controller = $di[Controller\RunController::class];
51		$request = $app->request();
52		$response = $app->response();
53
54		$controller->view($request, $response);
55		})->setName('run.view');
56
57		$app->get('/run/delete', static function () use ($di, $app): void {
58		/** @var Controller\RunController $controller */
59		$controller = $di[Controller\RunController::class];
60		$request = $app->request();
61
62		$controller->deleteForm($request);
63		})->setName('run.delete.form');
64
65		$app->post('/run/delete', static function () use ($di, $app): void {
66		/** @var Controller\RunController $controller */
67		$controller = $di[Controller\RunController::class];
68		$request = $app->request();
69
70		$controller->deleteSubmit($request);
71		})->setName('run.delete.submit');
72
73		$app->get('/run/delete_all', static function () use ($di): void {
74		/** @var Controller\RunController $controller */
75		$controller = $di[Controller\RunController::class];
76		$controller->deleteAllForm();
77		})->setName('run.deleteAll.form');
78
79		$app->post('/run/delete_all', static function () use ($di): void {
80		/** @var Controller\RunController $controller */
81		$controller = $di[Controller\RunController::class];
82		$controller->deleteAllSubmit();
83		})->setName('run.deleteAll.submit');
84
85	View Code Duplication	$app->get('/url/view', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		/** @var Controller\RunController $controller */
87		$controller = $di[Controller\RunController::class];
88		$request = $app->request();
89
90		$controller->url($request);
91		})->setName('url.view');
92
93		$app->get('/run/compare', static function () use ($di, $app): void {
94		/** @var Controller\RunController $controller */
95		$controller = $di[Controller\RunController::class];
96		$request = $app->request();
97
98		$controller->compare($request);
99		})->setName('run.compare');
100
101		$app->get('/run/symbol', static function () use ($di, $app): void {
102		/** @var Controller\RunController $controller */
103		$controller = $di[Controller\RunController::class];
104		$request = $app->request();
105
106		$controller->symbol($request);
107		})->setName('run.symbol');
108
109		$app->get('/run/symbol/short', static function () use ($di, $app): void {
110		/** @var Controller\RunController $controller */
111		$controller = $di[Controller\RunController::class];
112		$request = $app->request();
113
114		$controller->symbolShort($request);
115		})->setName('run.symbol-short');
116
117		$app->get('/run/callgraph', static function () use ($di, $app): void {
118		/** @var Controller\RunController $controller */
119		$controller = $di[Controller\RunController::class];
120		$request = $app->request();
121
122		$controller->callgraph($request);
123		})->setName('run.callgraph');
124
125	View Code Duplication	$app->get('/run/callgraph/data', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		/** @var Controller\RunController $controller */
127		$controller = $di[Controller\RunController::class];
128		$request = $app->request();
129		$response = $app->response();
130
131		$controller->callgraphData($request, $response);
132		})->setName('run.callgraph.data');
133
134	View Code Duplication	$app->get('/run/callgraph/dot', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
135		/** @var Controller\RunController $controller */
136		$controller = $di[Controller\RunController::class];
137		$request = $app->request();
138		$response = $app->response();
139
140		$controller->callgraphDataDot($request, $response);
141		})->setName('run.callgraph.dot');
142
143		// Import route
144	View Code Duplication	$app->post('/run/import', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-12-23 15:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
145		/** @var Controller\ImportController $controller */
146		$controller = $di[Controller\ImportController::class];
147		$request = $app->request();
148		$response = $app->response();
149
150		$controller->import($request, $response);
151		})->setName('run.import');
152
153		// Watch function routes.
154		$app->get('/watch', static function () use ($di): void {
155		/** @var Controller\WatchController $controller */
156		$controller = $di[Controller\WatchController::class];
157		$controller->get();
158		})->setName('watch.list');
159
160	View Code Duplication	$app->post('/watch', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-12-23 15:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
161		/** @var Controller\WatchController $controller */
162		$controller = $di[Controller\WatchController::class];
163		$request = $app->request();
164
165		$controller->post($request);
166		})->setName('watch.save');
167
168		// Custom report routes.
169		$app->get('/custom', static function () use ($di): void {
170		/** @var Controller\CustomController $controller */
171		$controller = $di[Controller\CustomController::class];
172		$controller->get();
173		})->setName('custom.view');
174
175	View Code Duplication	$app->get('/custom/help', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-12-23 15:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		/** @var Controller\CustomController $controller */
177		$controller = $di[Controller\CustomController::class];
178		$request = $app->request();
179
180		$controller->help($request);
181		})->setName('custom.help');
182
183	View Code Duplication	$app->post('/custom/query', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
184		/** @var Controller\CustomController $controller */
185		$controller = $di[Controller\CustomController::class];
186		$request = $app->request();
187		$response = $app->response();
188
189		$controller->query($request, $response);
190		})->setName('custom.query');
191
192		// Waterfall routes
193		$app->get('/waterfall', static function () use ($di): void {
194		/** @var Controller\WaterfallController $controller */
195		$controller = $di[Controller\WaterfallController::class];
196		$controller->index();
197		})->setName('waterfall.list');
198
199	View Code Duplication	$app->get('/waterfall/data', static function () use ($di, $app): void {
		0 ignored issues – show Duplication introduced 2020-10-08 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
200		/** @var Controller\WaterfallController $controller */
201		$controller = $di[Controller\WaterfallController::class];
202		$request = $app->request();
203		$response = $app->response();
204
205		$controller->query($request, $response);
206		})->setName('waterfall.data');
207
208		// Metrics
209		$app->get('/metrics', static function () use ($di, $app): void {
210		/** @var Controller\MetricsController $controller */
211		$controller = $di[Controller\MetricsController::class];
212		$response = $app->response();
213
214		$controller->metrics($response);
215		})->setName('metrics');
216		}
217
218		private function registerControllers(Container $app): void
219		{
220		$app[Controller\WatchController::class] = $app->factory(static function ($app) {
221		return new Controller\WatchController($app['app'], $app['searcher']);
222		});
223
224		$app[Controller\RunController::class] = $app->factory(static function ($app) {
225		return new Controller\RunController($app['app'], $app['searcher']);
226		});
227
228		$app[Controller\CustomController::class] = $app->factory(static function ($app) {
229		return new Controller\CustomController($app['app'], $app['searcher']);
230		});
231
232		$app[Controller\WaterfallController::class] = $app->factory(static function ($app) {
233		return new Controller\WaterfallController($app['app'], $app['searcher']);
234		});
235
236		$app[Controller\ImportController::class] = $app->factory(static function ($app) {
237		return new Controller\ImportController($app['app'], $app['saver'], $app['config']['upload.token']);
238		});
239
240		$app[Controller\MetricsController::class] = $app->factory(static function ($app) {
241		return new Controller\MetricsController($app['app'], $app['searcher']);
242		});
243		}
244		}
245

perftools / xhgui

Issues (41)

Security Analysis no request data

src/ServiceProvider/RouteProvider.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like