Issues in MongoSearcher.php (master) - Issues in master - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Searcher/MongoSearcher.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace XHGui\Searcher;

use Exception;
use MongoCursor;
use MongoDate;
use MongoDb;
use MongoId;
use XHGui\Db\Mapper;
use XHGui\Options\SearchOptions;
use XHGui\Profile;

/**
 * A Searcher for a MongoDB backend.
 */
class MongoSearcher implements SearcherInterface
{
    protected $_collection;

    protected $_watches;

    protected $_mapper;

    public function __construct(MongoDb $db)
    {
        $this->_collection = $db->results;

        $this->_watches = $db->watches;

        $this->_mapper = new Mapper();
    }

    /**
     * {@inheritdoc}
     */
    public function latest()
    {
        $cursor = $this->_collection->find()
            ->sort(['meta.request_date' => -1])
            ->limit(1);
        $result = $cursor->getNext();

        return $this->_wrap($result);

    }

    /**
     * {@inheritdoc}
     */
    public function query($conditions, $limit, $fields = [])
    {
        $result = $this->_collection->find($conditions, $fields)
            ->limit($limit);

        return iterator_to_array($result);
    }

    /**
     * {@inheritdoc}
     */
    public function get($id)
    {
        return $this->_wrap($this->_collection->findOne([

            '_id' => new MongoId($id),
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function getForUrl($url, $options, $conditions = [])
    {
        $conditions = array_merge(
            (array)$conditions,
            ['simple_url' => $url]
        );
        $options = array_merge($options, [
            'conditions' => $conditions,
        ]);

        return $this->paginate($options);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function getPercentileForUrl($percentile, $url, $search = [])
    {
        $result = $this->_mapper->convert([
            'conditions' => $search + ['simple_url' => $url],
        ]);
        $match = $result['conditions'];

        $col = '$meta.request_date';
        if (!empty($search['limit']) && $search['limit'][0] === 'P') {

            $col = '$meta.request_ts';
        }

        $pipeline = [
            ['$match' => $match],
            [
                '$project' => [
                    'date' => $col,
                    'profile.main()' => 1,
                ],
            ],
            [
                '$group' => [
                    '_id' => '$date',
                    'row_count' => ['$sum' => 1],
                    'wall_times' => ['$push' => '$profile.main().wt'],
                    'cpu_times' => ['$push' => '$profile.main().cpu'],
                    'mu_times' => ['$push' => '$profile.main().mu'],
                    'pmu_times' => ['$push' => '$profile.main().pmu'],
                ],
            ],
            [
                '$project' => [
                    'date' => '$date',
                    'row_count' => '$row_count',
                    'raw_index' => [
                        '$multiply' => [
                            '$row_count',
                            $percentile / 100,
                        ],
                    ],
                    'wall_times' => '$wall_times',
                    'cpu_times' => '$cpu_times',
                    'mu_times' => '$mu_times',
                    'pmu_times' => '$pmu_times',
                ],
            ],
            ['$sort' => ['_id' => 1]],
        ];

        $results = $this->_collection->aggregate(
            $pipeline,
            ['cursor' => ['batchSize' => 0]]
        );

        if (empty($results['result'])) {
            return [];
        }
        $keys = [
            'wall_times' => 'wt',
            'cpu_times' => 'cpu',
            'mu_times' => 'mu',
            'pmu_times' => 'pmu',
        ];
        foreach ($results['result'] as &$result) {
            $result['date'] = ($result['_id'] instanceof MongoDate) ? date('Y-m-d H:i:s', $result['_id']->sec) : $result['_id'];
            unset($result['_id']);
            $index = max(round($result['raw_index']) - 1, 0);
            foreach ($keys as $key => $out) {
                sort($result[$key]);
                $result[$out] = $result[$key][$index] ?? null;
                unset($result[$key]);
            }
        }

        return $results['result'];
    }

    /**
     * {@inheritdoc}
     */
    public function getAvgsForUrl($url, $search = [])
    {
        $match = ['meta.simple_url' => $url];
        if (isset($search['date_start'])) {
            $match['meta.request_date']['$gte'] = (string)$search['date_start'];
        }
        if (isset($search['date_end'])) {
            $match['meta.request_date']['$lte'] = (string)$search['date_end'];
        }
        $results = $this->_collection->aggregate(
            [
            ['$match' => $match],
            [
                '$project' => [
                    'date' => '$meta.request_date',
                    'profile.main()' => 1,
                ],
            ],
            [
                '$group' => [
                    '_id' => '$date',
                    'avg_wt' => ['$avg' => '$profile.main().wt'],
                    'avg_cpu' => ['$avg' => '$profile.main().cpu'],
                    'avg_mu' => ['$avg' => '$profile.main().mu'],
                    'avg_pmu' => ['$avg' => '$profile.main().pmu'],
                ],
            ],
            ['$sort' => ['_id' => 1]],
        ],
            ['cursor' => ['batchSize' => 0]]
        );
        if (empty($results['result'])) {
            return [];
        }
        foreach ($results['result'] as $i => $result) {
            $results['result'][$i]['date'] = $result['_id'];
            unset($results['result'][$i]['_id']);
        }

        return $results['result'];
    }

    /**
     * {@inheritdoc}
     */
    public function getAll(SearchOptions $options): array
    {
        return $this->paginate($options->toArray());
    }

    /**
     * {@inheritdoc}
     */
    public function delete($id): void
    {
        $this->_collection->remove(['_id' => new MongoId($id)], []);
    }

    public function truncate()
    {
        $this->_collection->remove();

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function saveWatch(array $data): bool
    {
        if (empty($data['name'])) {
            return false;
        }

        if (!empty($data['removed']) && isset($data['_id'])) {
            $this->_watches->remove(
                ['_id' => new MongoId($data['_id'])],
                ['w' => 1]
            );

            return true;
        }

        if (empty($data['_id'])) {
            $this->_watches->insert(
                $data,
                ['w' => 1]
            );

            return true;
        }

        $data['_id'] = new MongoId($data['_id']);
        $this->_watches->update(
            ['_id' => $data['_id']],
            $data,
            ['w' => 1]
        );

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function getAllWatches(): array
    {
        $cursor = $this->_watches->find();

        return array_values(iterator_to_array($cursor));
    }

    public function truncateWatches()
    {
        $this->_watches->remove();

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    private function paginate(array $options): array
    {
        $opts = $this->_mapper->convert($options);

        $totalRows = $this->_collection->find(
            $opts['conditions'],
            ['_id' => 1]
        )->count();

        $totalPages = max(ceil($totalRows / $opts['perPage']), 1);
        $page = 1;
        if (isset($options['page'])) {
            $page = min(max($options['page'], 1), $totalPages);
        }

        $projection = false;
        if (isset($options['projection'])) {
            if ($options['projection'] === true) {
                $projection = ['meta' => 1, 'profile.main()' => 1];
            } else {
                $projection = $options['projection'];
            }
        }

        if ($projection === false) {
            $cursor = $this->_collection->find($opts['conditions'])
                ->sort($opts['sort'])
                ->skip((int)($page - 1) * $opts['perPage'])
                ->limit($opts['perPage']);
        } else {
            $cursor = $this->_collection->find($opts['conditions'], $projection)
                ->sort($opts['sort'])
                ->skip((int)($page - 1) * $opts['perPage'])
                ->limit($opts['perPage']);
        }

        return [
            'results' => $this->_wrap($cursor),
            'sort' => $opts['sort'],
            'direction' => $opts['direction'],
            'page' => $page,
            'perPage' => $opts['perPage'],
            'totalPages' => $totalPages,
        ];
    }

    /**
     * Converts arrays + MongoCursors into Profile instances.
     *
     * @param array|MongoCursor $data the data to transform
     * @return Profile|Profile[] the transformed/wrapped results
     */
    private function _wrap($data)
    {
        if ($data === null) {
            throw new Exception('No profile data found.');
        }

        if (is_array($data)) {
            return new Profile($data);
        }
        $results = [];
        foreach ($data as $row) {
            $results[] = new Profile($row);
        }

        return $results;
    }

    /**
     * {@inheritdoc}
     */
    public function stats(): array
    {
        return [
            'profiles' => 0,
            'latest' => 0,
            'bytes' => 0,
        ];
    }
}


1		<?php
2
3		namespace XHGui\Searcher;
4
5		use Exception;
6		use MongoCursor;
7		use MongoDate;
8		use MongoDb;
9		use MongoId;
10		use XHGui\Db\Mapper;
11		use XHGui\Options\SearchOptions;
12		use XHGui\Profile;
13
14		/**
15		* A Searcher for a MongoDB backend.
16		*/
17		class MongoSearcher implements SearcherInterface
18		{
19		protected $_collection;
20
21		protected $_watches;
22
23		protected $_mapper;
24
25		public function __construct(MongoDb $db)
26		{
27		$this->_collection = $db->results;
		0 ignored issues – show Bug introduced 2016-02-22 04:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `results` does not seem to exist in `MongoDB`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
28		$this->_watches = $db->watches;
		0 ignored issues – show Bug introduced 2018-07-13 19:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `watches` does not seem to exist in `MongoDB`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
29		$this->_mapper = new Mapper();
30		}
31
32		/**
33		* {@inheritdoc}
34		*/
35		public function latest()
36		{
37		$cursor = $this->_collection->find()
38		->sort(['meta.request_date' => -1])
39		->limit(1);
40		$result = $cursor->getNext();
41
42		return $this->_wrap($result);
		0 ignored issues – show Bug Compatibility introduced 2020-09-19 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->_wrap($result);` of type `XHGui\Profile\|array` adds the type `array` to the return on line 42 which is incompatible with the return type declared by the interface `XHGui\Searcher\SearcherInterface::latest` of type `XHGui\Profile`. Loading history...
43		}
44
45		/**
46		* {@inheritdoc}
47		*/
48		public function query($conditions, $limit, $fields = [])
49		{
50		$result = $this->_collection->find($conditions, $fields)
51		->limit($limit);
52
53		return iterator_to_array($result);
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59		public function get($id)
60		{
61		return $this->_wrap($this->_collection->findOne([
		0 ignored issues – show Bug Compatibility introduced 2020-09-19 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->_wrap($this->_col...> new \MongoId($id))));` of type `XHGui\Profile\|array` adds the type `array` to the return on line 61 which is incompatible with the return type declared by the interface `XHGui\Searcher\SearcherInterface::get` of type `XHGui\Profile`. Loading history...
62		'_id' => new MongoId($id),
63		]));
64		}
65
66		/**
67		* {@inheritdoc}
68		*/
69		public function getForUrl($url, $options, $conditions = [])
70		{
71		$conditions = array_merge(
72		(array)$conditions,
73		['simple_url' => $url]
74		);
75		$options = array_merge($options, [
76		'conditions' => $conditions,
77		]);
78
79		return $this->paginate($options);
		0 ignored issues – show Bug Best Practice introduced 2020-09-19 12:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->paginate($options);` (`array`) is incompatible with the return type declared by the interface `XHGui\Searcher\SearcherInterface::getForUrl` of type `MongoCursor`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
80		}
81
82		/**
83		* {@inheritdoc}
84		*/
85		public function getPercentileForUrl($percentile, $url, $search = [])
86		{
87		$result = $this->_mapper->convert([
88		'conditions' => $search + ['simple_url' => $url],
89		]);
90		$match = $result['conditions'];
91
92		$col = '$meta.request_date';
93	View Code Duplication	if (!empty($search['limit']) && $search['limit'][0] === 'P') {
		0 ignored issues – show Duplication introduced 2016-02-22 04:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		$col = '$meta.request_ts';
95		}
96
97		$pipeline = [
98		['$match' => $match],
99		[
100		'$project' => [
101		'date' => $col,
102		'profile.main()' => 1,
103		],
104		],
105		[
106		'$group' => [
107		'_id' => '$date',
108		'row_count' => ['$sum' => 1],
109		'wall_times' => ['$push' => '$profile.main().wt'],
110		'cpu_times' => ['$push' => '$profile.main().cpu'],
111		'mu_times' => ['$push' => '$profile.main().mu'],
112		'pmu_times' => ['$push' => '$profile.main().pmu'],
113		],
114		],
115		[
116		'$project' => [
117		'date' => '$date',
118		'row_count' => '$row_count',
119		'raw_index' => [
120		'$multiply' => [
121		'$row_count',
122		$percentile / 100,
123		],
124		],
125		'wall_times' => '$wall_times',
126		'cpu_times' => '$cpu_times',
127		'mu_times' => '$mu_times',
128		'pmu_times' => '$pmu_times',
129		],
130		],
131		['$sort' => ['_id' => 1]],
132		];
133
134		$results = $this->_collection->aggregate(
135		$pipeline,
136		['cursor' => ['batchSize' => 0]]
137		);
138
139		if (empty($results['result'])) {
140		return [];
141		}
142		$keys = [
143		'wall_times' => 'wt',
144		'cpu_times' => 'cpu',
145		'mu_times' => 'mu',
146		'pmu_times' => 'pmu',
147		];
148		foreach ($results['result'] as &$result) {
149		$result['date'] = ($result['_id'] instanceof MongoDate) ? date('Y-m-d H:i:s', $result['_id']->sec) : $result['_id'];
150		unset($result['_id']);
151		$index = max(round($result['raw_index']) - 1, 0);
152		foreach ($keys as $key => $out) {
153		sort($result[$key]);
154		$result[$out] = $result[$key][$index] ?? null;
155		unset($result[$key]);
156		}
157		}
158
159		return $results['result'];
160		}
161
162		/**
163		* {@inheritdoc}
164		*/
165		public function getAvgsForUrl($url, $search = [])
166		{
167		$match = ['meta.simple_url' => $url];
168		if (isset($search['date_start'])) {
169		$match['meta.request_date']['$gte'] = (string)$search['date_start'];
170		}
171		if (isset($search['date_end'])) {
172		$match['meta.request_date']['$lte'] = (string)$search['date_end'];
173		}
174		$results = $this->_collection->aggregate(
175		[
176		['$match' => $match],
177		[
178		'$project' => [
179		'date' => '$meta.request_date',
180		'profile.main()' => 1,
181		],
182		],
183		[
184		'$group' => [
185		'_id' => '$date',
186		'avg_wt' => ['$avg' => '$profile.main().wt'],
187		'avg_cpu' => ['$avg' => '$profile.main().cpu'],
188		'avg_mu' => ['$avg' => '$profile.main().mu'],
189		'avg_pmu' => ['$avg' => '$profile.main().pmu'],
190		],
191		],
192		['$sort' => ['_id' => 1]],
193		],
194		['cursor' => ['batchSize' => 0]]
195		);
196		if (empty($results['result'])) {
197		return [];
198		}
199		foreach ($results['result'] as $i => $result) {
200		$results['result'][$i]['date'] = $result['_id'];
201		unset($results['result'][$i]['_id']);
202		}
203
204		return $results['result'];
205		}
206
207		/**
208		* {@inheritdoc}
209		*/
210		public function getAll(SearchOptions $options): array
211		{
212		return $this->paginate($options->toArray());
213		}
214
215		/**
216		* {@inheritdoc}
217		*/
218		public function delete($id): void
219		{
220		$this->_collection->remove(['_id' => new MongoId($id)], []);
221		}
222
223		public function truncate()
224		{
225		$this->_collection->remove();
226
227		return $this;
228		}
229
230		/**
231		* {@inheritdoc}
232		*/
233		public function saveWatch(array $data): bool
234		{
235		if (empty($data['name'])) {
236		return false;
237		}
238
239		if (!empty($data['removed']) && isset($data['_id'])) {
240		$this->_watches->remove(
241		['_id' => new MongoId($data['_id'])],
242		['w' => 1]
243		);
244
245		return true;
246		}
247
248		if (empty($data['_id'])) {
249		$this->_watches->insert(
250		$data,
251		['w' => 1]
252		);
253
254		return true;
255		}
256
257		$data['_id'] = new MongoId($data['_id']);
258		$this->_watches->update(
259		['_id' => $data['_id']],
260		$data,
261		['w' => 1]
262		);
263
264		return true;
265		}
266
267		/**
268		* {@inheritdoc}
269		*/
270		public function getAllWatches(): array
271		{
272		$cursor = $this->_watches->find();
273
274		return array_values(iterator_to_array($cursor));
275		}
276
277		public function truncateWatches()
278		{
279		$this->_watches->remove();
280
281		return $this;
282		}
283
284		/**
285		* {@inheritdoc}
286		*/
287		private function paginate(array $options): array
288		{
289		$opts = $this->_mapper->convert($options);
290
291		$totalRows = $this->_collection->find(
292		$opts['conditions'],
293		['_id' => 1]
294		)->count();
295
296		$totalPages = max(ceil($totalRows / $opts['perPage']), 1);
297		$page = 1;
298		if (isset($options['page'])) {
299		$page = min(max($options['page'], 1), $totalPages);
300		}
301
302		$projection = false;
303		if (isset($options['projection'])) {
304		if ($options['projection'] === true) {
305		$projection = ['meta' => 1, 'profile.main()' => 1];
306		} else {
307		$projection = $options['projection'];
308		}
309		}
310
311		if ($projection === false) {
312		$cursor = $this->_collection->find($opts['conditions'])
313		->sort($opts['sort'])
314		->skip((int)($page - 1) * $opts['perPage'])
315		->limit($opts['perPage']);
316		} else {
317		$cursor = $this->_collection->find($opts['conditions'], $projection)
318		->sort($opts['sort'])
319		->skip((int)($page - 1) * $opts['perPage'])
320		->limit($opts['perPage']);
321		}
322
323		return [
324		'results' => $this->_wrap($cursor),
325		'sort' => $opts['sort'],
326		'direction' => $opts['direction'],
327		'page' => $page,
328		'perPage' => $opts['perPage'],
329		'totalPages' => $totalPages,
330		];
331		}
332
333		/**
334		* Converts arrays + MongoCursors into Profile instances.
335		*
336		* @param array\|MongoCursor $data the data to transform
337		* @return Profile\|Profile[] the transformed/wrapped results
338		*/
339		private function _wrap($data)
340		{
341		if ($data === null) {
342		throw new Exception('No profile data found.');
343		}
344
345		if (is_array($data)) {
346		return new Profile($data);
347		}
348		$results = [];
349		foreach ($data as $row) {
350		$results[] = new Profile($row);
351		}
352
353		return $results;
354		}
355
356		/**
357		* {@inheritdoc}
358		*/
359		public function stats(): array
360		{
361		return [
362		'profiles' => 0,
363		'latest' => 0,
364		'bytes' => 0,
365		];
366		}
367		}
368

perftools / xhgui

Issues (41)

Security Analysis no request data

src/Searcher/MongoSearcher.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like