ImportController::runImport() - Code Metrics - Inspection of "Move code to PSR-4 namespace" - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#331)

by Elan

created 2020-09-19 12:56 UTC

ImportController::runImport() A

↳ Parent: ImportController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace XHGui\Controller;

use Exception;
use InvalidArgumentException;
use Slim\Http\Request;
use Slim\Slim;
use XHGui\Saver\SaverInterface;
use XHGui\AbstractController;

class ImportController extends AbstractController
{
    /**
     * @var SaverInterface
     */
    private $saver;

    /** @var string */
    private $token;

    public function __construct(Slim $app, SaverInterface $saver, $token)
    {
        parent::__construct($app);
        $this->saver = $saver;
        $this->token = $token;
    }

    public function import()
    {
        $request = $this->app->request();
        $response = $this->app->response();

        try {
            $this->runImport($request);
            $result = ['ok' => true, 'size' => $request->getContentLength()];
        } catch (InvalidArgumentException $e) {
            $result = ['error' => true, 'message' => $e->getMessage()];
            $response->setStatus(401);
        } catch (Exception $e) {
            $result = ['error' => true, 'message' => $e->getMessage()];
            $response->setStatus(500);
        }

        $response['Content-Type'] = 'application/json';
        $response->body(json_encode($result));

    }

    private function runImport(Request $request)
    {
        if ($this->token) {
            if ($this->token !== $request->get('token')) {
                throw new InvalidArgumentException('Token validation failed');
            }
        }

        $data = json_decode($request->getBody(), true);
        $this->saver->save($data);
    }
}


1			<?php
2
3			namespace XHGui\Controller;
4
5			use Exception;
6			use InvalidArgumentException;
7			use Slim\Http\Request;
8			use Slim\Slim;
9			use XHGui\Saver\SaverInterface;
10			use XHGui\AbstractController;
11
12			class ImportController extends AbstractController
13			{
14			/**
15			* @var SaverInterface
16			*/
17			private $saver;
18
19			/** @var string */
20			private $token;
21
22			public function __construct(Slim $app, SaverInterface $saver, $token)
23			{
24			parent::__construct($app);
25			$this->saver = $saver;
26			$this->token = $token;
27			}
28
29			public function import()
30			{
31			$request = $this->app->request();
32			$response = $this->app->response();
33
34			try {
35			$this->runImport($request);
36			$result = ['ok' => true, 'size' => $request->getContentLength()];
37			} catch (InvalidArgumentException $e) {
38			$result = ['error' => true, 'message' => $e->getMessage()];
39			$response->setStatus(401);
40			} catch (Exception $e) {
41			$result = ['error' => true, 'message' => $e->getMessage()];
42			$response->setStatus(500);
43			}
44
45			$response['Content-Type'] = 'application/json';
46			$response->body(json_encode($result));
			0 ignored issues – show Bug introduced 2020-07-09 17:53 UTC by Report Bug Copy Issue Report The method `body` cannot be called on `$response` (of type `array<string,string,{"Content-Type":"string"}>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
47			}
48
49			private function runImport(Request $request)
50			{
51			if ($this->token) {
52			if ($this->token !== $request->get('token')) {
53			throw new InvalidArgumentException('Token validation failed');
54			}
55			}
56
57			$data = json_decode($request->getBody(), true);
58			$this->saver->save($data);
59			}
60			}
61

perftools / xhgui

Pull Request — master (#331)

ImportController::runImport() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like