Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Xhgui_Storage_File often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Xhgui_Storage_File, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 3 | class Xhgui_Storage_File extends Xhgui_Storage_Abstract implements |
||
| 4 | Xhgui_StorageInterface, |
||
| 5 | Xhgui_WatchedFunctionsStorageInterface |
||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var string |
||
| 10 | */ |
||
| 11 | protected $path = '../data/'; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string |
||
| 15 | */ |
||
| 16 | protected $prefix = 'xhgui.data'; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var bool|mixed |
||
| 20 | */ |
||
| 21 | protected $separateMeta = true; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var mixed |
||
| 25 | */ |
||
| 26 | protected $dataSerializer; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var mixed |
||
| 30 | */ |
||
| 31 | protected $metaSerializer; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | protected $watchedFunctionsPathPrefix = '../watched_functions/'; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var int[] |
||
| 40 | */ |
||
| 41 | protected $countCache; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var Xhgui_Storage_Filter |
||
| 45 | */ |
||
| 46 | private $filter; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Xhgui_Storage_File constructor. |
||
| 50 | * @param $config |
||
| 51 | */ |
||
| 52 | public function __construct($config) |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @inheritDoc |
||
| 64 | * @param Xhgui_Storage_Filter $filter |
||
| 65 | * @param bool $projections |
||
| 66 | * @return Xhgui_Storage_ResultSet |
||
| 67 | */ |
||
| 68 | public function find(Xhgui_Storage_Filter $filter, $projections = false) |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @inheritDoc |
||
| 156 | * @param Xhgui_Storage_Filter $filter |
||
| 157 | * @return int |
||
| 158 | */ |
||
| 159 | public function count(Xhgui_Storage_Filter $filter) |
||
| 167 | |||
| 168 | /** |
||
| 169 | * @inheritDoc |
||
| 170 | * @param $id |
||
| 171 | * @return mixed |
||
| 172 | */ |
||
| 173 | public function findOne($id) |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @inheritDoc |
||
| 183 | * @param $id |
||
| 184 | * @return bool |
||
| 185 | */ |
||
| 186 | public function remove($id) |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @inheritDoc |
||
| 201 | */ |
||
| 202 | public function drop() |
||
| 207 | |||
| 208 | /** |
||
| 209 | * @inheritDoc |
||
| 210 | * @param $match |
||
| 211 | * @param $col |
||
| 212 | * @param int $percentile |
||
| 213 | * @return array |
||
| 214 | */ |
||
| 215 | public function aggregate(Xhgui_Storage_Filter $filter, $col, $percentile = 1) |
||
| 244 | |||
| 245 | |||
| 246 | /** |
||
| 247 | * Column sorter |
||
| 248 | * |
||
| 249 | * @param $a |
||
| 250 | * @param $b |
||
| 251 | * @return int |
||
| 252 | */ |
||
| 253 | public function sortByColumn($a, $b) |
||
| 308 | |||
| 309 | /** |
||
| 310 | * Generate meta profile name from profile file name. |
||
| 311 | * |
||
| 312 | * In most cases just add .meta extension |
||
| 313 | * |
||
| 314 | * @param $file |
||
| 315 | * @return mixed |
||
| 316 | */ |
||
| 317 | protected function getMetafileNameFromProfileName($file) |
||
| 322 | |||
| 323 | |||
| 324 | /** |
||
| 325 | * @inheritDoc |
||
| 326 | * @param $data |
||
| 327 | */ |
||
| 328 | public function insert(array $data) |
||
| 337 | |||
| 338 | /** |
||
| 339 | * @inheritDoc |
||
| 340 | * @param $id |
||
| 341 | * @param $data |
||
| 342 | */ |
||
| 343 | public function update($id, array $data) |
||
| 347 | |||
| 348 | /** |
||
| 349 | * Load profile file from disk, prepare it and return parsed array |
||
| 350 | * |
||
| 351 | * @param $path |
||
| 352 | * @param bool $meta |
||
| 353 | * @return mixed |
||
| 354 | */ |
||
| 355 | protected function importFile($path, $meta = false) |
||
| 392 | |||
| 393 | /** |
||
| 394 | * @inheritDoc |
||
| 395 | * @return array |
||
| 396 | */ |
||
| 397 | public function getWatchedFunctions() |
||
| 406 | |||
| 407 | /** |
||
| 408 | * @inheritDoc |
||
| 409 | * @param $name |
||
| 410 | * @return bool |
||
| 411 | */ |
||
| 412 | View Code Duplication | public function addWatchedFunction($name) |
|
| 425 | |||
| 426 | /** |
||
| 427 | * @inheritDoc |
||
| 428 | * @param $id |
||
| 429 | * @param $name |
||
| 430 | * @return bool |
||
| 431 | */ |
||
| 432 | View Code Duplication | public function updateWatchedFunction($id, $name) |
|
| 445 | |||
| 446 | /** |
||
| 447 | * @inheritDoc |
||
| 448 | * @param $id |
||
| 449 | */ |
||
| 450 | public function removeWatchedFunction($id) |
||
| 456 | |||
| 457 | /** |
||
| 458 | * Parse filename and try to get request time from filename |
||
| 459 | * |
||
| 460 | * @param $fileName |
||
| 461 | * @return bool|DateTime |
||
| 462 | */ |
||
| 463 | public function getRequestTimeFromFilename($fileName) |
||
| 475 | } |
||
| 476 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: