Xhgui_Searcher_Pdo::query() - Code Metrics - Inspection of "WIP: Backend decoupling" - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#244)

by Marcel

created 2019-05-01 20:22 UTC

Xhgui_Searcher_Pdo::query() A

↳ Parent: Xhgui_Searcher_Pdo

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

class Xhgui_Searcher_Pdo implements Xhgui_Searcher_Interface

{
    /**
     * @var PDO
     */
    private $pdo;

    /**
     * @var string
     */
    private $table;

    /**
     * @param PDO    $pdo   An open database connection
     * @param string $table Table name where Xhgui profiles are stored
     */
    public function __construct(PDO $pdo, $table)
    {
        $this->pdo = $pdo;
        $this->table = $table;
    }

    /**
     * {@inheritdoc}
     */
    public function latest()

    {
        $stmt = $this->pdo->query("
          SELECT
            id,
            profile,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date
          FROM {$this->table}
          ORDER BY request_date ASC
          LIMIT 1
        ");

        $row = $stmt->fetch(PDO::FETCH_ASSOC);
        if (false === $row) {
            throw new Exception('No profile available yet.');
        }

        return new Xhgui_Profile([
            '_id' => $row['id'],
            'meta' => [
                'url' => $row['url'],
                'SERVER' => json_decode($row['SERVER'], true),
                'get' => json_decode($row['GET'], true),
                'env' => json_decode($row['ENV'], true),
                'simple_url' => $row['simple_url'],
                'request_ts' => (int) $row['request_ts'],
                'request_ts_micro' => $row['request_ts_micro'],
                'request_date' => $row['request_date'],
            ],
            'profile' => json_decode($row['profile'], true)
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function query($conditions, $limit, $fields = [])
    {
        // TODO: Implement query() method.
    }

    /**
     * {@inheritdoc}
     */
    public function get($id)

    {
        $stmt = $this->pdo->prepare("
          SELECT
            profile,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date
          FROM {$this->table}
          WHERE id = :id
        ");

        $stmt->execute(['id' => $id]);

        if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
            throw new Exception('No profile data found.');
        }

        return new Xhgui_Profile([
            '_id' => $id,
            'meta' => [
                'url' => $row['url'],
                'SERVER' => json_decode($row['SERVER'], true),
                'get' => json_decode($row['GET'], true),
                'env' => json_decode($row['ENV'], true),
                'simple_url' => $row['simple_url'],
                'request_ts' => (int) $row['request_ts'],
                'request_ts_micro' => $row['request_ts_micro'],
                'request_date' => $row['request_date'],
            ],
            'profile' => json_decode($row['profile'], true)
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function getForUrl($url, $options, $conditions = array())
    {
        // TODO: Implement getForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getPercentileForUrl($percentile, $url, $search = array())
    {
        // TODO: Implement getPercentileForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getAvgsForUrl($url, $search = array())
    {
        // TODO: Implement getAvgsForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getAll($options = array())
    {
        $sort = $options['sort'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $direction = $options['direction'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $page = $options['page'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $perPage = $options['perPage'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $stmt = $this->pdo->query("
          SELECT
            id,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date,
            main_wt,
            main_ct,
            main_cpu, 
            main_mu,
            main_pmu
          FROM {$this->table}
          ORDER BY request_ts DESC
        ", PDO::FETCH_ASSOC);

        $results = [];
        foreach ($stmt->fetchAll(PDO::FETCH_ASSOC) as $row) {
            $results[] = new Xhgui_Profile([
                '_id' => $row['id'],
                'meta' => [
                    'url' => $row['url'],
                    'SERVER' => json_decode($row['SERVER'], true),
                    'get' => json_decode($row['GET'], true),
                    'env' => json_decode($row['ENV'], true),
                    'simple_url' => $row['simple_url'],
                    'request_ts' => $row['request_ts'],
                    'request_ts_micro' => $row['request_ts_micro'],
                    'request_date' => $row['request_date'],
                ],
                'profile' => [
                    'main()' => [
                        'wt' => (int) $row['main_wt'],
                        'ct' => (int) $row['main_ct'],
                        'cpu' => (int) $row['main_cpu'],
                        'mu' => (int) $row['main_mu'],
                        'pmu' => (int) $row['main_pmu'],
                    ]
                ]
            ]);
        }

        return array(
            'results' => $results,
            'sort' => 'meta.request_ts',
            'direction' => 'desc',
            'page' => 1,
            'perPage' => count($results),
            'totalPages' => 1
        );
    }

    /**
     * {@inheritdoc}
     */
    public function delete($id)
    {
        $stmt = $this->pdo->prepare("
          DELETE FROM {$this->table}
          WHERE id = :id
        ");

        $stmt->execute(['id' => $id]);
    }

    /**
     * {@inheritdoc}
     */
    public function truncate()
    {
        return is_int(
            $this->pdo->exec("DELETE FROM {$this->table}")
        );
    }
}


1		<?php
2
3		class Xhgui_Searcher_Pdo implements Xhgui_Searcher_Interface
		0 ignored issues – show Bug introduced 2019-05-01 20:23 UTC by Report Bug Copy Issue Report There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: getAllWatches, saveWatch, truncateWatches Loading history...
4		{
5		/**
6		* @var PDO
7		*/
8		private $pdo;
9
10		/**
11		* @var string
12		*/
13		private $table;
14
15		/**
16		* @param PDO $pdo An open database connection
17		* @param string $table Table name where Xhgui profiles are stored
18		*/
19		public function __construct(PDO $pdo, $table)
20		{
21		$this->pdo = $pdo;
22		$this->table = $table;
23		}
24
25		/**
26		* {@inheritdoc}
27		*/
28	View Code Duplication	public function latest()
		0 ignored issues – show Duplication introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$stmt = $this->pdo->query("
31		SELECT
32		id,
33		profile,
34		url,
35		SERVER,
36		GET,
37		ENV,
38		simple_url,
39		request_ts,
40		request_ts_micro,
41		request_date
42		FROM {$this->table}
43		ORDER BY request_date ASC
44		LIMIT 1
45		");
46
47		$row = $stmt->fetch(PDO::FETCH_ASSOC);
48		if (false === $row) {
49		throw new Exception('No profile available yet.');
50		}
51
52		return new Xhgui_Profile([
53		'_id' => $row['id'],
54		'meta' => [
55		'url' => $row['url'],
56		'SERVER' => json_decode($row['SERVER'], true),
57		'get' => json_decode($row['GET'], true),
58		'env' => json_decode($row['ENV'], true),
59		'simple_url' => $row['simple_url'],
60		'request_ts' => (int) $row['request_ts'],
61		'request_ts_micro' => $row['request_ts_micro'],
62		'request_date' => $row['request_date'],
63		],
64		'profile' => json_decode($row['profile'], true)
65		]);
66		}
67
68		/**
69		* {@inheritdoc}
70		*/
71		public function query($conditions, $limit, $fields = [])
72		{
73		// TODO: Implement query() method.
74		}
75
76		/**
77		* {@inheritdoc}
78		*/
79	View Code Duplication	public function get($id)
		0 ignored issues – show Duplication introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$stmt = $this->pdo->prepare("
82		SELECT
83		profile,
84		url,
85		SERVER,
86		GET,
87		ENV,
88		simple_url,
89		request_ts,
90		request_ts_micro,
91		request_date
92		FROM {$this->table}
93		WHERE id = :id
94		");
95
96		$stmt->execute(['id' => $id]);
97
98		if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
99		throw new Exception('No profile data found.');
100		}
101
102		return new Xhgui_Profile([
103		'_id' => $id,
104		'meta' => [
105		'url' => $row['url'],
106		'SERVER' => json_decode($row['SERVER'], true),
107		'get' => json_decode($row['GET'], true),
108		'env' => json_decode($row['ENV'], true),
109		'simple_url' => $row['simple_url'],
110		'request_ts' => (int) $row['request_ts'],
111		'request_ts_micro' => $row['request_ts_micro'],
112		'request_date' => $row['request_date'],
113		],
114		'profile' => json_decode($row['profile'], true)
115		]);
116		}
117
118		/**
119		* {@inheritdoc}
120		*/
121		public function getForUrl($url, $options, $conditions = array())
122		{
123		// TODO: Implement getForUrl() method.
124		}
125
126		/**
127		* {@inheritdoc}
128		*/
129		public function getPercentileForUrl($percentile, $url, $search = array())
130		{
131		// TODO: Implement getPercentileForUrl() method.
132		}
133
134		/**
135		* {@inheritdoc}
136		*/
137		public function getAvgsForUrl($url, $search = array())
138		{
139		// TODO: Implement getAvgsForUrl() method.
140		}
141
142		/**
143		* {@inheritdoc}
144		*/
145		public function getAll($options = array())
146		{
147		$sort = $options['sort'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$sort` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
148		$direction = $options['direction'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$direction` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
149		$page = $options['page'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$page` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
150		$perPage = $options['perPage'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$perPage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
151
152		$stmt = $this->pdo->query("
153		SELECT
154		id,
155		url,
156		SERVER,
157		GET,
158		ENV,
159		simple_url,
160		request_ts,
161		request_ts_micro,
162		request_date,
163		main_wt,
164		main_ct,
165		main_cpu,
166		main_mu,
167		main_pmu
168		FROM {$this->table}
169		ORDER BY request_ts DESC
170		", PDO::FETCH_ASSOC);
171
172		$results = [];
173		foreach ($stmt->fetchAll(PDO::FETCH_ASSOC) as $row) {
174		$results[] = new Xhgui_Profile([
175		'_id' => $row['id'],
176		'meta' => [
177		'url' => $row['url'],
178		'SERVER' => json_decode($row['SERVER'], true),
179		'get' => json_decode($row['GET'], true),
180		'env' => json_decode($row['ENV'], true),
181		'simple_url' => $row['simple_url'],
182		'request_ts' => $row['request_ts'],
183		'request_ts_micro' => $row['request_ts_micro'],
184		'request_date' => $row['request_date'],
185		],
186		'profile' => [
187		'main()' => [
188		'wt' => (int) $row['main_wt'],
189		'ct' => (int) $row['main_ct'],
190		'cpu' => (int) $row['main_cpu'],
191		'mu' => (int) $row['main_mu'],
192		'pmu' => (int) $row['main_pmu'],
193		]
194		]
195		]);
196		}
197
198		return array(
199		'results' => $results,
200		'sort' => 'meta.request_ts',
201		'direction' => 'desc',
202		'page' => 1,
203		'perPage' => count($results),
204		'totalPages' => 1
205		);
206		}
207
208		/**
209		* {@inheritdoc}
210		*/
211		public function delete($id)
212		{
213		$stmt = $this->pdo->prepare("
214		DELETE FROM {$this->table}
215		WHERE id = :id
216		");
217
218		$stmt->execute(['id' => $id]);
219		}
220
221		/**
222		* {@inheritdoc}
223		*/
224		public function truncate()
225		{
226		return is_int(
227		$this->pdo->exec("DELETE FROM {$this->table}")
228		);
229		}
230		}
231

perftools / xhgui

Pull Request — master (#244)

Xhgui_Searcher_Pdo::query() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like