+global\Xhgui_Searcher_Mongo::getPercentileForUrl()

Complexity

Conditions	8
Paths	16

Size

Total Lines

72

Duplication

Lines	3
Ratio	4.17 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	Xhgui_Profiles::getPercentileForUrl()	0	29	6

<?php
/**
 * Contains logic for getting/creating/removing profile records.
 */
class Xhgui_Profiles
{
    protected $storage;

    public function __construct(\Xhgui_StorageInterface $storage)
    {
        $this->storage = $storage;
    }

    /**
     * Get the latest profile data.
     *
     * @return Xhgui_Profile
     * @throws Exception
     */
    public function latest()
    {
        $cursor = $this->storage->find()

The call to find() misses a required argument $filter.

                                ->sort(array('meta.request_date' => -1))
                                ->limit(1);
        $result = $cursor->getNext();
        return $this->_wrap($result);

The expression $this->_wrap($result); of type Xhgui_Profile|array adds the type array to the return on line 26 which is incompatible with the return type documented by Xhgui_Profiles::latest of type Xhgui_Profile.

    }

    public function query($conditions, $fields = null)
    {
        return $this->storage->find($conditions, $fields);
    }

    /**
     * Get a single profile run by id.
     *
     * @param string $id The id of the profile to get.
     * @return Xhgui_Profile
     * @throws Exception
     */
    public function get($id)
    {
        return $this->_wrap($this->storage->findOne($id));

The expression $this->_wrap($this->storage->findOne($id)); of type Xhgui_Profile|array adds the type array to the return on line 43 which is incompatible with the return type documented by Xhgui_Profiles::get of type Xhgui_Profile.

    }

    /**
     * Get the list of profiles for a simplified url.
     *
     * @param string $url The url to load profiles for.
     * @param array $options Pagination options to use.
     * @param array $conditions The search options.
     * @return MongoCursor
     */
    public function getForUrl($url, $options, $conditions = array())
    {
        $conditions = array_merge(
            (array)$conditions,
            array('simple_url' => $url)
        );
        $options = array_merge($options, array(
            'conditions' => $conditions,
        ));
        return $this->paginate($options);

$options is of type array, but the function expects a object<Xhgui_Storage_Filter>.

    }

    public function paginate(Xhgui_Storage_Filter $filter)
    {
        $projection = false;
        if (isset($options['projection'])) {

The variable $options seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

            if ($options['projection'] === true) {
                $projection = array('meta' => 1, 'profile.main()' => 1);
            } else {
                $projection = $options['projection'];
            }
        }

        if ($projection === false) {
            $result = $this->storage->find($filter, null);

null is of type null, but the function expects a boolean.

        } else {
            $result = $this->storage->find($filter, $projection);
        }

        $totalRows = $this->storage->count($filter);
        $totalPages = max(ceil($totalRows / $filter->getPerPage()), 1);

        return array(
            'results'       => $this->_wrap($result),
            'sort'          => $filter->getSort(),
            'direction'     => $filter->getDirection(),
            'page'          => $filter->getPage(),
            'perPage'       => $filter->getPerPage(),
            'totalPages'    => $totalPages
        );
    }

    /**
     * Get the Percentile metrics for a URL
     *
     * This will group data by date and returns only the
     * percentile + date, making the data ideal for time series graphs
     *
     * @param integer $percentile The percentile you want. e.g. 90.
     * @param string $url
     * @param array $search Search options containing startDate and or endDate

There is no parameter named $search. Was it maybe removed?

     * @return array Array of metrics grouped by date
     */
    public function getPercentileForUrl($percentile, $url, $filter)

The parameter $url is not used and could be removed.

    {
        $col = '$meta.request_date';
//        if (!empty($search['limit']) && $search['limit'][0] == "P") {
//            $col = '$meta.request_ts';
//        }

        $results = $this->storage->aggregate($filter, $col, $percentile);
        if (empty($results['result'])) {
            return array();
        }
        $keys = array(
            'wall_times'    => 'wt',
            'cpu_times'     => 'cpu',
            'mu_times'      => 'mu',
            'pmu_times'     => 'pmu'
        );
        foreach ($results['result'] as &$result) {
            $result['date'] = ($result['_id'] instanceof MongoDate) ? date('Y-m-d H:i:s', $result['_id']->sec) : $result['_id'];
            unset($result['_id']);
            $index = max(round($result['raw_index']) - 1, 0);
            foreach ($keys as $key => $out) {
                sort($result[$key]);
                $result[$out] = isset($result[$key][$index]) ? $result[$key][$index] : null;
                unset($result[$key]);
            }
        }
        return array_values($results['result']);
    }

    /**
     * Get a paginated set of results.
     *
     * @param array $options The find options to use.

There is no parameter named $options. Was it maybe removed?

     * @return array An array of result data.
     */
    public function getAll($filter)
    {
        return $this->paginate($filter);
    }

    /**
     * Insert a profile run.
     *
     * Does unchecked inserts.
     *
     * @param array $profile The profile data to save.
     * @return
     */
    public function insert($profile)
    {
        return $this->storage->insert($profile, array('w' => 0));

It seems like you code against a concrete implementation and not the interface Xhgui_StorageInterface as the method insert() does only exist in the following implementations of said interface: Xhgui_Storage_File, Xhgui_Storage_Mongo.

    }

    /**
     * Delete a profile run.
     *
     * @param string $id The profile id to delete.
     * @return array|bool
     */
    public function delete($id)
    {
        return $this->storage->remove($id);
    }

    /**
     * Used to truncate a collection.
     *
     * Primarly used in test cases to reset the test db.
     *
     * @return boolean
     */
    public function truncate()
    {
        return $this->storage->drop();
    }

    /**
     * Converts arrays + MongoCursors into Xhgui_Profile instances.
     *
     * @param array|MongoCursor $data The data to transform.
     * @return Xhgui_Profile|array The transformed/wrapped results.
     * @throws Exception
     */
    protected function _wrap($data)
    {
        if ($data === null) {
            throw new Exception('No profile data found.');
        }

        if (!($data instanceof \Xhgui_Storage_ResultSet)) {
            return new Xhgui_Profile($data, true);

It seems like $data defined by parameter $data on line 191 can also be of type object<MongoCursor>; however, Xhgui_Profile::__construct() does only seem to accept array, maybe add an additional type check?

        }

        $results = array();
        foreach ($data as $row) {
            $results[] = new Xhgui_Profile($row, true);
        }
        return $results;
    }
}