AbstractController::config() - Code Metrics - Inspection of "Slim upgrade to v3" - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#333)

by Elan

created 2020-12-22 15:08 UTC

AbstractController::config() A

↳ Parent: AbstractController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace XHGui;

use Slim\App;

abstract class AbstractController
{
    /**
     * @var array
     */
    protected $_templateVars = [];

    /**
     * @var string|null
     */
    protected $_template = null;

    /**
     * @var App
     */
    protected $app;

    public function __construct(App $app)
    {
        $this->app = $app;
    }

    public function set($vars)
    {
        $this->_templateVars = array_merge($this->_templateVars, $vars);
    }

    public function templateVars()
    {
        return $this->_templateVars;
    }

    public function render()
    {
        // We want to render the specified Twig template to the output buffer.
        // The simplest way to do that is Slim::render, but that is not allowed
        // in middleware, because it uses Slim\View::display which prints
        // directly to the native PHP output buffer.
        // Doing that is problematic, because the HTTP headers set via $app->response()
        // must be output first, which won't happen until after the middleware
        // is completed. Output of headers and body is done by the Slim::run entry point.

        // The below is copied from Slim::render (slim/[email protected]).
        // Modified to use View::fetch + Response::write, instead of View::display.
        $this->app->view->appendData($this->_templateVars);

        $body = $this->app->view->fetch($this->_template);
        $this->app->response->write($body);

    }

    protected function config(string $key)
    {
        return $this->app->getContainer()->get($key);
    }
}


1			<?php
2
3			namespace XHGui;
4
5			use Slim\App;
6
7			abstract class AbstractController
8			{
9			/**
10			* @var array
11			*/
12			protected $_templateVars = [];
13
14			/**
15			* @var string\|null
16			*/
17			protected $_template = null;
18
19			/**
20			* @var App
21			*/
22			protected $app;
23
24			public function __construct(App $app)
25			{
26			$this->app = $app;
27			}
28
29			public function set($vars)
30			{
31			$this->_templateVars = array_merge($this->_templateVars, $vars);
32			}
33
34			public function templateVars()
35			{
36			return $this->_templateVars;
37			}
38
39			public function render()
40			{
41			// We want to render the specified Twig template to the output buffer.
42			// The simplest way to do that is Slim::render, but that is not allowed
43			// in middleware, because it uses Slim\View::display which prints
44			// directly to the native PHP output buffer.
45			// Doing that is problematic, because the HTTP headers set via $app->response()
46			// must be output first, which won't happen until after the middleware
47			// is completed. Output of headers and body is done by the Slim::run entry point.
48
49			// The below is copied from Slim::render (slim/[email protected]).
50			// Modified to use View::fetch + Response::write, instead of View::display.
51			$this->app->view->appendData($this->_templateVars);
			0 ignored issues – show Bug introduced 2020-09-22 02:33 UTC by Report Bug Copy Issue Report The property `view` does not seem to exist in `Slim\App`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
52			$body = $this->app->view->fetch($this->_template);
53			$this->app->response->write($body);
			0 ignored issues – show Bug introduced 2020-09-22 02:33 UTC by Report Bug Copy Issue Report The property `response` does not seem to exist in `Slim\App`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
54			}
55
56			protected function config(string $key)
57			{
58			return $this->app->getContainer()->get($key);
59			}
60			}
61

perftools / xhgui

Pull Request — master (#333)

AbstractController::config() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like