Xhgui_Storage_File::sortByColumn() - Code Metrics - Inspection of "Introduce multiple storage drivers" - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#268)

unknown

created 2019-07-23 20:14 UTC

Xhgui_Storage_File::sortByColumn() D

↳ Parent: Xhgui_Storage_File

Complexity

Conditions	19
Paths	78

Size

Total Lines

Duplication

Lines	12
Ratio	21.82 %

Importance

Changes

Metric	Value
dl	12
loc	55
rs	4.5166
c	0
b	0
f	0
cc	19
nc	78
nop	2

How to fix Long Method Complexity

<?php

class Xhgui_Storage_File extends Xhgui_Storage_Abstract implements
    Xhgui_StorageInterface,
    Xhgui_WatchedFunctionsStorageInterface
{

    /**
     * @var string
     */
    protected $path     = '../data/';

    /**
     * @var string
     */
    protected $prefix   = 'xhgui.data';

    /**
     * @var bool|mixed
     */
    protected $separateMeta = true;

    /**
     * @var mixed
     */
    protected $dataSerializer;

    /**
     * @var mixed
     */
    protected $metaSerializer;

    /**
     * @var string
     */
    protected $watchedFunctionsPathPrefix = '../watched_functions/';

    /**
     * @var int[]
     */
    protected $countCache;

    /**
     * @var Xhgui_Storage_Filter
     */
    private $filter;

    /**
     * Xhgui_Storage_File constructor.
     * @param $config
     */
    public function __construct($config)
    {
        $this->prefix           = 'xhgui.data';

        $this->path             = $config['save.handler.path'];
        $this->separateMeta     = $config['save.handler.separate_meta'];
        $this->dataSerializer   = $config['save.handler.serializer'];
        $this->metaSerializer   = $config['save.handler.meta_serializer'];
    }

    /**
     * @inheritDoc
     * @param Xhgui_Storage_Filter $filter
     * @param bool $projections
     * @return Xhgui_Storage_ResultSet
     */
    public function find(Xhgui_Storage_Filter $filter, $projections = false)
    {

        if ($filter->getId()) {
            $result = glob($this->path. DIRECTORY_SEPARATOR.$filter->getId());
        } else {
            $result = glob($this->path. $this->prefix . '*');
            sort($result);
        }

        $ret = [];
        foreach ($result as $i => $file) {
            // skip meta files.
            if (strpos($file, '.meta') !== false) {
                continue;
            }

            // try to detect timestamp in filename, to optimize searching.
            // If that fails we need to get it after file import from meta.
            $reqTimeFromFilename = $this->getRequestTimeFromFilename($file);
            if (!empty($reqTimeFromFilename)) {
                if (null !== $filter->getStartDate() &&
                    $this->getDateTimeFromString($filter->getStartDate(), 'start') >= $reqTimeFromFilename) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    continue;
                }

                if (null !== $filter->getEndDate() &&
                    $this->getDateTimeFromString($filter->getEndDate(), 'end') <= $reqTimeFromFilename ) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    continue;
                }
            }

            $metaFile   = $this->getMetafileNameFromProfileName($file);

            $meta       = $this->importFile($metaFile, true);
            if ($meta === false) {
                continue;
            }

            $profile    = $this->importFile($file, false);
            if ($profile === false) {
                continue;
            }

            if (!empty($profile['meta'])) {
                $meta = array_merge($meta, $profile['meta']);
            }

            if (empty($reqTimeFromFilename) && (null !== $filter->getStartDate() || null !== $filter->getEndDate())){
                if (null !== $filter->getStartDate() &&
                    $this->getDateTimeFromString($filter->getStartDate(), 'start') >= $filter->getStartDate()) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    continue;
                }
                if (null !== $filter->getEndDate() &&
                    $this->getDateTimeFromString($filter->getEndDate(), 'end') <= $filter->getEndDate()) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    continue;
                }
            }

            if ($filter->getUrl() &&
                strpos($meta['simple_url'], $filter->getUrl()) === false &&
                strpos($meta['SERVER']['SERVER_NAME'].$meta['simple_url'], $filter->getUrl()) === false
            ) {
                continue;
            }

            if (!empty($profile['profile'])) {
                $profile = $profile['profile'];
            }

            if (!empty($profile['_id'])) {
                $id = $profile['_id'];
            } else {
                $id = basename($file);
            }
            if (!empty($profile)) {
                $ret[$id] = [
                    'profile'   => $profile,
                    '_id'       => $id,
                    'meta'      => $meta,
                ];
            } else {
                $ret[$id] = $profile;
            }
        }

        try {
            if (!empty($filter->getSort()) && !empty($ret)) {
                $this->filter = $filter;
                usort($ret, array($this, 'sortByColumn'));
                unset($this->filter);
            }
        } catch (InvalidArgumentException $e) {
            // ignore for now.
        }
        
        $cacheId = md5(serialize($filter->toArray()));

        $this->countCache[$cacheId] = count($ret);
        $ret = array_slice($ret, $filter->getPerPage()*($filter->getPage()-1), $filter->getPerPage());
        $ret = array_column($ret, null, '_id');

        return new Xhgui_Storage_ResultSet($ret, $this->countCache[$cacheId]);
    }

    /**
     * @inheritDoc
     * @param Xhgui_Storage_Filter $filter
     * @return int
     */
    public function count(Xhgui_Storage_Filter $filter)
    {
        $cacheId = md5(serialize($filter->toArray()));
        if (empty($this->countCache[$cacheId])) {
            $this->find($filter);
        }
        return $this->countCache[$cacheId];
    }

    /**
     * @inheritDoc
     * @param $id
     * @return mixed
     */
    public function findOne($id)
    {
        $filter = new Xhgui_Storage_Filter();
        $filter->setId($id);
        $resultSet = $this->find($filter);
        return $resultSet->current();
    }

    /**
     * @inheritDoc
     * @param $id
     * @return bool
     */
    public function remove($id)
    {
        if (file_exists($this->path.$id)) {
            $metaFileName = $this->getMetafileNameFromProfileName($id);
            if (file_exists($this->path.$metaFileName)) {
                unlink($this->path.$metaFileName);
            }
            unlink($this->path.$id);
            return true;
        }
        return false;
    }

    /**
     * @inheritDoc
     */
    public function drop()
    {
        array_map('unlink', glob($this->path.'*.xhprof'));
        array_map('unlink', glob($this->path.'*.meta'));
    }

    /**
     * @inheritDoc
     * @param $match
     * @param $col
     * @param int $percentile
     * @return array
     */
    public function aggregate(Xhgui_Storage_Filter $filter, $col, $percentile = 1)
    {
        $ret = $this->find($filter);

        $result = [
            'ok'        => 1,
            'result'    => [],
        ];

        foreach ($ret as $row) {
            $request_date = $row['meta']['request_date'];
            $result['result'][$request_date]['wall_times'][]    = $row['profile']['main()']['wt'];
            $result['result'][$request_date]['cpu_times'][]     = $row['profile']['main()']['cpu'];
            $result['result'][$request_date]['mu_times'][]      = $row['profile']['main()']['mu'];
            $result['result'][$request_date]['pmu_times'][]     = $row['profile']['main()']['pmu'];

            if (empty($result['result'][$request_date]['row_count'])) {
                $result['result'][$request_date]['row_count'] = 0;
            }
            $result['result'][$request_date]['row_count']++;

            $result['result'][$request_date]['raw_index'] =
                $result['result'][$request_date]['row_count']*($percentile/100);

            $result['result'][$request_date]['_id']= $request_date;
        }

        return $result;
    }


    /**
     * Column sorter
     *
     * @param $a
     * @param $b
     * @return int
     */
    public function sortByColumn($a, $b)
    {
        $sort = $this->filter->getSort();
        switch ($sort) {
            case 'ct':
            case 'wt':
            case 'cpu':
            case 'mu':
            case 'pmu':

                $aValue = $a['profile']['main()'][$sort];
                $bValue = $b['profile']['main()'][$sort];
                break;

            case 'time':

                $aValue = $a['meta']['request_ts']['sec'];
                $bValue = $b['meta']['request_ts']['sec'];
                break;

            case 'controller':
            case 'action':
            case 'application':
            case 'branch':
            case 'version':

                $aValue = $a['meta'][$sort];
                $bValue = $b['meta'][$sort];
                break;

            default:
                throw new InvalidArgumentException('Invalid sort mode');
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        if ($aValue == $bValue) {
            return 0;
        }

        if (is_numeric($aValue) || is_numeric($bValue)) {
            if ($this->filter->getDirection() === 'desc') {
                if ($aValue < $bValue) {
                    return 1;
                }
                return -1;
            }

            if ($aValue > $bValue) {
                return 1;
            }
            return -1;
        }

        if ($this->filter->getDirection() === 'desc') {
            return strnatcmp($aValue, $bValue);
        }
        return strnatcmp($bValue, $aValue);
    }

    /**
     * Generate meta profile name from profile file name.
     *
     * In most cases just add .meta extension
     *
     * @param $file
     * @return mixed
     */
    protected function getMetafileNameFromProfileName($file)
    {
        $metaFile = $file.'.meta';
        return $metaFile;
    }

    /**
     * Load profile file from disk, prepare it and return parsed array
     *
     * @param $path
     * @param bool $meta
     * @return mixed
     */
    protected function importFile($path, $meta = false)
    {
        if ($meta) {
            $serializer = $this->metaSerializer;
        } else {
            $serializer = $this->dataSerializer;
        }

        if (!file_exists($path) || !is_readable($path)) {
            return false;
        }
        
        switch ($serializer) {
            default:
            case 'json':
                return json_decode(file_get_contents($path), true);

            case 'serialize':
                if (PHP_MAJOR_VERSION > 7) {
                    return unserialize(file_get_contents($path), false);
                }
                /** @noinspection UnserializeExploitsInspection */
                return unserialize(file_get_contents($path));

            case 'igbinary_serialize':
            case 'igbinary_unserialize':
            case 'igbinary':
                /** @noinspection PhpComposerExtensionStubsInspection */
                return igbinary_unserialize(file_get_contents($path));

            // this is a path to a file on disk
            case 'php':
            case 'var_export':
                /** @noinspection PhpIncludeInspection */
                return include $path;
        }
    }

    /**
     * @inheritDoc
     * @return array
     */
    public function getWatchedFunctions()
    {
        $ret = [];
        $files = glob($this->watchedFunctionsPathPrefix.'*.json');
        foreach ($files as $file) {
            $ret[] = json_decode(file_get_contents($file), true);
        }
        return $ret;
    }

    /**
     * @inheritDoc
     * @param $name
     * @return bool
     */
    public function addWatchedFunction($name)

    {
        $name = trim($name);
        if (empty($name)) {
            return false;
        }
        $id = md5($name);
        $i = file_put_contents(
            $this->watchedFunctionsPathPrefix.$id.'.json',
            json_encode(['id'=>$id, 'name'=>$name])
        );
        return $i > 0;
    }

    /**
     * @inheritDoc
     * @param $id
     * @param $name
     * @return bool
     */
    public function updateWatchedFunction($id, $name)

    {
        $name = trim($name);
        if (empty($name)) {
            return false;
        }

        $i = file_put_contents(
            $this->watchedFunctionsPathPrefix.$id.'.json',
            json_encode(['id'=>$id, 'name'=>trim($name)])
        );
        return $i > 0;
    }

    /**
     * @inheritDoc
     * @param $id
     */
    public function removeWatchedFunction($id)
    {
        if (file_exists($this->watchedFunctionsPathPrefix.$id.'.json')) {
            unlink($this->watchedFunctionsPathPrefix.$id.'.json');
        }
    }

    /**
     * Parse filename and try to get request time from filename
     *
     * @param $fileName
     * @return bool|DateTime
     */
    public function getRequestTimeFromFilename($fileName)
    {
        $matches = [];
        // default pattern is: xhgui.data.<timestamp>.<microseconds>_a68888
        //  xhgui.data.15 55 31 04 66 .6606_a68888
        preg_match('/(?<t>[\d]{10})(\.(?<m>[\d]{1,6}))?.+/i', $fileName, $matches);
        try {
            return DateTime::createFromFormat('U u', $matches['t'].' '. $matches['m']);
        } catch (Exception $e) {
            return null;
        }
    }
}


1		<?php
2
3		class Xhgui_Storage_File extends Xhgui_Storage_Abstract implements
4		Xhgui_StorageInterface,
5		Xhgui_WatchedFunctionsStorageInterface
6		{
7
8		/**
9		* @var string
10		*/
11		protected $path = '../data/';
12
13		/**
14		* @var string
15		*/
16		protected $prefix = 'xhgui.data';
17
18		/**
19		* @var bool\|mixed
20		*/
21		protected $separateMeta = true;
22
23		/**
24		* @var mixed
25		*/
26		protected $dataSerializer;
27
28		/**
29		* @var mixed
30		*/
31		protected $metaSerializer;
32
33		/**
34		* @var string
35		*/
36		protected $watchedFunctionsPathPrefix = '../watched_functions/';
37
38		/**
39		* @var int[]
40		*/
41		protected $countCache;
42
43		/**
44		* @var Xhgui_Storage_Filter
45		*/
46		private $filter;
47
48		/**
49		* Xhgui_Storage_File constructor.
50		* @param $config
51		*/
52		public function __construct($config)
53		{
54		$this->prefix = 'xhgui.data';
55
56		$this->path = $config['save.handler.path'];
57		$this->separateMeta = $config['save.handler.separate_meta'];
58		$this->dataSerializer = $config['save.handler.serializer'];
59		$this->metaSerializer = $config['save.handler.meta_serializer'];
60		}
61
62		/**
63		* @inheritDoc
64		* @param Xhgui_Storage_Filter $filter
65		* @param bool $projections
66		* @return Xhgui_Storage_ResultSet
67		*/
68		public function find(Xhgui_Storage_Filter $filter, $projections = false)
69		{
70
71		if ($filter->getId()) {
72		$result = glob($this->path. DIRECTORY_SEPARATOR.$filter->getId());
73		} else {
74		$result = glob($this->path. $this->prefix . '*');
75		sort($result);
76		}
77
78		$ret = [];
79		foreach ($result as $i => $file) {
80		// skip meta files.
81		if (strpos($file, '.meta') !== false) {
82		continue;
83		}
84
85		// try to detect timestamp in filename, to optimize searching.
86		// If that fails we need to get it after file import from meta.
87		$reqTimeFromFilename = $this->getRequestTimeFromFilename($file);
88		if (!empty($reqTimeFromFilename)) {
89		if (null !== $filter->getStartDate() &&
90		$this->getDateTimeFromString($filter->getStartDate(), 'start') >= $reqTimeFromFilename) {
		0 ignored issues – show Documentation introduced 2019-06-29 17:13 UTC by Report Bug Copy Issue Report `$filter->getStartDate()` is of type `object<DateTime>`, but the function expects a `string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
91		continue;
92		}
93
94		if (null !== $filter->getEndDate() &&
95		$this->getDateTimeFromString($filter->getEndDate(), 'end') <= $reqTimeFromFilename ) {
		0 ignored issues – show Documentation introduced 2019-06-29 17:13 UTC by Report Bug Copy Issue Report `$filter->getEndDate()` is of type `object<DateTime>`, but the function expects a `string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
96		continue;
97		}
98		}
99
100		$metaFile = $this->getMetafileNameFromProfileName($file);
101
102		$meta = $this->importFile($metaFile, true);
103		if ($meta === false) {
104		continue;
105		}
106
107		$profile = $this->importFile($file, false);
108		if ($profile === false) {
109		continue;
110		}
111
112		if (!empty($profile['meta'])) {
113		$meta = array_merge($meta, $profile['meta']);
114		}
115
116		if (empty($reqTimeFromFilename) && (null !== $filter->getStartDate() \|\| null !== $filter->getEndDate())){
117		if (null !== $filter->getStartDate() &&
118		$this->getDateTimeFromString($filter->getStartDate(), 'start') >= $filter->getStartDate()) {
		0 ignored issues – show Documentation introduced 2019-07-05 16:03 UTC by Report Bug Copy Issue Report `$filter->getStartDate()` is of type `object<DateTime>`, but the function expects a `string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
119		continue;
120		}
121		if (null !== $filter->getEndDate() &&
122		$this->getDateTimeFromString($filter->getEndDate(), 'end') <= $filter->getEndDate()) {
		0 ignored issues – show Documentation introduced 2019-07-05 16:03 UTC by Report Bug Copy Issue Report `$filter->getEndDate()` is of type `object<DateTime>`, but the function expects a `string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
123		continue;
124		}
125		}
126
127		if ($filter->getUrl() &&
128		strpos($meta['simple_url'], $filter->getUrl()) === false &&
129		strpos($meta['SERVER']['SERVER_NAME'].$meta['simple_url'], $filter->getUrl()) === false
130		) {
131		continue;
132		}
133
134		if (!empty($profile['profile'])) {
135		$profile = $profile['profile'];
136		}
137
138		if (!empty($profile['_id'])) {
139		$id = $profile['_id'];
140		} else {
141		$id = basename($file);
142		}
143		if (!empty($profile)) {
144		$ret[$id] = [
145		'profile' => $profile,
146		'_id' => $id,
147		'meta' => $meta,
148		];
149		} else {
150		$ret[$id] = $profile;
151		}
152		}
153
154		try {
155		if (!empty($filter->getSort()) && !empty($ret)) {
156		$this->filter = $filter;
157		usort($ret, array($this, 'sortByColumn'));
158		unset($this->filter);
159		}
160		} catch (InvalidArgumentException $e) {
161		// ignore for now.
162		}
163
164		$cacheId = md5(serialize($filter->toArray()));
165
166		$this->countCache[$cacheId] = count($ret);
167		$ret = array_slice($ret, $filter->getPerPage()*($filter->getPage()-1), $filter->getPerPage());
168		$ret = array_column($ret, null, '_id');
169
170		return new Xhgui_Storage_ResultSet($ret, $this->countCache[$cacheId]);
171		}
172
173		/**
174		* @inheritDoc
175		* @param Xhgui_Storage_Filter $filter
176		* @return int
177		*/
178		public function count(Xhgui_Storage_Filter $filter)
179		{
180		$cacheId = md5(serialize($filter->toArray()));
181		if (empty($this->countCache[$cacheId])) {
182		$this->find($filter);
183		}
184		return $this->countCache[$cacheId];
185		}
186
187		/**
188		* @inheritDoc
189		* @param $id
190		* @return mixed
191		*/
192		public function findOne($id)
193		{
194		$filter = new Xhgui_Storage_Filter();
195		$filter->setId($id);
196		$resultSet = $this->find($filter);
197		return $resultSet->current();
198		}
199
200		/**
201		* @inheritDoc
202		* @param $id
203		* @return bool
204		*/
205		public function remove($id)
206		{
207		if (file_exists($this->path.$id)) {
208		$metaFileName = $this->getMetafileNameFromProfileName($id);
209		if (file_exists($this->path.$metaFileName)) {
210		unlink($this->path.$metaFileName);
211		}
212		unlink($this->path.$id);
213		return true;
214		}
215		return false;
216		}
217
218		/**
219		* @inheritDoc
220		*/
221		public function drop()
222		{
223		array_map('unlink', glob($this->path.'*.xhprof'));
224		array_map('unlink', glob($this->path.'*.meta'));
225		}
226
227		/**
228		* @inheritDoc
229		* @param $match
230		* @param $col
231		* @param int $percentile
232		* @return array
233		*/
234		public function aggregate(Xhgui_Storage_Filter $filter, $col, $percentile = 1)
235		{
236		$ret = $this->find($filter);
237
238		$result = [
239		'ok' => 1,
240		'result' => [],
241		];
242
243		foreach ($ret as $row) {
244		$request_date = $row['meta']['request_date'];
245		$result['result'][$request_date]['wall_times'][] = $row['profile']['main()']['wt'];
246		$result['result'][$request_date]['cpu_times'][] = $row['profile']['main()']['cpu'];
247		$result['result'][$request_date]['mu_times'][] = $row['profile']['main()']['mu'];
248		$result['result'][$request_date]['pmu_times'][] = $row['profile']['main()']['pmu'];
249
250		if (empty($result['result'][$request_date]['row_count'])) {
251		$result['result'][$request_date]['row_count'] = 0;
252		}
253		$result['result'][$request_date]['row_count']++;
254
255		$result['result'][$request_date]['raw_index'] =
256		$result['result'][$request_date]['row_count']*($percentile/100);
257
258		$result['result'][$request_date]['_id']= $request_date;
259		}
260
261		return $result;
262		}
263
264
265		/**
266		* Column sorter
267		*
268		* @param $a
269		* @param $b
270		* @return int
271		*/
272		public function sortByColumn($a, $b)
273		{
274		$sort = $this->filter->getSort();
275		switch ($sort) {
276		case 'ct':
277		case 'wt':
278		case 'cpu':
279		case 'mu':
280	View Code Duplication	case 'pmu':
		0 ignored issues – show Duplication introduced 2019-05-19 16:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
281		$aValue = $a['profile']['main()'][$sort];
282		$bValue = $b['profile']['main()'][$sort];
283		break;
284
285	View Code Duplication	case 'time':
		0 ignored issues – show Duplication introduced 2019-05-19 16:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
286		$aValue = $a['meta']['request_ts']['sec'];
287		$bValue = $b['meta']['request_ts']['sec'];
288		break;
289
290		case 'controller':
291		case 'action':
292		case 'application':
293		case 'branch':
294	View Code Duplication	case 'version':
		0 ignored issues – show Duplication introduced 2019-05-19 16:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
295		$aValue = $a['meta'][$sort];
296		$bValue = $b['meta'][$sort];
297		break;
298
299		default:
300		throw new InvalidArgumentException('Invalid sort mode');
301		break;
		0 ignored issues – show Unused Code introduced 2019-05-22 21:32 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
302		}
303
304		if ($aValue == $bValue) {
305		return 0;
306		}
307
308		if (is_numeric($aValue) \|\| is_numeric($bValue)) {
309		if ($this->filter->getDirection() === 'desc') {
310		if ($aValue < $bValue) {
311		return 1;
312		}
313		return -1;
314		}
315
316		if ($aValue > $bValue) {
317		return 1;
318		}
319		return -1;
320		}
321
322		if ($this->filter->getDirection() === 'desc') {
323		return strnatcmp($aValue, $bValue);
324		}
325		return strnatcmp($bValue, $aValue);
326		}
327
328		/**
329		* Generate meta profile name from profile file name.
330		*
331		* In most cases just add .meta extension
332		*
333		* @param $file
334		* @return mixed
335		*/
336		protected function getMetafileNameFromProfileName($file)
337		{
338		$metaFile = $file.'.meta';
339		return $metaFile;
340		}
341
342		/**
343		* Load profile file from disk, prepare it and return parsed array
344		*
345		* @param $path
346		* @param bool $meta
347		* @return mixed
348		*/
349		protected function importFile($path, $meta = false)
350		{
351		if ($meta) {
352		$serializer = $this->metaSerializer;
353		} else {
354		$serializer = $this->dataSerializer;
355		}
356
357		if (!file_exists($path) \|\| !is_readable($path)) {
358		return false;
359		}
360
361		switch ($serializer) {
362		default:
363		case 'json':
364		return json_decode(file_get_contents($path), true);
365
366		case 'serialize':
367		if (PHP_MAJOR_VERSION > 7) {
368		return unserialize(file_get_contents($path), false);
369		}
370		/** @noinspection UnserializeExploitsInspection */
371		return unserialize(file_get_contents($path));
372
373		case 'igbinary_serialize':
374		case 'igbinary_unserialize':
375		case 'igbinary':
376		/** @noinspection PhpComposerExtensionStubsInspection */
377		return igbinary_unserialize(file_get_contents($path));
378
379		// this is a path to a file on disk
380		case 'php':
381		case 'var_export':
382		/** @noinspection PhpIncludeInspection */
383		return include $path;
384		}
385		}
386
387		/**
388		* @inheritDoc
389		* @return array
390		*/
391		public function getWatchedFunctions()
392		{
393		$ret = [];
394		$files = glob($this->watchedFunctionsPathPrefix.'*.json');
395		foreach ($files as $file) {
396		$ret[] = json_decode(file_get_contents($file), true);
397		}
398		return $ret;
399		}
400
401		/**
402		* @inheritDoc
403		* @param $name
404		* @return bool
405		*/
406	View Code Duplication	public function addWatchedFunction($name)
		0 ignored issues – show Duplication introduced 2019-05-19 16:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
407		{
408		$name = trim($name);
409		if (empty($name)) {
410		return false;
411		}
412		$id = md5($name);
413		$i = file_put_contents(
414		$this->watchedFunctionsPathPrefix.$id.'.json',
415		json_encode(['id'=>$id, 'name'=>$name])
416		);
417		return $i > 0;
418		}
419
420		/**
421		* @inheritDoc
422		* @param $id
423		* @param $name
424		* @return bool
425		*/
426	View Code Duplication	public function updateWatchedFunction($id, $name)
		0 ignored issues – show Duplication introduced 2019-05-19 16:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
427		{
428		$name = trim($name);
429		if (empty($name)) {
430		return false;
431		}
432
433		$i = file_put_contents(
434		$this->watchedFunctionsPathPrefix.$id.'.json',
435		json_encode(['id'=>$id, 'name'=>trim($name)])
436		);
437		return $i > 0;
438		}
439
440		/**
441		* @inheritDoc
442		* @param $id
443		*/
444		public function removeWatchedFunction($id)
445		{
446		if (file_exists($this->watchedFunctionsPathPrefix.$id.'.json')) {
447		unlink($this->watchedFunctionsPathPrefix.$id.'.json');
448		}
449		}
450
451		/**
452		* Parse filename and try to get request time from filename
453		*
454		* @param $fileName
455		* @return bool\|DateTime
456		*/
457		public function getRequestTimeFromFilename($fileName)
458		{
459		$matches = [];
460		// default pattern is: xhgui.data.<timestamp>.<microseconds>_a68888
461		// xhgui.data.15 55 31 04 66 .6606_a68888
462		preg_match('/(?<t>[\d]{10})(\.(?<m>[\d]{1,6}))?.+/i', $fileName, $matches);
463		try {
464		return DateTime::createFromFormat('U u', $matches['t'].' '. $matches['m']);
465		} catch (Exception $e) {
466		return null;
467		}
468		}
469		}
470

perftools / xhgui

Pull Request — master (#268)

Xhgui_Storage_File::sortByColumn() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like