Xhgui_Searcher_Pdo::getAll() - Code Metrics - Inspection of "WIP: Backend decoupling" - perftools/xhgui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#244)

by Marcel

created 2018-07-08 19:24 UTC

Xhgui_Searcher_Pdo::getAll() B

↳ Parent: Xhgui_Searcher_Pdo

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	62
rs	8.829
c	0
b	0
f	0
cc	2
nc	2
nop	1

How to fix Long Method

<?php

class Xhgui_Searcher_Pdo implements Xhgui_Searcher_Interface
namespace YourVendor;

class YourClass { }
{
    /**
     * @var Xhgui_Saver_Pdo
     */
    private $saver;

    /**
     * @var PDO
     */
    private $pdo;

    /**
     * @var string
     */
    private $table;

    /**
     * @param Xhgui_Saver_Pdo $saver
     * @param PDO             $pdo   An open database connection
     * @param string          $table Table name where Xhgui profiles are stored
     */
    public function __construct(Xhgui_Saver_Pdo $saver, PDO $pdo, $table)
    {
        $this->saver = $saver;
        $this->pdo = $pdo;
        $this->table = $table;
    }

    /**
     * {@inheritdoc}
     */
    public function latest()

    {
        $stmt = $this->pdo->query("
          SELECT
            id,
            profile,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date
          FROM {$this->table}
          ORDER BY request_date ASC
          LIMIT 1
        ");

        if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
            throw new Exception('No profile available yet.');
        }

        return new Xhgui_Profile([
            '_id' => $row['id'],
            'meta' => [
                'url' => $row['url'],
                'SERVER' => json_decode($row['SERVER'], true),
                'get' => json_decode($row['GET'], true),
                'env' => json_decode($row['ENV'], true),
                'simple_url' => $row['simple_url'],
                'request_ts' => (int) $row['request_ts'],
                'request_ts_micro' => $row['request_ts_micro'],
                'request_date' => $row['request_date'],
            ],
            'profile' => json_decode($row['profile'], true)
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function query($conditions, $limit, $fields = [])
    {
        // TODO: Implement query() method.
    }

    /**
     * {@inheritdoc}
     */
    public function get($id)

    {
        $stmt = $this->pdo->prepare("
          SELECT
            profile,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date
          FROM {$this->table}
          WHERE id = :id
        ");

        $stmt->execute(['id' => $id]);

        if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
            throw new Exception('No profile data found.');
        }

        return new Xhgui_Profile([
            '_id' => $id,
            'meta' => [
                'url' => $row['url'],
                'SERVER' => json_decode($row['SERVER'], true),
                'get' => json_decode($row['GET'], true),
                'env' => json_decode($row['ENV'], true),
                'simple_url' => $row['simple_url'],
                'request_ts' => (int) $row['request_ts'],
                'request_ts_micro' => $row['request_ts_micro'],
                'request_date' => $row['request_date'],
            ],
            'profile' => json_decode($row['profile'], true)
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function getForUrl($url, $options, $conditions = array())
    {
        // TODO: Implement getForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getPercentileForUrl($percentile, $url, $search = array())
    {
        // TODO: Implement getPercentileForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getAvgsForUrl($url, $search = array())
    {
        // TODO: Implement getAvgsForUrl() method.
    }

    /**
     * {@inheritdoc}
     */
    public function getAll($options = array())
    {
        $sort = $options['sort'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $direction = $options['direction'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $page = $options['page'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $perPage = $options['perPage'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $stmt = $this->pdo->query("
          SELECT
            id,
            url,
            SERVER,
            GET,
            ENV,
            simple_url,
            request_ts,
            request_ts_micro,
            request_date,
            main_wt,
            main_ct,
            main_cpu, 
            main_mu,
            main_pmu
          FROM {$this->table}
          ORDER BY request_ts DESC
        ", PDO::FETCH_ASSOC);

        $results = [];
        foreach ($stmt->fetchAll(PDO::FETCH_ASSOC) as $row) {
            $results[] = new Xhgui_Profile([
                '_id' => $row['id'],
                'meta' => [
                    'url' => $row['url'],
                    'SERVER' => json_decode($row['SERVER'], true),
                    'get' => json_decode($row['GET'], true),
                    'env' => json_decode($row['ENV'], true),
                    'simple_url' => $row['simple_url'],
                    'request_ts' => $row['request_ts'],
                    'request_ts_micro' => $row['request_ts_micro'],
                    'request_date' => $row['request_date'],
                ],
                'profile' => [
                    'main()' => [
                        'wt' => (int) $row['main_wt'],
                        'ct' => (int) $row['main_ct'],
                        'cpu' => (int) $row['main_cpu'],
                        'mu' => (int) $row['main_mu'],
                        'pmu' => (int) $row['main_pmu'],
                    ]
                ]
            ]);
        }

        return array(
            'results' => $results,
            'sort' => 'meta.request_ts',
            'direction' => 'desc',
            'page' => 1,
            'perPage' => count($results),
            'totalPages' => 1
        );
    }

    /**
     * {@inheritdoc}
     */
    public function insert($profile)
    {
        $this->saver->save($profile);
    }

    /**
     * {@inheritdoc}
     */
    public function delete($id)
    {
        $stmt = $this->pdo->prepare("
          DELETE FROM {$this->table}
          WHERE id = :id
        ");

        $stmt->execute(['id' => $id]);
    }

    /**
     * {@inheritdoc}
     */
    public function truncate()
    {
        return is_int(
            $this->pdo->exec("DROP TABLE IF EXISTS {$this->table}")
        );
    }
}


1		<?php
2
3		class Xhgui_Searcher_Pdo implements Xhgui_Searcher_Interface
		0 ignored issues – show Coding Style Compatibility introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		/**
6		* @var Xhgui_Saver_Pdo
7		*/
8		private $saver;
9
10		/**
11		* @var PDO
12		*/
13		private $pdo;
14
15		/**
16		* @var string
17		*/
18		private $table;
19
20		/**
21		* @param Xhgui_Saver_Pdo $saver
22		* @param PDO $pdo An open database connection
23		* @param string $table Table name where Xhgui profiles are stored
24		*/
25		public function __construct(Xhgui_Saver_Pdo $saver, PDO $pdo, $table)
26		{
27		$this->saver = $saver;
28		$this->pdo = $pdo;
29		$this->table = $table;
30		}
31
32		/**
33		* {@inheritdoc}
34		*/
35	View Code Duplication	public function latest()
		0 ignored issues – show Duplication introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$stmt = $this->pdo->query("
38		SELECT
39		id,
40		profile,
41		url,
42		SERVER,
43		GET,
44		ENV,
45		simple_url,
46		request_ts,
47		request_ts_micro,
48		request_date
49		FROM {$this->table}
50		ORDER BY request_date ASC
51		LIMIT 1
52		");
53
54		if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
55		throw new Exception('No profile available yet.');
56		}
57
58		return new Xhgui_Profile([
59		'_id' => $row['id'],
60		'meta' => [
61		'url' => $row['url'],
62		'SERVER' => json_decode($row['SERVER'], true),
63		'get' => json_decode($row['GET'], true),
64		'env' => json_decode($row['ENV'], true),
65		'simple_url' => $row['simple_url'],
66		'request_ts' => (int) $row['request_ts'],
67		'request_ts_micro' => $row['request_ts_micro'],
68		'request_date' => $row['request_date'],
69		],
70		'profile' => json_decode($row['profile'], true)
71		]);
72		}
73
74		/**
75		* {@inheritdoc}
76		*/
77		public function query($conditions, $limit, $fields = [])
78		{
79		// TODO: Implement query() method.
80		}
81
82		/**
83		* {@inheritdoc}
84		*/
85	View Code Duplication	public function get($id)
		0 ignored issues – show Duplication introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		$stmt = $this->pdo->prepare("
88		SELECT
89		profile,
90		url,
91		SERVER,
92		GET,
93		ENV,
94		simple_url,
95		request_ts,
96		request_ts_micro,
97		request_date
98		FROM {$this->table}
99		WHERE id = :id
100		");
101
102		$stmt->execute(['id' => $id]);
103
104		if (false === $row = $stmt->fetch(PDO::FETCH_ASSOC)) {
105		throw new Exception('No profile data found.');
106		}
107
108		return new Xhgui_Profile([
109		'_id' => $id,
110		'meta' => [
111		'url' => $row['url'],
112		'SERVER' => json_decode($row['SERVER'], true),
113		'get' => json_decode($row['GET'], true),
114		'env' => json_decode($row['ENV'], true),
115		'simple_url' => $row['simple_url'],
116		'request_ts' => (int) $row['request_ts'],
117		'request_ts_micro' => $row['request_ts_micro'],
118		'request_date' => $row['request_date'],
119		],
120		'profile' => json_decode($row['profile'], true)
121		]);
122		}
123
124		/**
125		* {@inheritdoc}
126		*/
127		public function getForUrl($url, $options, $conditions = array())
128		{
129		// TODO: Implement getForUrl() method.
130		}
131
132		/**
133		* {@inheritdoc}
134		*/
135		public function getPercentileForUrl($percentile, $url, $search = array())
136		{
137		// TODO: Implement getPercentileForUrl() method.
138		}
139
140		/**
141		* {@inheritdoc}
142		*/
143		public function getAvgsForUrl($url, $search = array())
144		{
145		// TODO: Implement getAvgsForUrl() method.
146		}
147
148		/**
149		* {@inheritdoc}
150		*/
151		public function getAll($options = array())
152		{
153		$sort = $options['sort'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$sort` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
154		$direction = $options['direction'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$direction` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
155		$page = $options['page'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$page` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
156		$perPage = $options['perPage'];
		0 ignored issues – show Unused Code introduced 2018-07-08 19:27 UTC by Report Bug Copy Issue Report `$perPage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
157
158		$stmt = $this->pdo->query("
159		SELECT
160		id,
161		url,
162		SERVER,
163		GET,
164		ENV,
165		simple_url,
166		request_ts,
167		request_ts_micro,
168		request_date,
169		main_wt,
170		main_ct,
171		main_cpu,
172		main_mu,
173		main_pmu
174		FROM {$this->table}
175		ORDER BY request_ts DESC
176		", PDO::FETCH_ASSOC);
177
178		$results = [];
179		foreach ($stmt->fetchAll(PDO::FETCH_ASSOC) as $row) {
180		$results[] = new Xhgui_Profile([
181		'_id' => $row['id'],
182		'meta' => [
183		'url' => $row['url'],
184		'SERVER' => json_decode($row['SERVER'], true),
185		'get' => json_decode($row['GET'], true),
186		'env' => json_decode($row['ENV'], true),
187		'simple_url' => $row['simple_url'],
188		'request_ts' => $row['request_ts'],
189		'request_ts_micro' => $row['request_ts_micro'],
190		'request_date' => $row['request_date'],
191		],
192		'profile' => [
193		'main()' => [
194		'wt' => (int) $row['main_wt'],
195		'ct' => (int) $row['main_ct'],
196		'cpu' => (int) $row['main_cpu'],
197		'mu' => (int) $row['main_mu'],
198		'pmu' => (int) $row['main_pmu'],
199		]
200		]
201		]);
202		}
203
204		return array(
205		'results' => $results,
206		'sort' => 'meta.request_ts',
207		'direction' => 'desc',
208		'page' => 1,
209		'perPage' => count($results),
210		'totalPages' => 1
211		);
212		}
213
214		/**
215		* {@inheritdoc}
216		*/
217		public function insert($profile)
218		{
219		$this->saver->save($profile);
220		}
221
222		/**
223		* {@inheritdoc}
224		*/
225		public function delete($id)
226		{
227		$stmt = $this->pdo->prepare("
228		DELETE FROM {$this->table}
229		WHERE id = :id
230		");
231
232		$stmt->execute(['id' => $id]);
233		}
234
235		/**
236		* {@inheritdoc}
237		*/
238		public function truncate()
239		{
240		return is_int(
241		$this->pdo->exec("DROP TABLE IF EXISTS {$this->table}")
242		);
243		}
244		}
245

perftools / xhgui

Pull Request — master (#244)

Xhgui_Searcher_Pdo::getAll() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like