Xhgui_Saver::factory() - Code Metrics - Inspection of "Introduce multiple storage drivers" - perftools/xhgui-collector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

unknown

created 2019-06-29 18:01 UTC

Xhgui_Saver::factory() B

↳ Parent: Xhgui_Saver

Complexity

Conditions	10
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	44
rs	7.6666
c	0
b	0
f	0
cc	10
nc	6
nop	1

How to fix Complexity

<?php
/**
 * A small factory to handle creation of the profile saver instance.
 *
 * This class only exists to handle cases where an incompatible version of pimple
 * exists in the host application.
 */
class Xhgui_Saver
{
    /**
     * Get a saver instance based on configuration data.
     *
     * @param array $config The configuration data.
     * @return Xhgui_Saver_Interface
     * @throws MongoConnectionException
     * @throws MongoException
     */
    public static function factory($config)
    {
        switch ($config['save.handler']) {
            case 'file':
                return new Xhgui_Saver_File(
                    $config['save.handler.filename'],
                    $config['save.handler.separate_meta']
                );

            case 'upload':
                $timeout = 3;
                if (isset($config['save.handler.upload.timeout'])) {
                    $timeout = $config['save.handler.upload.timeout'];
                }
                return new Xhgui_Saver_Upload(
                    $config['save.handler.upload.uri'],
                    $timeout
                );

            case 'pdo':
                return new Xhgui_Saver_PDO(
                    $config['db.dsn'],
                    (!empty($config['db.user'])) ? $config['db.user'] : null,
                    (!empty($config['db.password'])) ? $config['db.password'] : null,
                    $config['db.options']
                );
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'mongodb':
            default:
                $mongo = new MongoClient(
                    $config['db.host'],
                    $config['db.options'] +
                    [
                        'username' => (!empty($config['db.user'])) ? $config['db.user'] : null,
                        'password' => (!empty($config['db.password'])) ? $config['db.password'] : null,
                    ]
                );

                $collection = $mongo->{$config['db.db']}->results;
                $collection->findOne();
                return new Xhgui_Saver_Mongo($collection);
        }
    }

    /**
     * For usage with factory instance - for example for easier testing
     *
     * @param $config
     * @return Xhgui_Saver_Interface
     * @throws MongoConnectionException
     * @throws MongoException
     */
    public function create($config)
    {
        return self::factory($config);
    }
}


1			<?php
2			/**
3			* A small factory to handle creation of the profile saver instance.
4			*
5			* This class only exists to handle cases where an incompatible version of pimple
6			* exists in the host application.
7			*/
8			class Xhgui_Saver
9			{
10			/**
11			* Get a saver instance based on configuration data.
12			*
13			* @param array $config The configuration data.
14			* @return Xhgui_Saver_Interface
15			* @throws MongoConnectionException
16			* @throws MongoException
17			*/
18			public static function factory($config)
19			{
20			switch ($config['save.handler']) {
21			case 'file':
22			return new Xhgui_Saver_File(
23			$config['save.handler.filename'],
24			$config['save.handler.separate_meta']
25			);
26
27			case 'upload':
28			$timeout = 3;
29			if (isset($config['save.handler.upload.timeout'])) {
30			$timeout = $config['save.handler.upload.timeout'];
31			}
32			return new Xhgui_Saver_Upload(
33			$config['save.handler.upload.uri'],
34			$timeout
35			);
36
37			case 'pdo':
38			return new Xhgui_Saver_PDO(
39			$config['db.dsn'],
40			(!empty($config['db.user'])) ? $config['db.user'] : null,
41			(!empty($config['db.password'])) ? $config['db.password'] : null,
42			$config['db.options']
43			);
44			break;
			0 ignored issues – show Unused Code introduced 2019-06-29 18:02 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
45
46			case 'mongodb':
47			default:
48			$mongo = new MongoClient(
49			$config['db.host'],
50			$config['db.options'] +
51			[
52			'username' => (!empty($config['db.user'])) ? $config['db.user'] : null,
53			'password' => (!empty($config['db.password'])) ? $config['db.password'] : null,
54			]
55			);
56
57			$collection = $mongo->{$config['db.db']}->results;
58			$collection->findOne();
59			return new Xhgui_Saver_Mongo($collection);
60			}
61			}
62
63			/**
64			* For usage with factory instance - for example for easier testing
65			*
66			* @param $config
67			* @return Xhgui_Saver_Interface
68			* @throws MongoConnectionException
69			* @throws MongoException
70			*/
71			public function create($config)
72			{
73			return self::factory($config);
74			}
75			}
76

perftools / xhgui-collector

Pull Request — master (#28)

Xhgui_Saver::factory() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like