SanitizesInput - Code Metrics - Inspection of "Merge pull request #3 from devcircus/support-Larav..." - perfect-oblivion/valid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 38c232...09476f )

by Clayton

created 2019-09-03 21:00 UTC

SanitizesInput A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	64
c	0
b	0
f	0
wmc	7
lcom	1
cbo	0
rs	10

6 Methods

Rating	Name	Size	Complexity
A	validate()	5	1
A	validateResolved()	5	1
A	sanitize()	6	1
A	addCustomFilters()	6	2
A	filters()	4	1
A	customFilters()	4	1

<?php
/**
 * File copied from Waavi/Sanitizer https://github.com/waavi/sanitizer
 * Sanitization functionality to be customized within this project before a 1.0 release.
 */

namespace PerfectOblivion\Valid\Sanitizer\Laravel;

trait SanitizesInput
{
    /**
     *  Sanitize input before validating.
     *
     *  Kept for backwards compatibility with Laravel <= 5.5
     */
    public function validate()
    {
        $this->sanitize();
        parent::validate();
    }

    /**
     *  Sanitize input before validating.
     *
     *  Compatible with Laravel 5.6+
     */
    public function validateResolved()
    {
        $this->sanitize();
        parent::validateResolved();
    }

    /**
     *  Sanitize this request's input
     */
    public function sanitize()
    {
        $this->addCustomFilters();
        $this->sanitizer = app('sanitizer')->make($this->input(), $this->filters());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->replace($this->sanitizer->sanitize());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     *  Add custom fields to the Sanitizer
     */
    public function addCustomFilters()
    {
        foreach ($this->customFilters() as $name => $filter) {
            app('sanitizer')->extend($name, $filter);
        }
    }

    /**
     *  Filters to be applied to the input.
     *
     *  @return array
     */
    public function filters()
    {
        return [];
    }

    /**
     *  Custom Filters to be applied to the input.
     *
     *  @return array
     */
    public function customFilters()
    {
        return [];
    }
}


1			<?php
2			/**
3			* File copied from Waavi/Sanitizer https://github.com/waavi/sanitizer
4			* Sanitization functionality to be customized within this project before a 1.0 release.
5			*/
6
7			namespace PerfectOblivion\Valid\Sanitizer\Laravel;
8
9			trait SanitizesInput
10			{
11			/**
12			* Sanitize input before validating.
13			*
14			* Kept for backwards compatibility with Laravel <= 5.5
15			*/
16			public function validate()
17			{
18			$this->sanitize();
19			parent::validate();
20			}
21
22			/**
23			* Sanitize input before validating.
24			*
25			* Compatible with Laravel 5.6+
26			*/
27			public function validateResolved()
28			{
29			$this->sanitize();
30			parent::validateResolved();
31			}
32
33			/**
34			* Sanitize this request's input
35			*/
36			public function sanitize()
37			{
38			$this->addCustomFilters();
39			$this->sanitizer = app('sanitizer')->make($this->input(), $this->filters());
			0 ignored issues – show Bug introduced 2019-09-03 20:40 UTC by Report Bug Copy Issue Report The property `sanitizer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2019-09-03 20:40 UTC by Report Bug Copy Issue Report It seems like `input()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40			$this->replace($this->sanitizer->sanitize());
			0 ignored issues – show Bug introduced 2019-09-03 20:40 UTC by Report Bug Copy Issue Report It seems like `replace()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42
43			/**
44			* Add custom fields to the Sanitizer
45			*/
46			public function addCustomFilters()
47			{
48			foreach ($this->customFilters() as $name => $filter) {
49			app('sanitizer')->extend($name, $filter);
50			}
51			}
52
53			/**
54			* Filters to be applied to the input.
55			*
56			* @return array
57			*/
58			public function filters()
59			{
60			return [];
61			}
62
63			/**
64			* Custom Filters to be applied to the input.
65			*
66			* @return array
67			*/
68			public function customFilters()
69			{
70			return [];
71			}
72			}
73

perfect-oblivion / valid

Push — master ( 38c232...09476f )

SanitizesInput A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like