pepeverde / GestPayWS

src/Response/EncryptResponse.php

<?php

/*
 * This file is part of the GestPayWS library.
 *
 * (c) Manuel Dalla Lana <endelwar@aregar.it>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace EndelWar\GestPayWS\Response;

/**
 * Class EncryptResponse
 *
 * @property string $TransactionType;
 * @property string $TransactionResult;
 * @property string $CryptDecryptString;
 * @property int $ErrorCode;
 * @property string $ErrorDescription;
 */
class EncryptResponse extends Response
{
    protected $paymentPageUrl = [
        'test' => 'https://sandbox.gestpay.net/pagam/pagam.aspx',
        'production' => 'https://ecomm.sella.it/pagam/pagam.aspx',
    ];
    protected $parametersName = [
        'TransactionType',
        'TransactionResult',
        'CryptDecryptString',
        'ErrorCode',
        'ErrorDescription',
    ];

    /**
     * @param \stdClass $soapResponse
     * @throws \Exception
     */
    public function __construct($soapResponse)
    {
        $xml = simplexml_load_string($soapResponse->EncryptResult->any);
        parent::__construct($xml);

It seems like $xml can also be of type false; however, parameter $xml of EndelWar\GestPayWS\Response\Response::__construct() does only seem to accept SimpleXMLElement, maybe add an additional type check?

    }

    /**
     * @param string $shopLogin
     * @param string $wsdlEnvironment
     * @return string
     */
    public function getPaymentPageUrl($shopLogin, $wsdlEnvironment)
    {
        return $this->paymentPageUrl[$wsdlEnvironment] . '?a=' . $shopLogin . '&b=' . $this->CryptDecryptString;

The property CryptDecryptString does not exist on EndelWar\GestPayWS\Response\EncryptResponse. Since you implemented __get, consider adding a @property annotation.

    }
}