Merchant::getTransactionsByMerchantId() - Code Metrics - Inspection of "Update the scrutinizer.yml again" - pengyue/Awin-ReportTask - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 659f53...df9043 )

by Peng

created 2018-01-15 22:09 UTC

Merchant::getTransactionsByMerchantId() A

↳ Parent: Merchant

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	1
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Awin\ReportTask\Bundle\ReportBundle\Model;

use Awin\ReportTask\Bundle\ReportBundle\Exception\TransactionRepositoryNotFoundException;

/**
 * The merchant model class, which is for the merchant data management
 *
 * @date       24/06/2017
 * @time       13:15
 * @author     Peng Yue <[email protected]>
 * @copyright  2004-2017 Peng Yue
 */

class Merchant
{
    /**
     * Set the transaction repository
     *
     * @var TransactionTable
     */
    private $transactionRepository;

    public function setTransactionRepository(TransactionTable $transactionTable)
    {
        $this->transactionRepository = $transactionTable;

        return $this;
    }

    /**
     * Get the transaction repository
     *
     * @return TransactionTable
     */
    public function getTransactionRepository()
    {
        return $this->transactionRepository;
    }

    /**
     * Get the transactions by merchant id
     *
     * @param int $merchantId
     *
     * @return array
     */
    public function getTransactionsByMerchantId($merchantId)
    {
        if (!$this->getTransactionRepository() instanceof TransactionTable) {

            throw new TransactionRepositoryNotFoundException();
        }

        return array_filter(
            $this->getTransactionRepository()->getTransactions(),
            function ($e) use ($merchantId) {
                return (int)$e[0] === (int)$merchantId;
            }
        );
    }
}

1			<?php
2
3			namespace Awin\ReportTask\Bundle\ReportBundle\Model;
4
5			use Awin\ReportTask\Bundle\ReportBundle\Exception\TransactionRepositoryNotFoundException;
6
7			/**
8			* The merchant model class, which is for the merchant data management
9			*
10			* @date 24/06/2017
11			* @time 13:15
12			* @author Peng Yue <[email protected]>
13			* @copyright 2004-2017 Peng Yue
14			*/
15
16			class Merchant
17			{
18			/**
19			* Set the transaction repository
20			*
21			* @var TransactionTable
22			*/
23			private $transactionRepository;
24
25			public function setTransactionRepository(TransactionTable $transactionTable)
26			{
27			$this->transactionRepository = $transactionTable;
28
29			return $this;
30			}
31
32			/**
33			* Get the transaction repository
34			*
35			* @return TransactionTable
36			*/
37			public function getTransactionRepository()
38			{
39			return $this->transactionRepository;
40			}
41
42			/**
43			* Get the transactions by merchant id
44			*
45			* @param int $merchantId
46			*
47			* @return array
48			*/
49			public function getTransactionsByMerchantId($merchantId)
50			{
51			if (!$this->getTransactionRepository() instanceof TransactionTable) {
			0 ignored issues – show introduced 2018-01-15 13:16 UTC by Report Bug Copy Issue Report The condition `! $this->getTransactionR...\Model\TransactionTable` can never be `true`. Loading history...
52			throw new TransactionRepositoryNotFoundException();
53			}
54
55			return array_filter(
56			$this->getTransactionRepository()->getTransactions(),
57			function ($e) use ($merchantId) {
58			return (int)$e[0] === (int)$merchantId;
59			}
60			);
61			}
62			}

pengyue / Awin-ReportTask

GitHub Access Token became invalid

Push — master ( 659f53...df9043 )

Merchant::getTransactionsByMerchantId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like