Awin\ReportTask\Bundle\ReportBundle\Service\Observer\ReportObserver

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	listenReportGeneration()	0	17	3

<?php

namespace Awin\ReportTask\Bundle\ReportBundle\Service\Observer;

use Awin\ReportTask\Bundle\ReportBundle\Service\CurrencyServiceInterface;

/**
 * Get the exchange rate from currency service and and do the currency exchange calculation
 *
 * @date       24/06/2017
 * @time       17:56
 * @author     Peng Yue <penyue@gmail.com>
 * @copyright  2004-2017 Peng Yue
 */

class ReportObserver implements ReportObserverInterface
{
    /**
     * Listen to the report generation and apply the changes to data
     *
     * @param array                     $data
     * @param CurrencyServiceInterface  $currencyService
     *
     * @return array
     */
    public function listenReportGeneration(array $data, CurrencyServiceInterface $currencyService)
    {
        $results = [];
        foreach ($data as $item) {
            $temp = [];
            foreach ($currencyService->getCurrencies() as $currency => $symbol) {
                $convertAmount = $currencyService
                    ->getCurrencyConverter()
                    ->setOriginalCurrency($currencyService->symbolToCurrency($item[3]))

The method symbolToCurrency() does not exist on Awin\ReportTask\Bundle\ReportBundle\Service\CurrencyServiceInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Awin\ReportTask\Bundle\ReportBundle\Service\CurrencyServiceInterface.

                    ->setTargetCurrency($currency)
                    ->convert($item[4]);
                $temp[] = sprintf('%s%.2F', $symbol, $convertAmount);
            }
            $results[] = array_merge($item, $temp);
        }

        return $results;
    }
}