pelmered / laravel-http-client-auth-helper

src/UrlHelper.php

<?php
namespace Pelmered\LaravelHttpOAuthHelper;

use Illuminate\Http\Client\Response;

class UrlHelper
{
    public static function parseQueryTokenFromResponse(Response $response, string $queryKey = 'token'): ?string
    {
        $uri = $response->effectiveUri();

        if (! $uri) {

$uri is of type Psr\Http\Message\UriInterface, thus it always evaluated to true.

            return null;
        }

        return self::parseTokenFromQueryString($response->effectiveUri()?->getQuery(), $queryKey);

The expression return self::parseTokenFromQueryString($response->effectiveUri()->getQuery(), $queryKey) could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public static function parseQueryTokenFromUrl(string $url, string $queryKey = 'token'): ?string
    {
        $queryString = parse_url($url, PHP_URL_QUERY);

        if (! $queryString) {
            return null;
        }

        return self::parseTokenFromQueryString($queryString, $queryKey);

The expression return self::parseTokenFromQueryString($queryString, $queryKey) could return the type array which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

    }

    public static function parseTokenFromQueryString(string $queryString, string $queryKey = 'token'): null|string|array
    {
        parse_str($queryString, $output);

        if (! isset($output[$queryKey])) {
            return null;
        }

        return $output[$queryKey] ?? null;
    }
}