TransportFactory::create() - Code Metrics - Inspection of "Refactoring classes to use a common exception mess..." - pedromdev/elasticsearch-module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#12)

by Pedro

created 2017-02-27 09:27 UTC

TransportFactory::create() A

↳ Parent: TransportFactory

Complexity

Conditions	4
Paths	8

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	12
cts	12
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	12
nc	8
nop	2
crap	4

<?php

namespace ElasticsearchModule\Service;

use Elasticsearch\ConnectionPool\AbstractConnectionPool;
use Elasticsearch\Transport;
use Zend\ServiceManager\Exception\ServiceNotCreatedException;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * @author Pedro Alves <[email protected]>
 */
class TransportFactory extends AbstractFactory
{
    use InvalidTypeExceptionTrait;
 
    /**
     * {@inheritDoc}
     */
    protected function create(ServiceLocatorInterface $serviceLocator, $config)
    {
        $retries = isset($config['retries']) ? $config['retries'] : 2;
        $sniffOnStart = isset($config['sniff_on_start']) ? $config['sniff_on_start'] : false;
        $connectionPool = $serviceLocator->get($config['connection_pool']);
        
        if (!$connectionPool instanceof AbstractConnectionPool) {
            throw $this->getException(
                'connection pool',
                AbstractConnectionPool::class,
                ServiceNotCreatedException::class,
                $connectionPool
            );
        }
        $loggers = $serviceLocator->get($config['loggers']);
        
        return new Transport($retries, $sniffOnStart, $connectionPool, $loggers['logger']);
    }

    /**
     * {@inheritDoc}
     */
    public function getServiceType()
    {
        return 'transport';
    }
}


1		<?php
2
3		namespace ElasticsearchModule\Service;
4
5		use Elasticsearch\ConnectionPool\AbstractConnectionPool;
6		use Elasticsearch\Transport;
7		use Zend\ServiceManager\Exception\ServiceNotCreatedException;
8		use Zend\ServiceManager\ServiceLocatorInterface;
9
10		/**
11		* @author Pedro Alves <[email protected]>
12		*/
13		class TransportFactory extends AbstractFactory
14		{
15		use InvalidTypeExceptionTrait;
16
17		/**
18		* {@inheritDoc}
19		*/
20	10	protected function create(ServiceLocatorInterface $serviceLocator, $config)
21		{
22	10	$retries = isset($config['retries']) ? $config['retries'] : 2;
23	10	$sniffOnStart = isset($config['sniff_on_start']) ? $config['sniff_on_start'] : false;
24	10	$connectionPool = $serviceLocator->get($config['connection_pool']);
25
26	10	if (!$connectionPool instanceof AbstractConnectionPool) {
27	1	throw $this->getException(
28	1	'connection pool',
29	1	AbstractConnectionPool::class,
30	1	ServiceNotCreatedException::class,
31		$connectionPool
32	1	);
33		}
34	9	$loggers = $serviceLocator->get($config['loggers']);
35
36	9	return new Transport($retries, $sniffOnStart, $connectionPool, $loggers['logger']);
37		}
38
39		/**
40		* {@inheritDoc}
41		*/
42	10	public function getServiceType()
43		{
44	10	return 'transport';
45		}
46		}
47

pedromdev / elasticsearch-module

Pull Request — master (#12)

TransportFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like