Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class Entity extends AbstractAdapter |
||
| 14 | { |
||
| 15 | |||
| 16 | public $pastName = 'Entity'; |
||
| 17 | protected $fileTpl = "entity.php"; |
||
| 18 | protected $fileFixedData = array ( |
||
| 19 | 'parentclass' => array ( |
||
| 20 | 'name' => "AbstractEntity" , |
||
| 21 | 'tpl' => "entity_abstract.php" |
||
| 22 | ) |
||
| 23 | ); |
||
| 24 | |||
| 25 | protected $overwrite = true; |
||
| 26 | |||
| 27 | protected $validFunc = array (); |
||
| 28 | |||
| 29 | private $intersectDependence = false; |
||
|
|
|||
| 30 | |||
| 31 | /** |
||
| 32 | * @param \Classes\MakerFile $makerFile |
||
| 33 | * @param \Classes\Db\DbTable $dbTable |
||
| 34 | * |
||
| 35 | * @return array |
||
| 36 | */ |
||
| 37 | public function parseRelation ( \Classes\MakerFile $makerFile, \Classes\Db\DbTable $dbTable ) |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param \Classes\MakerFile $makerFile |
||
| 47 | * @param \Classes\Db\DbTable $dbTable |
||
| 48 | * |
||
| 49 | * @return array |
||
| 50 | */ |
||
| 51 | View Code Duplication | private function listParents ( \Classes\MakerFile $makerFile, \Classes\Db\DbTable $dbTable ) |
|
| 76 | |||
| 77 | /** |
||
| 78 | * @param \Classes\MakerFile $makerFile |
||
| 79 | * @param \Classes\Db\DbTable $dbTable |
||
| 80 | * |
||
| 81 | * @return array |
||
| 82 | */ |
||
| 83 | View Code Duplication | private function listDependence ( \Classes\MakerFile $makerFile, \Classes\Db\DbTable $dbTable ) |
|
| 109 | |||
| 110 | } |
||
| 111 |
This check marks private properties in classes that are never used. Those properties can be removed.